Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Mutation Event issues by using Mutation Observer instead #1

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

ObadaS
Copy link
Collaborator

@ObadaS ObadaS commented Oct 25, 2024

@Didayolo

This is a fix of the Chrome issue reported here : codalab/codalab-competitions#3503

It is based on bradleyg@d7d4d29 with some modification since this code alone didn't work.

To test this code on Codalab:

  • Clone codalab into a new folder
  • Switch branch to chromeFix
  • Connect a working MinIO to codalab through the .env
  • Build the stack docker compose up -d
  • Open Chrome, go to localhost then upload a competition
  • Make a submission on this new competition. It should work fine. The error in the Chrome dev console should also be gone

I don't have any large submission to test so it would be nice if this can be tested too.

@ObadaS ObadaS requested a review from Didayolo October 25, 2024 10:25
@Didayolo Didayolo self-assigned this Oct 28, 2024
@Didayolo Didayolo merged commit 9934f37 into feature/allow-different-endpoint Oct 28, 2024
@Didayolo Didayolo deleted the chromeFix branch October 28, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants