Fix BestModeStrategy to exclude soft-deleted and non-finished submissions #2066
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A brief description of the purpose of the changes contained in this PR.
This PR ensures that
BestModeStrategy, used for publishing results on the leaderboard by forcing the best result, only picks up submissions that have finished (and may have a score attached) and are not soft deleted.Issues this PR resolves
Fixes #2044
Fixes #1284 (failed submissions are now discarded, blocking n/a scores associated with failed submissions).
Fixes #1840
Fixes #2057
A checklist for hand testing
Checklist