[WIP] Using docker-py and podman-py instead of the current subprocess way of doing things #2065
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wlln
reviewed
Nov 17, 2025
compute_worker/compute_worker.py
Outdated
| except docker.errors.NotFound as e: | ||
| if os.environ.get("CONTAINER_ENGINE_EXECUTABLE").lower() == 'docker': | ||
| client.start(container=container.get('Id')) | ||
| conatinerLogsDemux = client.attach(container, demux=True, stream=True, logs=True) |
Collaborator
There was a problem hiding this comment.
You wrote conatinerLogsDemux instead of containerLogsDemux
compute_worker/compute_worker.py
Outdated
| conatinerLogsDemux = client.attach(container, demux=True, stream=True, logs=True) | ||
| elif os.environ.get("CONTAINER_ENGINE_EXECUTABLE").lower() == 'podman': | ||
| client.containers.start(container) | ||
| conatinerLogsDemux = client.containers.attach(container, stream=True, demux=True) |
Collaborator
There was a problem hiding this comment.
You wrote conatinerLogsDemux instead of containerLogsDemux
compute_worker/compute_worker.py
Outdated
| conatinerLogsDemux = client.containers.attach(container, stream=True, demux=True) | ||
| # If we enter the for loop after the container exited, the program will get stuck | ||
| if client.inspect_container(container)['State']['Status'].lower() == 'running': | ||
| for log in conatinerLogsDemux: |
Collaborator
There was a problem hiding this comment.
You wrote conatinerLogsDemux instead of containerLogsDemux
added 5 commits
November 17, 2025 18:26
…an and docker containers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A brief description of the purpose of the changes contained in this PR.
Changed the code to use the Docker and Podman python packages instead of using the current subprocess way of launching containers for the compute worker.
The main thing left to do is to make the stream from the logs of the container to the codabench instance work
Checklist