Skip to content

Conversation

@ObadaS
Copy link
Collaborator

@ObadaS ObadaS commented Oct 10, 2025

A brief description of the purpose of the changes contained in this PR.

Colored JSON logs when using the serialized=true
Made run argument prettier for compute worker

Run Argument (Compute Worker)

Old

image

New

image The colors can be customized in the `logs_loguru.py` file.

The alternative way of doing it would most likely not colorize the logs like this, so we would have to decide which way we would rather use.

And this is the new new JSON format with colors. We can customize the content of the messages as well as the colors in the logs_loguru.py

JSON format

Old

image

New

image

Issues this PR resolves

#1956

Checklist

  • Code review by me
  • Hand tested by me
  • I'm proud of my work
  • Code review by reviewer
  • Hand tested by reviewer
  • CircleCi tests are passing
  • Ready to merge

@Didayolo
Copy link
Member

Didayolo commented Oct 14, 2025

Suggestion: rename the env variable SERIALIZED to SERIALIZED_LOGS or something else.


Also, using the settings/base.py file for the settings:

https://github.com/codalab/codabench/blob/develop/src/settings/base.py

@ihsaan-ullah
Copy link
Collaborator

ihsaan-ullah commented Oct 14, 2025

Maybe SERIALIZE_LOGS with this reasoning:

Boolean names should describe an action or state clearly

SERIALIZE_LOGS=True reads naturally as “Do we serialize logs?” — a clear yes/no question.
SERIALIZED_LOGS=True reads as “Logs are serialized.” — which sounds more like a status/property, not a setting or option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve readability of "received run arguments" in compute worker logs

4 participants