Skip to content

Phase creation from ui with starting_kit/public_data bug fixed #1915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
+11 −0
Open

Phase creation from ui with starting_kit/public_data bug fixed #1915

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions src/apps/api/views/competitions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,9 +227,20 @@ def create(self, request, *args, **kwargs):
leaderboard.is_valid()
leaderboard.save()
leaderboard_id = leaderboard["id"].value

# Set leaderboard id, starting kit and public data for phases
for phase in data['phases']:
phase['leaderboard'] = leaderboard_id

try:
phase['public_data'] = Data.objects.filter(key=phase['public_data']['value'])[0].id
except TypeError:
phase['public_data'] = None
try:
phase['starting_kit'] = Data.objects.filter(key=phase['starting_kit']['value'])[0].id
except TypeError:
phase['starting_kit'] = None

serializer = self.get_serializer(data=request.data)
serializer.is_valid(raise_exception=True)
self.perform_create(serializer)
Expand Down