sstable: include smallest separated value size in properties #5047
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Record a new sstable property containing the size of the smallest value separated. This can be used to schedule the rewrite of sstables that contain separated values that are smaller than what is permitted by the current policy. See cockroachdb#5043. Value separation doesn't lend itself well to a generalized approach to cockroachdb#5043 because when a sstable preserves blob references, the input sstables may have been written according to a variety of different policies.
|
This change is |
annrpom
approved these changes
Jul 9, 2025
There was a problem hiding this comment.
Reviewed 16 of 18 files at r1, all commit messages.
Reviewable status: 16 of 18 files reviewed, all discussions resolved
RaduBerinde
approved these changes
Jul 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Record a new sstable property containing the size of the smallest value separated. This can be used to schedule the rewrite of sstables that contain separated values that are smaller than what is permitted by the current policy. See #5043.
Value separation doesn't lend itself well to a generalized approach to #5043 because when a sstable preserves blob references, the input sstables may have been written according to a variety of different policies.