db: support store-relative paths for WAL dirs #4755
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
RaduBerinde
force-pushed
the
wal-relative-store-paths
branch
5 times, most recently
from
1acfb4b to
edb208b
Compare
Relative WAL paths (including the actual WAL, the failover path, and
the recovery paths) are (unfortunately) interpreted as relative to the
current working directory.
The cross-version metamorphic test copies a store from a previous run
as the initial state for a new test. The options will fail the
compatibility check since the path changes.
This change adds support for using a special `{store_path}` prefix
inside the path. Any such prefix is replaced with the store directory.
We also improve the missing WAL recovery dir error to show what
directories are actually configured.
RaduBerinde
force-pushed
the
wal-relative-store-paths
branch
from
edb208b to
da841ab
Compare
|
Added a commit that updates and fixes the code that sets up the WAL recovery dirs. |
jbowens
approved these changes
May 22, 2025
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1, 2 of 2 files at r2, 3 of 3 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @sumeerbhola)
|
TFTR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
db: support store-relative paths for WAL dirs
Relative WAL paths (including the actual WAL, the failover path, and
the recovery paths) are (unfortunately) interpreted as relative to the
current working directory.
The cross-version metamorphic test copies a store from a previous run
as the initial state for a new test. The options will fail the
compatibility check since the path changes.
This change adds support for using a special
{store_path}prefix tothe path. Any such prefix is replaced with the store directory.
We also improve the missing WAL recovery dir error to show what
directories are actually configured.
metamorphic: use store-relative paths
metamorphic: fix code around WAL recovery directories
Informs: #4732