codegen: update RecvMsg for gRPC compatibility
#3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's already here in the implementation of the StreamServer implementations but not available through interface, so essentially it's hidden. In this change we update its parameters to become compatible with gRPC and added that definition in the interface.
|
Some more context here: |
This was referenced May 13, 2025
shubhamdhama
added a commit
to shubhamdhama/cockroach
that referenced
this pull request
Jun 3, 2025
This will pickup the following changes: 1. cockroachdb/drpc#3 2. cockroachdb/drpc#2 3. cockroachdb/drpc#4 4. cockroachdb/drpc#6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's already here in the implementation of the StreamServer implementations but not available through interface, so essentially it's hidden. In this change we update its parameters to become compatible with gRPC and added that definition in the interface.