-
Notifications
You must be signed in to change notification settings - Fork 479
DOC-17060: Remove cockroach source links from release/download pages #23305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -41,7 +41,7 @@ Experimental downloads are not qualified for production use and not eligible for | |
| <a href="https://binaries.cockroachdb.com/cockroach-{{ release.release_name }}.darwin-11.0-arm64.tgz"><button id="mac-arm" class="filter-button" data-scope="mac-arm" data-eventcategory="mac-binary-release-notes">Mac ARM<br />(Experimental)</button></a> | ||
|
|
||
| <a {{ onclick_string }} href="https://binaries.cockroachdb.com/cockroach-{{ release.release_name }}.windows-6.2-amd64.zip"><button id="windows" class="filter-button" data-scope="windows" data-eventcategory="windows-binary-release-notes">Windows<br />(Experimental)</b></button></a> | ||
| <a target="_blank" rel="noopener" href="https://github.com/cockroachdb/cockroach/releases/tag/{{ release.release_name }}"><button id="source" class="filter-button" data-scope="source" data-eventcategory="source-release-notes">Source</button></a | ||
| <button id="source" class="filter-button" data-scope="source" data-eventcategory="source-release-notes">Source</button> | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. removing the link target is not sufficient please remove the entire 'Source' tab from this page |
||
| </div></div> | ||
|
|
||
| {% if release.has_sql_only == true %} | ||
|
|
@@ -63,7 +63,7 @@ Experimental downloads are not qualified for production use and not eligible for | |
| {% endif %} | ||
|
|
||
| <a onclick="{{ experimental_download_js }}" href="https://binaries.cockroachdb.com/cockroach-sql-{{ release.release_name }}.windows-6.2-amd64.zip"><button id="windows" class="filter-button" data-scope="windows" data-eventcategory="windows-binary-release-notes">Windows<br />(Experimental)</button></a> | ||
| <a target="_blank" rel="noopener" href="https://github.com/cockroachdb/cockroach/releases/tag/{{ release.release_name }}"><button id="source" class="filter-button" data-scope="source" data-eventcategory="source-release-notes">Source</button></a | ||
| <button id="source" class="filter-button" data-scope="source" data-eventcategory="source-release-notes">Source</button> | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same as elsewhere - changing the link is not sufficient, the entire 'Source' section here needs to be removed please |
||
| </div></div> | ||
|
|
||
| {% endif %} | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -516,7 +516,7 @@ CockroachDB {{ v.major_version }} is partially supported. Pre-LTS patches (befor | |
| </section> | ||
|
|
||
| <section class="filter-content" markdown="1" data-scope="source"> | ||
| <p>The source code for CockroachDB is hosted in the <a href="https://github.com/cockroachdb/cockroach/releases/" class="binary-link">cockroachdb/cockroach</a> repository on Github.</p> | ||
| <p>The source code for CockroachDB is hosted in the cockroachdb/cockroach repository on Github.</p> | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. the tactical link removal here is not sufficient. please remove the entire 'Source' tab from the page. See screenshot below from the live page - the entire 'Source' tab needs to be removed for every version (i think it's all generated from the Liquid logic in this section)
|
||
| <table class="release-table"> | ||
| <thead> | ||
| <tr> | ||
|
|
@@ -558,7 +558,7 @@ CockroachDB {{ v.major_version }} is partially supported. Pre-LTS patches (befor | |
| {% else %} {% comment %} Add download links for all non-withdrawn versions. {% endcomment %} | ||
| <td> | ||
| {% if r.source == true %} | ||
| <a class="external" href="https://github.com/cockroachdb/cockroach/releases/tag/{{ r.release_name }}" class="binary-link">View on Github</a> | ||
| View on Github | ||
| {% else %} | ||
| N/A | ||
| {% endif %} | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -93,7 +93,7 @@ All CockroachDB binaries released on or after the day 24.3.0 is released onward, | |
|
|
||
| All CockroachDB binaries released prior to the release date of 24.3.0 are variously licensed under the Business Source License 1.1 (BSL), the CockroachDB Community License (CCL), and other licenses specified in the source code. | ||
|
|
||
| To review the CCL, refer to the [CockroachDB Community License](https://www.cockroachlabs.com/cockroachdb-community-license) page. You can find the applicable Business Source License or third party licenses by reviewing these in the `licenses` folder for the applicable version of CockroachDB in the GitHub repository [cockroachdb/cockroach](https://github.com/cockroachdb/cockroach). See individual files for details. | ||
| To review the CCL, refer to the [CockroachDB Community License](https://www.cockroachlabs.com/cockroachdb-community-license) page. You can find the applicable Business Source License or third party licenses by reviewing these in the `licenses` folder for the applicable version of CockroachDB in the GitHub repository cockroachdb/cockroach. See individual files for details. | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. a tactical link removal is not sufficient please keep the first sentence but remove everything after it, specifically:
|
||
|
|
||
| In late 2024, Cockroach Labs retired its Core offering to consolidate on a single CockroachDB Enterprise offering under the CockroachDB Software License. This license is available at no charge for individual users and small businesses, and offers all users, free and paid, the full breadth of CockroachDB capabilities. For details, refer to the [CockroachDB licensing update](https://www.cockroachlabs.com/enterprise-license-update/) and [Licensing FAQs]({% link {{site.versions["stable"]}}/licensing-faqs.md %}). | ||
|
|
||
|
|
||

There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this whole source tag section should be removed