Clarify that MOLT Fetch does not migrate sequences #20644
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.
|
✅ Deploy Preview for cockroachdb-api-docs canceled.
|
Files changed:
|
✅ Netlify Preview
To edit notification comments on pull requests, go to your Netlify project configuration. |
tuansydau
approved these changes
Oct 17, 2025
There was a problem hiding this comment.
Looking good! Only one nit, it may be helpful to add something like the below snippet (up to your discretion).
This adds two things: some clarity for users on when/how exactly to create the sequential key manually, and also some specificity by saying after load and replication - since MOLT fetch can run solely data load, replication, or both.
"After loading and replicating data, but before cutover, make sure to update each sequence's current value using setval() so that new inserts continue from the correct point."
Otherwise, exactly what we needed - thanks!
taroface
reviewed
Oct 21, 2025
src/current/_includes/molt/migration-schema-design-practices.md
Outdated
Show resolved
Hide resolved
src/current/_includes/molt/migration-schema-design-practices.md
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://cockroachlabs.atlassian.net/browse/DOC-15004
I clarified this in two places:
The first is a bit of relatively low-key guidance here:
/docs/molt/molt-fetch#best-practices
The second is a loud alert here:
/docs/molt/migration-strategy#schema-design-best-practices
(Note that this alert is in an include file so probably shows up in multiple places.)