MOLT Oracle documentation; refactor MOLT tutorials #19918
+2,262
−774
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.
|
✅ Deploy Preview for cockroachdb-api-docs canceled.
|
Files changed:
|
❌ Deploy Preview for cockroachdb-docs failed. Why did it fail? →
|
✅ Netlify Preview
To edit notification comments on pull requests, go to your Netlify project configuration. |
taroface
requested review from
Jeremyyang920,
ryanluu12345,
noelcrl and
rohan-joshi
I saw this on the preview, but seems like a markdown reference isint resolved properly.
|
There was a problem hiding this comment.
Reviewed the rest just now. Looks good, just nits and clarifications. Agreed with Jeremy's comments. Can review after those are all addressed. I also want to ensure rest of the team can take a look here. @taroface it would be helpful if you could also link the exact docs preview section link so folks can see how it presents on the website
|
Addressed all comments. PTAL! The docs preview links are in the PR description. |
Jeremyyang920
approved these changes
Jul 14, 2025
florence-crl
requested changes
Jul 15, 2025
There was a problem hiding this comment.
Suggestions for Bulk Load. I will give my suggestions per page.
florence-crl
requested changes
Jul 16, 2025
noelcrl
reviewed
Jul 16, 2025
florence-crl
requested changes
Jul 16, 2025
florence-crl
requested changes
Jul 16, 2025
noelcrl
reviewed
Jul 16, 2025
florence-crl
requested changes
Jul 16, 2025
There was a problem hiding this comment.
Reviewed MOLT Fetch and Migration Overview (new Migration Flows section).
some nits. Great job @taroface, very comprehensive!
Co-authored-by: Florence Morris <[email protected]>
|
@noelcrl @florence-crl TFTRs!!! I think I addressed all comments. Could you please have another look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DOC-14130
DOC-14259
DOC-13941
DOC-13035
Please review:
The above pages use content from the
_includesfolder. Please review those documents as well.Note that the PG and MySQL flows were updated as well. This is technically outside the scope of this PR, but I'd like to request a review of the SQL user creation steps for each dialect and for CRDB, as this hasn't previously been documented and I was making an educated guess in some places.