kvstorage: remove ClearRangeThresholdPointKeys #155767
Draft
+78
−127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
The heuristic in ClearRangeData was introduced in b320ff5 when CRDB used RocksDB. The optimization is no longer needed with Pebble, because Pebble does not load all range tombstones when reading SSTables. The tombstones are loaded and cached as needed, when iterating. Additional benefits of this change: fewer corner cases in replica destruction code, and predictable replica destruction batches (which is convenient in tests). Epic: none Release note: none
pav-kv
force-pushed
the
no-heuristic-in-range-destroy
branch
from
d21d0ac to
e0f093f
Compare
pav-kv
commented
Oct 21, 2025
| UserKeys: true, | ||
| }, | ||
| ReplicatedByRangeID: opts.clearReplicatedByRangeID, | ||
| UnreplicatedByRangeID: opts.clearUnreplicatedByRangeID, |
There was a problem hiding this comment.
TODO: in the unreplicated keyspace, we don't need to clear "range keys" since they don't exist.
TODO: check if the same applies to the replicated RangeID-local space.
TODO: we can also not clear the replicated space for uninitialized replicas, since it is empty.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The heuristic in
ClearRangeDatawas introduced in b320ff5 when CRDB used RocksDB. The optimization is no longer needed with Pebble, because Pebble does not load all range tombstones when reading SSTables. The tombstones are loaded and cached as needed, when iterating.Upd [thread]: however, the RANGEDEL block is unsplittable, and can be loaded into memory entirely, so many range tombstones is still a concern.
Additional benefits of this change:
WriterRelated to #152845