storage: add storage.tombstone_dense_compaction_threshold setting #155739
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
RaduBerinde
force-pushed
the
tombstone-compaction-threshold-setting
branch
from
d3f91e3 to
75b1261
Compare
Add a cluster setting to control the tombstone-dense compaction threshold. Fixes: cockroachdb#155715 Release note: None
RaduBerinde
force-pushed
the
tombstone-compaction-threshold-setting
branch
from
75b1261 to
5e4f9c2
Compare
jbowens
approved these changes
Oct 22, 2025
There was a problem hiding this comment.
@jbowens reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @RaduBerinde)
|
TFTR! bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Oct 22, 2025
154939: stress: rename Stress to DevStress r=herkolategan,jeffswenson a=stevendanna This renames the current implementation of Stress to DevStress and then adds a new Stress function that covers both local and nightly stress runs. Epic: none Release note: None 155739: storage: add storage.tombstone_dense_compaction_threshold setting r=RaduBerinde a=RaduBerinde Add a cluster setting to control the tombstone-dense compaction threshold. Fixes: #155715 Release note: None 155795: workload/schemachange: remove FK violation prediction for INSERT operations r=rafiss a=rafiss Previously, the random schema workload attempted to predict whether INSERT operations would violate foreign key constraints by analyzing the database state and constraint definitions. This prediction logic involved: - Querying the database to check if FK violations would occur - Checking for ongoing FK constraint mutations - Distinguishing between expected and potential FK violations This commit removes all FK violation prediction logic and makes ForeignKeyViolation unconditionally a potential execution and commit error for INSERT operations. This aligns with the existing pattern used for adding FK constraints, where FK violations are always treated as potential errors due to the asynchronous validation job. This change simplifies the code by removing ~200 lines of complex prediction logic and deflakes tests that depend on accurate error handling during concurrent schema changes. Resolves: #155686 Resolves: #154715 Resolves: #152402 Epic: None Release note: None 🤖 Generated with [Claude Code](https://claude.com/claude-code) 155798: kvnemesis: log a metrics report r=stevendanna a=miraradeva This commit adds logging of some key metrics at the end of each kvnemesis run. Fixes: #153793 Release note: None ---- This is what the report looks like for a run of `TestKVNemesisMultiNode`: ``` Metric | Node 1 | Node 2 | Node 3 | Node 4 ------------------------------------+----------------------+----------------------+----------------------+--------------------- raft.commands.proposed | 2906 | 117 | 273 | 118 raft.commands.reproposed.new-lai | 0 | 1 | 12 | 0 raft.commands.reproposed.unchanged | 78 | 0 | 0 | 0 txn.server_side.1PC.success | 84 | 0 | 1 | 0 txnrecovery.successes.committed | 0 | 0 | 0 | 0 txnwaitqueue.deadlocks_total | 0 | 0 | 4 | 0 txn.aborts | 13 | 10 | 8 | 12 txn.durations | μ=25ms p99=260ms | μ=82ms p99=671ms | μ=81ms p99=1.476s | μ=224ms p99=4.832s txn.restarts.writetooold | 8 | 1 | 2 | 1 txn.restarts.serializable | 1 | 0 | 0 | 0 txn.restarts.readwithinuncertainty | 0 | 0 | 0 | 0 ``` Co-authored-by: Steven Danna <[email protected]> Co-authored-by: Radu Berinde <[email protected]> Co-authored-by: Rafi Shamim <[email protected]> Co-authored-by: Mira Radeva <[email protected]>
|
Build failed (retrying...): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a cluster setting to control the tombstone-dense compaction
threshold.
Fixes: #155715
Release note: None