release-25.4: sql: use INSPECT parameters to disambiguate index names #155722
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the indexes named in the `INSPECT` command's options were resolved without using the database or table name as context. This change uses the name of the table and/or database to fill out the index name. Epic: CRDB-30356 Informs: cockroachdb#155056 Release note (sql change): The `INSPECT` command now uses the table or database parameter as context for resolving indexes specified in the options.
bghal
force-pushed
the
blathers/backport-release-25.4-155475
branch
from
93aee7e to
b8f6f3b
Compare
blathers-crl
bot
added
blathers-backport
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=95b789b1d594ac6b74f377aa7555d8d98d63240d&v=4){kind=avatar}
|
Thanks for opening a backport. Before merging, please confirm that the change does not break backwards compatibility and otherwise complies with the backport policy. Include a brief release justification in the PR description explaining why the backport is appropriate. All backports must be reviewed by the TL for the owning area. While the stricter LTS policy does not yet apply, please exercise judgment and consider gating non-critical changes behind a disabled-by-default feature flag when appropriate. |
blathers-crl
bot
added
backport
|
This change is |
|
Closing backport as a UX improvement |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #155475 on behalf of @bghal.
Previously, the indexes named in the
INSPECTcommand's options wereresolved without using the database or table name as context. This
change uses the name of the table and/or database to fill out the index
name.
Some cleanup work from #148365 to move off of
SCRUBis also included.Epic: CRDB-30356
Informs: #77376
Release note (sql change): The
INSPECTcommand now uses the table ordatabase parameter as context for resolving indexes named in the
options.
Release justification: