Skip to content

release-24.3: changefeedccl: fix TestNoBackfillAfterNonTargetColumnDrop #150287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 16, 2025

Conversation

andyyang890
Copy link
Collaborator

Backport 2/2 commits from #150215.

/cc @cockroachdb/release


This patch fixes TestNoBackfillAfterNonTargetColumnDrop so that it
actually checks that no backfills occur after a non-target column drop.

Fixes #150214

Release note: None


Release justification: test-only fix

This patch replaces an incorrect usage of `require.Regexp` in
`TestNoStopAfterNonTargetColumnDrop`.

Release note: None
This patch fixes `TestNoBackfillAfterNonTargetColumnDrop` so that it
actually checks that no backfills occur after a non-target column drop.

Release note: None
@andyyang890 andyyang890 requested review from asg0451 and aerfrei July 15, 2025 21:51
@andyyang890 andyyang890 requested a review from a team as a code owner July 15, 2025 21:51
Copy link

blathers-crl bot commented Jul 15, 2025

Thanks for opening a backport.

Before merging, please confirm that it falls into one of the following categories (select one):

  • Non-production code changes. Includes test-only changes, build system changes, etc.
  • Fixes for serious issues. Defined in the policy as correctness, stability, or security issues, data corruption/loss, significant performance regressions, breaking working and widely used functionality, or an inability to detect and debug production issues.
  • Other approved changes. These changes must be gated behind a disabled-by-default feature flag unless there is a strong justification not to.

Add a brief release justification to the PR description explaining your selection.

Also, confirm that the change does not break backward compatibility and complies with all aspects of the backport policy.

All backports must be reviewed by the TL and EM for the owning area.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Jul 15, 2025
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link

blathers-crl bot commented Jul 15, 2025

✅ PR #150287 is compliant with backport policy

Confidence: high
Backward compatible: true
Explanation: The PR is compliant with the CockroachDB backport policy due to its nature as a test-only fix. The changes are limited to a file named changefeed_test.go, which matches the non-production file pattern *_test.go. According to the backport policy, changes that affect only non-production code, specifically test files, are exempt from the standard critical bug and feature flag requirements. Additionally, the PR body includes a 'Release justification: test-only fix' line, explicitly noting that its purpose is for addressing a test-specific issue rather than altering production behavior.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@blathers-crl blathers-crl bot added the backport-test-only Used to denote the backport has only non-production changes label Jul 15, 2025
@andyyang890 andyyang890 merged commit 0ca2330 into cockroachdb:release-24.3 Jul 16, 2025
16 checks passed
@andyyang890 andyyang890 deleted the backport24.3-150215 branch July 16, 2025 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches backport-test-only Used to denote the backport has only non-production changes target-release-24.3.17
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants