Skip to content

release-25.2: ui: fix live data percentage on table overview #147465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: release-25.2
Choose a base branch
from
Open

release-25.2: ui: fix live data percentage on table overview #147465

wants to merge 1 commit into from

Conversation

kyle-a-wong
Copy link
Contributor

Backport 1/1 commits from #147425 on behalf of @kyle-a-wong.

Fixes a bug where the live data percentage on the table details overview page was using the wrong values, resulting in it always showing 100%.

fixes: #136476
Epic: None
Release note: None

Release justification:

@kyle-a-wong
ui: fix live data percentage on table overview
33d5417 
Fixes a bug where the live data percentage on the
table details overview page was using the wrong
values, resulting in it always showing 100%.

fixes: cockroachdb#136476
Epic: None
Release note: None
@kyle-a-wong kyle-a-wong requested a review from a team as a code owner May 28, 2025 21:27
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels May 28, 2025
@kyle-a-wong kyle-a-wong requested review from alyshanjahani-crl and removed request for a team May 28, 2025 21:27
@blathers-crl blathers-crl bot requested a review from angles-n-daemons May 28, 2025 21:27
@blathers-crl blathers[crl]
Copy link

blathers-crl bot commented May 28, 2025

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues     or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL. For more information as to how that review should be conducted, please consult the backport
    policy    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label May 28, 2025
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alyshanjahani-crl alyshanjahani-crl Awaiting requested review from alyshanjahani-crl alyshanjahani-crl is a code owner automatically assigned from cockroachdb/obs-prs

@angles-n-daemons angles-n-daemons Awaiting requested review from angles-n-daemons

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kyle-a-wong @cockroach-teamcity