sql: SHOW CREATE ALL ROUTINES #147452
Open
sql: SHOW CREATE ALL ROUTINES #147452
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ate_all_routines statement
…rator functionality to query crdb_internal tables for function and procedure create statements
refactor to use IDs to prevent buffer memory overcapacity Works towards cockroachdb#144708 Release note (sql change): The SHOW CREATE ALL ROUTINES statement
Release note: None Previously, there were no tests. Now, there are more tests than there were before. This needed to change because tests are good. To address the lack of tests, I made tests.
Release note: none Added the show_create_all_routine test to show_routines test data to prevent clutter. Epic: none
Previously, it was failing due to whitespace issues. I added some whitespace and now it works with --rewrite enabled. Release note: None Epic: none
|
This change is |
There was a problem hiding this comment.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @OriSavir)
docs/generated/sql/bnf/frobnicate_stmt.bnf line 1 at r1 (raw file):
frobnicate_stmt ::=
It seems the frobnicate code was forgotten to be removed here.
Removed the files related to frobnicate, which were left over from doing the codelab as generated files. Release note: None Epic: none
Thanks for pointing that out! Removed the file related, I think it was from running |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #144708
Adds SHOW CREATE ALL ROUTINES, which returns a table with all available routines' create statements.