fix: do not alter user comments #382
Conversation
We used to have a regex that removed the first and last single quotes from a comment. There is no information about this decision, nor any related test. This might have been a difference between PostgreSQL and CockroachDB. Since tests are passing without it, and comments are not quoted, we can remove the regex. Moreover, if a comment would start or end with a single quote, this would remove that quote, which is not desirable. Fixes #381
| fields.reduce({}) do |a, e| | ||
| a[e[0]] = e | ||
| a | ||
| fields.to_h do |field| |
There was a problem hiding this comment.
A nitpick, but reading this was hurting everytime 😅
|
@rafiss the bug was introduced in #235 which was made in november 2021. It seems like at the time we were using docker with the image TBH I think we can just go for it once tests will pass. |
|
The failing test is the flacky one we've been having for some time now. I'll be on that next thing. In the mean time I think this is not blocking for this PR. |
Thanks for tracking down the original change! Thanks to those clues, I was able to confirm what you suggested. cockroachdb/cockroach@5660a74 is the original CRDB change that adds column comments, and indeed, they always were shown in |
We used to have a regex that removed the first and last single quotes from a comment. There is no information about this decision, nor any related test. This might have been a difference between PostgreSQL and CockroachDB.
Since tests are passing without it, and comments are not quoted, we can remove the regex. Moreover, if a comment would start or end with a single quote, this would remove that quote, which is not desirable.
Fixes #381