fix: use internal_execute instead of execute_and_clear

[Maimer]

When updating rails to 8.0.2 (or 8.0.0 or 8.0.1) and udpating activerecord-cockroachdb-adapter to the corresponding version of either 8.0.0 or 8.0.1 in my application it failed to be able to create a database from scratch.

Running the command:

bundle exec db:drop db:create db:migrate

Results in the following error:

NoMethodError: undefined method 'execute_and_clear' for an instance of ActiveRecord::ConnectionAdapters::CockroachDBAdapter (NoMethodError)

            result = execute_and_clear(query, "SCHEMA", [], allow_retry: true, materialize_transactions: false)
                     ^^^^^^^^^^^^^^^^^

When looking at the activerecord/lib/active_record/connection_adapters/postgresql_adapter.rb I see that it had been removed in the following commit: rails/rails@fd24e5b and replaced with usage of the internal_execute command instead, which is part of a larger PR: rails/rails#52428 that is looking to standardize the interface of the various database adapters.

[rafiss]

Thanks for submitting this! Could you add more information in the PR description that describes what functionality was broken? i.e., provide an example code snippet that was having issues or provide the error that you encountered before making this patch? This will help us with documenting the bugfix in release notes.

[Maimer]

Thanks for submitting this! Could you add more information in the PR description that describes what functionality was broken? i.e., provide an example code snippet that was having issues or provide the error that you encountered before making this patch? This will help us with documenting the bugfix in release notes.

I have updated the PR description, let me know if you need more details.

[Maimer]

@rafiss I think the tests failed due to some flakiness. Any chance you can rerun it and let me know if there is anything else that needs to be done here?

[BuonOmo]

I've rerun the tests. But by looking at them, the fairness_by_group test has already failed in other branches so I would merge this PR confidentely. Could you add a one-liner for the CHANGELOG.md? Besides that, LGTM

[rafiss]

Thanks for your contribution! We should make an 8.0.2 release for this adapter.

[Maimer]

I've rerun the tests. But by looking at them, the fairness_by_group test has already failed in other branches so I would merge this PR confidentely. Could you add a one-liner for the CHANGELOG.md? Besides that, LGTM

Looks like it got merged before I could update the CHANGELOG.md on this PR. Do you want me to make a PR for that or do you want to handle that with the release? @rafiss @BuonOmo

[BuonOmo]

We'll fix that later no big deal, thank you @Maimer!

[Maimer]

We'll fix that later no big deal, thank you @Maimer!

Are you or @rafiss able to handle the release? This is blocking for me currently, so it would great if we could get that new version released. 🙏

[BuonOmo]

I do not have sufficient permissions. In the meantime you could refer to the commit in your gemfile (gem "activerecord-cockroachdb-adapter", git: "[email protected]:cockroachdb/activerecord-cockroachdb-adapter", ref: "f01c835")

[Maimer]

I do not have sufficient permissions. In the meantime you could refer to the commit in your gemfile (gem "activerecord-cockroachdb-adapter", git: "[email protected]:cockroachdb/activerecord-cockroachdb-adapter", ref: "f01c835")

Thanks, I'll have to wait for @rafiss to publish. Using a git referenced gem doesn't allow me to verify the checksum of the gem itself, so while it's useful for testing / development, it's not the best practice for production.

[dikshant]

@rafiss could you help cut out a release?

[rafiss]

v8.0.2 has been published: https://rubygems.org/gems/activerecord-cockroachdb-adapter/versions/8.0.2