feat: add support for CRDB v25.1 #372
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for CockroachDB v25.1 by updating configuration and CI testing.
- Updated test/config.yml to include new connection options for CRDB v25.1 using YAML anchors and merge keys.
- Expanded the CI testing matrix in .github/workflows/ci.yml to include v25.1 and added a step to display the Rails version.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/config.yml | Added options for CRDB v25.1 and refactored connection settings using YAML anchors. |
| .github/workflows/ci.yml | Updated the matrix to include CRDB v25.1 and introduced a new step to show the Rails version. |
Comments suppressed due to low confidence (1)
.github/workflows/ci.yml:56
- [nitpick] Consider renaming the step to 'Display Rails Version' for consistency with common naming conventions.
- name: Show Rails version
|
Note that this also tests rails 8.0.2, which we seem to support well :) |
rafiss
approved these changes
Apr 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.