Support for string and numbers in isValidNumber function

README.md

@@ -79,7 +79,7 @@ console.log(isValidEmail('[email protected]')); // true
 
 ### `isValidNumber(value, allowZero, allowNegative)`
 
-- Validates if a value of type string is a valid number
+- Validates if a value of type string or number is a valid number
 - If allowZero equals true, '0' would return true
 - If allowNegative equals true, negative values would return true
 
@@ -92,11 +92,13 @@ console.log(isValidNumber('123a424', true, true)); // false
 console.log(isValidNumber('123a424', false, true)); // false
 console.log(isValidNumber('1.23a424', false, true)); // false
 console.log(isValidNumber('123-424', false, true)); // false
-console.log(isValidNumber('0')); // false  
+console.log(isValidNumber('0')); // false
 console.log(isValidNumber('0', true)); // true
 console.log(isValidNumber('-1', true, true)); // true
 console.log(isValidNumber('201')); // true
 console.log(isValidNumber('3.14159')); // true
+console.log(isValidNumber(452)); // true
+console.log(isValidNumber(3.1459)); // true
 ```
 
 

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@cobuildlab/validation-utils",
-  "version": "0.0.3",
+  "version": "0.0.4",
   "description": "This is package to deal with common scenarios working with Javascript validations",
   "main": "lib/index.js",
   "types": "./lib/index.d.ts",

src/__tests__/test.ts

@@ -4,7 +4,8 @@ import {
   isValidEmail,
   isValidNumber,
   isValidInteger,
-  isValidDate
+  isValidDate,
+  isStringAValidNumber
 } from '../index';
 
 test('isNullOrUndefined:', () => {
@@ -79,4 +80,14 @@ test('isValidDate', () => {
   expect(isValidDate('2020-06-26', 'YYYY-MM-DD')).toBe(true);
   expect(isValidDate('Mar 25 2015', 'MMM DD YYYY')).toBe(true);
   expect(isValidDate('Tue Mar 24 2015 19:30:00', 'ddd MMM DD YYY HH:mm:ss')).toBe(true);
+})
+
+test('isStringAValidNumber', () => {
+  expect(isStringAValidNumber('')).toBe(false);
+  expect(isStringAValidNumber('Some string')).toBe(false);
+  expect(isStringAValidNumber('04939-343.643')).toBe(false);
+
+  expect(isStringAValidNumber('2020')).toBe(true);
+  expect(isStringAValidNumber('5731')).toBe(true);
+  expect(isStringAValidNumber('3.1415')).toBe(true);
 })

src/index.ts

@@ -57,19 +57,19 @@ export const isValidEmail = (email: string): boolean => {
 /**
  * Validate if a string is a valid number.
  *
- * @param {string} stringToTest - The string to validate as a number.
+ * @param {string} value - The string to validate as a number.
  * @param {boolean} [allowZero=false] - If the string should accept 0 as a valid number.
  * @param {boolean} [allowNegative=false] - If the string should negative values.
  * 
  * @returns {boolean} If the string is valid number or not.
  */
-export const isValidNumber = (stringToTest: string, allowZero: boolean = false, allowNegative: boolean = false): boolean => {
+export const isValidNumber = (value: string, allowZero: boolean = false, allowNegative: boolean = false): boolean => {
   const regExp = /^(-?[0-9]+)((\.|,)[0-9]+)?$/;
 
-  if (!regExp.test(stringToTest))
+  if (!regExp.test(value))
     return false;
 
-  const numberToTest = parseInt(stringToTest, 10);
+  const numberToTest = parseInt(value, 10);
 
   if (isNaN(numberToTest) || typeof numberToTest !== 'number') return false;
 
@@ -112,4 +112,20 @@ export const isValidDate = (date: string, format?: string): boolean => {
     return moment(date).isValid();
 
   return moment(date, format, true).isValid();
-};
+};
+
+/**
+ * Validate if the provided string is a valid number
+ * 
+ * @param {string} value - The value to check
+ * 
+ * @returns {boolean} Returns if the specified value is a valid number or not
+ */
+export const isStringAValidNumber = (value: string) => {
+  if (value === '')
+    return false;
+
+  const number = Number(value);
+
+  return Number.isNaN(number) ? false : true;
+}