Skip to content

Escape most of special symbols on Android, double quotes on iOS #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Escape most of special symbols on Android, double quotes on iOS #8

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
92d6f3a
Escape most of special symbols on Android, double quotes on iOS
bivant Sep 23, 2019
0a90e3e
Prevent error on symbols escape attempt if value/translation is number
bivant Sep 24, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion Code.gs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,14 +192,23 @@ function makeAndroidString(object, textIndex, options) {
exportString += "\t" + '</string-array>' + "\n";
prevIdentifier = "";
}

if(typeof text === 'string') {
text = text.replace(/\n/g, "\\n");
text = text.replace(/&/g, "&amp;");
text = text.replace(/\'/g, "\\'");
text = text.replace(/</g, "&lt;");
text = text.replace(/>/g, "&gt;");
text = text.replace(/"/g, "\\\"");
}

if(identifier.indexOf("[]")>0) {

if(identifier != prevIdentifier) {
exportString += "\t" + '<string-array name="' + identifier.substr(0,identifier.length-2) + '">' + "\n";
}

exportString += "\t\t"+'<item>'+o.text+'</item>' + "\n";
exportString += "\t\t"+'<item>'+text+'</item>' + "\n";
prevIdentifier = identifier;

} else {
Expand Down Expand Up @@ -261,6 +270,10 @@ function makeIosString(object, textIndex, options) {
continue;
}

if(typeof text === 'string') {
text = text.replace(/"/g, "\\\"");
}

exportString += '"' + identifier + '" = "' + text + "\";\n";
}

Expand Down