Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git_task_list.md: Add Git Task List project #579

Merged
merged 1 commit into from
May 23, 2018

Conversation

bekicot
Copy link
Contributor

@bekicot bekicot commented May 19, 2018

Related to:
#480
coala/coala#4080

For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!

Checklist

  • I read the commit guidelines and I've followed
    them.
  • I ran coala over my code locally. (All commits have to pass
    individually.
    It is not sufficient to have "fixup commits" on your PR,
    our bot will still report the issues for the previous commit.) You will
    likely receive a lot of bot comments and build failures if coala does not
    pass on every single commit!

After you submit your pull request, DO NOT click the 'Update Branch' button.
When asked for a rebase, consult coala.io/rebase
instead.

Please consider helping us by reviewing other peoples pull requests as well:

The more you review, the more your score will grow at coala.io and we will
review your PRs faster!

#### Links

- [http://github.com/summerofcode/gsoc-prep-tasks][1]
- [http://summerofcode.github.io/gsoc-prep-tasks][2]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need external links here? wouldn't it be better if we get a coala repo for the same...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yashovardhanagrawal No need, just an easy navigation. It is just my preference. For me it is easy to keep track of external stuff this way as I do skip links if Iread a long text, some kind of read later shortcut.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See when this PR is merged, it would be up at projects.coala.io and there having a reference link to repos that are not part of coala would not be a nice idea
I think @jayvdb may be able to help us out here better

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do need to mention the project repo URL at the top of the rendered page, not useful here.

- https://github.com/coala/coala/issues/4080
markdown: git_task_list.md
mentors:
- jayvdb
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not on your list of mentors, and the first mentor listed here should be your primary mentor.

---

The basic idea is an extended version of [GSOC Task List][2] which was initialy
intended for GSOC Applicans who don't have to a little experience in
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spelling mistake

project.

This project will help sharing the tasks of reviewing a pull request on a
project. This is also maybe the solution of https://github.com/coala/coala/issues/4080,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue links belong in the project metadata, and should not be listed in the project spec.

The project spec should use sentences which explain the problems and solutions.

---
collaborating_projects:
- coala
- meta-review
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no. meta-review is being done by the other project. Your project proposal did not propose any solutions related to meta-review.

@@ -0,0 +1,87 @@
---
collaborating_projects:
- coala
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no. your project does not intend to enhance coala/coala.

here you would put gsoc-prep-tasks as the related project

#### Milestone

##### Phase 1
- Add gitlab support
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gitlab -> GitLab.

check & fix your capitalisation throughout the document.

you shouldnt need mentors to be pointing out silly things like this.


This project is also related to “New Comer Metrics And Gamification”. Where one
of the possible accomplishment is doing reviews.
The Goal of this projects is a serverless web page where the user can find Pull
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only pull requests?

what about issues?

what about commits merged?

See issues list in gsoc-prep-tasks

#### Links

- [http://github.com/summerofcode/gsoc-prep-tasks][1]
- [http://summerofcode.github.io/gsoc-prep-tasks][2]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do need to mention the project repo URL at the top of the rendered page, not useful here.


- [http://github.com/summerofcode/gsoc-prep-tasks][1]
- [http://summerofcode.github.io/gsoc-prep-tasks][2]
- [https://github.com/coala/projects/issues/480](https://github.com/coala/projects/issues/480)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these issue links should be in the metadata , not here.

@gitmate-bot
Copy link

Comment on c2c554e, file _projects/git_task_list.html.

This file had 1137 lines, which is 637 lines more than the maximum limit specified.

Origin: LineCountBear, Section: linecount.

@gitmate-bot
Copy link

Comment on c2c554e, file data/locale/en/projects/git_task_list.html.

This file had 1137 lines, which is 637 lines more than the maximum limit specified.

Origin: LineCountBear, Section: linecount.

@gitmate-bot
Copy link

Comment on c2c554e, file data/locale/en/projects/git_task_list.html, line 1137.

Line contains following spacing inconsistencies:

  • No newline at EOF.

Origin: SpaceConsistencyBear, Section: spacing.

The issue can be fixed by applying the following patch:

--- a/tmp/tmploc10vzf/data/locale/en/projects/git_task_list.html
+++ b/tmp/tmploc10vzf/data/locale/en/projects/git_task_list.html
@@ -1134,4 +1134,4 @@
 <li>Add Gerrit support</li>
 <li>Add Phabricator support</li>
 <li>Improve UI and UX.</li>
-</ul></article></body></html>+</ul></article></body></html>

<li>Add Gerrit support</li>
<li>Add Phabricator support</li>
<li>Improve UI and UX.</li>
</ul></article></body></html>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line contains following spacing inconsistencies:

  • No newline at EOF.

Origin: SpaceConsistencyBear, Section: spacing.

The issue can be fixed by applying the following patch:

--- a/tmp/tmploc10vzf/_projects/git_task_list.html
+++ b/tmp/tmploc10vzf/_projects/git_task_list.html
@@ -1134,4 +1134,4 @@
 <li>Add Gerrit support</li>
 <li>Add Phabricator support</li>
 <li>Improve UI and UX.</li>
-</ul></article></body></html>+</ul></article></body></html>

@TravisBuddy
Copy link

Travis tests have failed

Hey @bekicot,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

Ruby: 2.3.3

docker run -v=$(pwd):/app --workdir=/app coala/base coala --ci
Unable to find image 'coala/base:latest' locally
latest: Pulling from coala/base
















Digest: sha256:125d6cf24929d39db47b3ccd83d6ed1b6a231fc7e8afbf70bc4b5bd87653b0ff
Status: Downloaded newer image for coala/base:latest
Executing section global...
Executing section commit...
Executing section linecount...
[WARNING][10:36:19] LineCountBear: This result has no patch attached.

data/locale/en/projects/git_task_list.html
|    | [NORMAL] LineCountBear:
|    | This file had 1137 lines, which is 637 lines more than the maximum limit specified.
[WARNING][10:36:19] LineCountBear: This result has no patch attached.

_projects/git_task_list.html
|    | [NORMAL] LineCountBear:
|    | This file had 1137 lines, which is 637 lines more than the maximum limit specified.
Executing section filenames...
Executing section spacing...
|    | [NORMAL] SpaceConsistencyBear:
|    | Line contains following spacing inconsistencies:
|    | - No newline at EOF.
|----|    | /app/_projects/git_task_list.html
|    |++++| /app/_projects/git_task_list.html
|1134|1134| <li>Add Gerrit support</li>
|1135|1135| <li>Add Phabricator support</li>
|1136|1136| <li>Improve UI and UX.</li>
|1137|    |-</ul></article></body></html>
|    |1137|+</ul></article></body></html>
|    | [NORMAL] SpaceConsistencyBear:
|    | Line contains following spacing inconsistencies:
|    | - No newline at EOF.
|----|    | /app/data/locale/en/projects/git_task_list.html
|    |++++| /app/data/locale/en/projects/git_task_list.html
|1134|1134| <li>Add Gerrit support</li>
|1135|1135| <li>Add Phabricator support</li>
|1136|1136| <li>Improve UI and UX.</li>
|1137|    |-</ul></article></body></html>
|    |1137|+</ul></article></body></html>
[INFO][10:36:20] Applied 'ShowPatchAction' on '_projects/git_task_list.html' from 'SpaceConsistencyBear'.
[INFO][10:36:20] Applied 'ShowPatchAction' on 'data/locale/en/projects/git_task_list.html' from 'SpaceConsistencyBear'.
Executing section html...
[WARNING][10:36:20] HTMLLintBear: This result has no patch attached.
[WARNING][10:36:20] HTMLLintBear: This result has no patch attached.
[WARNING][10:36:20] HTMLLintBear: This result has no patch attached.
[WARNING][10:36:20] HTMLLintBear: This result has no patch attached.
[WARNING][10:36:20] HTMLLintBear: This result has no patch attached.
[WARNING][10:36:20] HTMLLintBear: This result has no patch attached.
[WARNING][10:36:20] HTMLLintBear: This result has no patch attached.
[WARNING][10:36:20] HTMLLintBear: This result has no patch attached.
[WARNING][10:36:20] HTMLLintBear: This result has no patch attached.
[WARNING][10:36:20] HTMLLintBear: This result has no patch attached.
[WARNING][10:36:20] HTMLLintBear: This result has no patch attached.
[WARNING][10:36:20] HTMLLintBear: This result has no patch attached.
[WARNING][10:36:20] HTMLLintBear: This result has no patch attached.
[WARNING][10:36:20] HTMLLintBear: This result has no patch attached.

_projects/git_task_list.html
|1058| </style><title>git_task_list</title></head><body><article·class="markdown-body"><ul>
|    | [MAJOR] HTMLLintBear:
|    | General Formatting: Use a new line for every block, list, or table element, and indent every such child element: Move the opening "article" to its own line.

_projects/git_task_list.html
|1058| </style><title>git_task_list</title></head><body><article·class="markdown-body"><ul>
|    | [MAJOR] HTMLLintBear:
|    | General Formatting: Use a new line for every block, list, or table element, and indent every such child element: Move the opening "ul" to its own line.

_projects/git_task_list.html
|1060| desc:·&ldquo;List·pull·request/merge·request·(in·GitLab)·that·have·no·reviewer·yet.·Provide·an·easy·way·for·new·comer·/·developer·to·do·contribution·to·a·project·by·giving·review·to·other·people·pull·requests.&rdquo;
|    | [MAJOR] HTMLLintBear:
|    | Entity References: Use the unicode equivalent instead: Change "&ldquo;" to "“".

_projects/git_task_list.html
|1060| desc:·&ldquo;List·pull·request/merge·request·(in·GitLab)·that·have·no·reviewer·yet.·Provide·an·easy·way·for·new·comer·/·developer·to·do·contribution·to·a·project·by·giving·review·to·other·people·pull·requests.&rdquo;
|    | [MAJOR] HTMLLintBear:
|    | Entity References: Use the unicode equivalent instead: Change "&rdquo;" to "”".

_projects/git_task_list.html
|1073| name:·&ldquo;Git·Task·List&rdquo;
|    | [MAJOR] HTMLLintBear:
|    | Entity References: Use the unicode equivalent instead: Change "&ldquo;" to "“".

_projects/git_task_list.html
|1073| name:·&ldquo;Git·Task·List&rdquo;
|    | [MAJOR] HTMLLintBear:
|    | Entity References: Use the unicode equivalent instead: Change "&rdquo;" to "”".

_projects/git_task_list.html
|1075| <li>&ldquo;The·applicant·should·have·at·least·one·patch·merged·to·any·of·the·coala·repositories.&rdquo;</li>
|    | [MAJOR] HTMLLintBear:
|    | Entity References: Use the unicode equivalent instead: Change "&ldquo;" to "“".

_projects/git_task_list.html
|1075| <li>&ldquo;The·applicant·should·have·at·least·one·patch·merged·to·any·of·the·coala·repositories.&rdquo;</li>
|    | [MAJOR] HTMLLintBear:
|    | Entity References: Use the unicode equivalent instead: Change "&rdquo;" to "”".

_projects/git_task_list.html
|1076| <li>&ldquo;Familiarity·with·Git,·GitHub·API·Gerrit·API,·Phabricator·API,·and·GitLab·API&rdquo;</li>
|    | [MAJOR] HTMLLintBear:
|    | Entity References: Use the unicode equivalent instead: Change "&ldquo;" to "“".

_projects/git_task_list.html
|1076| <li>&ldquo;Familiarity·with·Git,·GitHub·API·Gerrit·API,·Phabricator·API,·and·GitLab·API&rdquo;</li>
|    | [MAJOR] HTMLLintBear:
|    | Entity References: Use the unicode equivalent instead: Change "&rdquo;" to "”".

_projects/git_task_list.html
|1077| <li>&ldquo;Familiarity·with·EmberJS,·Javascript,·and·GitHub·Pages&rdquo;
|    | [MAJOR] HTMLLintBear:
|    | Entity References: Use the unicode equivalent instead: Change "&ldquo;" to "“".

_projects/git_task_list.html
|1077| <li>&ldquo;Familiarity·with·EmberJS,·Javascript,·and·GitHub·Pages&rdquo;
|    | [MAJOR] HTMLLintBear:
|    | Entity References: Use the unicode equivalent instead: Change "&rdquo;" to "”".

_projects/git_task_list.html
|1083| <hr·/>
|    | [MAJOR] HTMLLintBear:
|    | Document Type: Do not close void elements: Remove the trailing " /" from the hr tag.

_projects/git_task_list.html
|1085| which·was·initialy·intended·for·GSOC·Applicans·who·don&rsquo;t·have·or·only·have·a
|    | [MAJOR] HTMLLintBear:
e>git_task_list</title></head><body><article·class="markdown-body"><ul>
|    | [MAJOR] HTMLLintBear:
|    | General Formatting: Use a new line for every block, list, or table element, and indent every such child element: Move the opening "ul" to its own line.

data/locale/en/projects/git_task_list.html
|1060| desc:·&ldquo;List·pull·request/merge·request·(in·GitLab)·that·have·no·reviewer·yet.·Provide·an·easy·way·for·new·comer·/·developer·to·do·contribution·to·a·project·by·giving·review·to·other·people·pull·requests.&rdquo;
|    | [MAJOR] HTMLLintBear:
|    | Entity References: Use the unicode equivalent instead: Change "&ldquo;" to "“".

data/locale/en/projects/git_task_list.html
|1060| desc:·&ldquo;List·pull·request/merge·request·(in·GitLab)·that·have·no·reviewer·yet.·Provide·an·easy·way·for·new·comer·/·developer·to·do·contribution·to·a·project·by·giving·review·to·other·people·pull·requests.&rdquo;
|    | [MAJOR] HTMLLintBear:
|    | Entity References: Use the unicode equivalent instead: Change "&rdquo;" to "”".

data/locale/en/projects/git_task_list.html
|1073| name:·&ldquo;Git·Task·List&rdquo;
|    | [MAJOR] HTMLLintBear:
|    | Entity References: Use the unicode equivalent instead: Change "&ldquo;" to "“".

data/locale/en/projects/git_task_list.html
|1073| name:·&ldquo;Git·Task·List&rdquo;
|    | [MAJOR] HTMLLintBear:
|    | Entity References: Use the unicode equivalent instead: Change "&rdquo;" to "”".

data/locale/en/projects/git_task_list.html
|1075| <li>&ldquo;The·applicant·should·have·at·least·one·patch·merged·to·any·of·the·coala·repositories.&rdquo;</li>
|    | [MAJOR] HTMLLintBear:
|    | Entity References: Use the unicode equivalent instead: Change "&ldquo;" to "“".

data/locale/en/projects/git_task_list.html
|1075| <li>&ldquo;The·applicant·should·have·at·least·one·patch·merged·to·any·of·the·coala·repositories.&rdquo;</li>
|    | [MAJOR] HTMLLintBear:
|    | Entity References: Use the unicode equivalent instead: Change "&rdquo;" to "”".

data/locale/en/projects/git_task_list.html
|1076| <li>&ldquo;Familiarity·with·Git,·GitHub·API·Gerrit·API,·Phabricator·API,·and·GitLab·API&rdquo;</li>
|    | [MAJOR] HTMLLintBear:
|    | Entity References: Use the unicode equivalent instead: Change "&ldquo;" to "“".

data/locale/en/projects/git_task_list.html
|1076| <li>&ldquo;Familiarity·with·Git,·GitHub·API·Gerrit·API,·Phabricator·API,·and·GitLab·API&rdquo;</li>
|    | [MAJOR] HTMLLintBear:
|    | Entity References: Use the unicode equivalent instead: Change "&rdquo;" to "”".

data/locale/en/projects/git_task_list.html
|1077| <li>&ldquo;Familiarity·with·EmberJS,·Javascript,·and·GitHub·Pages&rdquo;
|    | [MAJOR] HTMLLintBear:
|    | Entity References: Use the unicode equivalent instead: Change "&ldquo;" to "“".

data/locale/en/projects/git_task_list.html
|1077| <li>&ldquo;Familiarity·with·EmberJS,·Javascript,·and·GitHub·Pages&rdquo;
|    | [MAJOR] HTMLLintBear:
|    | Entity References: Use the unicode equivalent instead: Change "&rdquo;" to "”".

data/locale/en/projects/git_task_list.html
|1083| <hr·/>
|    | [MAJOR] HTMLLintBear:
|    | Document Type: Do not close void elements: Remove the trailing " /" from the hr tag.

data/locale/en/projects/git_task_list.html
|1085| which·was·initialy·intended·for·GSOC·Applicans·who·don&rsquo;t·have·or·only·have·a
|    | [MAJOR] HTMLLintBear:
|    | Entity References: Use the unicode equivalent instead: Change "&rsquo;" to "’".
Executing section yml...
Executing section cli...

@@ -0,0 +1,1137 @@
<!DOCTYPE html><html><head><meta charset="utf-8"><meta name="collaborating_projects" content=""><style>body {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wtf is this :P
this commit is 30 mins old in the review queue, and you havent fixed it.

- web
---
The basic idea is an extended version of [GSOC Task List](http://summerofcode.github.io/gsoc-prep-tasks)
which was initialy intended for GSOC Applicans who don't have or only have a
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applicants.

way to find issues that has not been reviewed. It also help project’s maintainer
/ developer do review more efficient.

This also help engage developer to keep contributing to a project where they
Copy link
Member

@yukiisbored yukiisbored May 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will also help engage the developer to keep contributing to a project where they

/ developer do review more efficient.

This also help engage developer to keep contributing to a project where they
can’t find any issue that they can fix or keep the new comer issue for new comer
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/new comer/newcomer/g


This also help engage developer to keep contributing to a project where they
can’t find any issue that they can fix or keep the new comer issue for new comer
as learning path. And developer with more experience can contribute by reviewing
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should end the previous line. s/. And/ and /. I think developers will fit a lot better.

This also help engage developer to keep contributing to a project where they
can’t find any issue that they can fix or keep the new comer issue for new comer
as learning path. And developer with more experience can contribute by reviewing
new comer’s work PR
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

newcomer :P

as learning path. And developer with more experience can contribute by reviewing
new comer’s work PR

This project is also related to “New Comer Metrics And Gamification”. Where some
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Newcomer Metrics and Gamification"

new comer’s work PR

This project is also related to “New Comer Metrics And Gamification”. Where some
of the activities that will be given some point is involving:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find this a bit confusing. What kind of activities? Does both project share some features/goal or something else?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't share the same features. In my opinion part of the goal is the same, Engaging Developer.


Which is addressed by this project.

The Goal of this projects is a serverless web page where the user can find Pull
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The goal

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also what do you mean by serverless. The "serverless" marketing doublespeak is a bit inconsistent. Does it refer to the fact this project won't require a running backend and it is only a static-site javascript client? Or are you referring to stuff like AWS Functional Server?


The Goal of this projects is a serverless web page where the user can find Pull
Request that haven’t been reviewed. User can select projects in Open Source
hosting services like GitHub or GitLab. They also have the ability to select
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are other projects hosting sites outside of GitHub/GitLab are considered or is it just github and gitlab for now?

#### Milestone

##### Phase 1
- Support adding user token
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a feature, and should not be listed here.
c.f. #579 (comment)

I am being very pedantic about this as I do not want this project to be doing anything like coala/git-task-list#15 , which is cool but not in scope and will be an enormous time drain (especially when getting it to work on GitLab, Phabricator, etc,etc), and that type of functionality has been put into the gh-board meta-review project so it is not needed or wanted by coala in the git-tasks project, as it could potentially even cause problems for the meta-review project if there are two tools which allow that type of user functionality.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jayvdb removed

@bekicot bekicot force-pushed the add-git-task-list branch from ad56be5 to dea09ab Compare May 23, 2018 01:58
@jayvdb jayvdb requested review from blazeu and removed request for sims1253 May 23, 2018 06:41
reviewing newcomer’s work PR.

The goal of this projects is a static-site javascript web page where the user
can find Pull Request that haven’t been reviewed. User can select projects in
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PRs and issues?

comer as learning path and developer with more experience can contribute by
reviewing newcomer’s work PR.

The goal of this projects is a static-site javascript web page where the user
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think static-site javascript web page is really verbose, static site is enough.

@bekicot bekicot force-pushed the add-git-task-list branch from dea09ab to fce277e Compare May 23, 2018 11:54
requests, and other metadata that is provided by the web services
(GitHub/GitLab).

Because the concept of this project, is the same as [GSOC prep task](http://summerofcode.github.io/gsoc-prep-tasks), it can be used as the starting point of this project.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

long line.

@bekicot bekicot force-pushed the add-git-task-list branch from fce277e to f5ca3b5 Compare May 23, 2018 15:34
@blazeu
Copy link
Member

blazeu commented May 23, 2018

ack f5ca3b5

@blazeu
Copy link
Member

blazeu commented May 23, 2018

@gitmate-bot ff

@gitmate-bot
Copy link

Hey @blazeu, you do not have the access to perform the fastforward action with GitMate.io. Please ask a maintainer to give you access. ⚠️

@jayvdb
Copy link
Member

jayvdb commented May 23, 2018

@gitmate-bot ff

@gitmate-bot
Copy link

Hey! I'm GitMate.io! This pull request is being fastforwarded automatically. Please DO NOT push while fastforward is in progress or your changes would be lost permanently ⚠️

@gitmate-bot gitmate-bot merged commit f5ca3b5 into coala:master May 23, 2018
@gitmate-bot
Copy link

Automated fastforward with GitMate.io was successful! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

8 participants