-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
git_task_list.md: Add Git Task List project #579
Conversation
_projects/git_task_list.md
Outdated
#### Links | ||
|
||
- [http://github.com/summerofcode/gsoc-prep-tasks][1] | ||
- [http://summerofcode.github.io/gsoc-prep-tasks][2] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need external links here? wouldn't it be better if we get a coala repo for the same...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yashovardhanagrawal No need, just an easy navigation. It is just my preference. For me it is easy to keep track of external stuff this way as I do skip links if Iread a long text, some kind of read later shortcut.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See when this PR is merged, it would be up at projects.coala.io and there having a reference link to repos that are not part of coala would not be a nice idea
I think @jayvdb may be able to help us out here better
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do need to mention the project repo URL at the top of the rendered page, not useful here.
_projects/git_task_list.md
Outdated
- https://github.com/coala/coala/issues/4080 | ||
markdown: git_task_list.md | ||
mentors: | ||
- jayvdb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not on your list of mentors, and the first mentor listed here should be your primary mentor.
_projects/git_task_list.md
Outdated
--- | ||
|
||
The basic idea is an extended version of [GSOC Task List][2] which was initialy | ||
intended for GSOC Applicans who don't have to a little experience in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
spelling mistake
_projects/git_task_list.md
Outdated
project. | ||
|
||
This project will help sharing the tasks of reviewing a pull request on a | ||
project. This is also maybe the solution of https://github.com/coala/coala/issues/4080, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue links belong in the project metadata, and should not be listed in the project spec.
The project spec should use sentences which explain the problems and solutions.
_projects/git_task_list.md
Outdated
--- | ||
collaborating_projects: | ||
- coala | ||
- meta-review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no. meta-review is being done by the other project. Your project proposal did not propose any solutions related to meta-review.
_projects/git_task_list.md
Outdated
@@ -0,0 +1,87 @@ | |||
--- | |||
collaborating_projects: | |||
- coala |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no. your project does not intend to enhance coala/coala
.
here you would put gsoc-prep-tasks
as the related project
_projects/git_task_list.md
Outdated
#### Milestone | ||
|
||
##### Phase 1 | ||
- Add gitlab support |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gitlab -> GitLab.
check & fix your capitalisation throughout the document.
you shouldnt need mentors to be pointing out silly things like this.
_projects/git_task_list.md
Outdated
|
||
This project is also related to “New Comer Metrics And Gamification”. Where one | ||
of the possible accomplishment is doing reviews. | ||
The Goal of this projects is a serverless web page where the user can find Pull |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only pull requests?
what about issues?
what about commits merged?
See issues list in gsoc-prep-tasks
_projects/git_task_list.md
Outdated
#### Links | ||
|
||
- [http://github.com/summerofcode/gsoc-prep-tasks][1] | ||
- [http://summerofcode.github.io/gsoc-prep-tasks][2] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do need to mention the project repo URL at the top of the rendered page, not useful here.
_projects/git_task_list.md
Outdated
|
||
- [http://github.com/summerofcode/gsoc-prep-tasks][1] | ||
- [http://summerofcode.github.io/gsoc-prep-tasks][2] | ||
- [https://github.com/coala/projects/issues/480](https://github.com/coala/projects/issues/480) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these issue links should be in the metadata , not here.
a168f81
to
c2c554e
Compare
Comment on c2c554e, file _projects/git_task_list.html. This file had 1137 lines, which is 637 lines more than the maximum limit specified. Origin: LineCountBear, Section: |
Comment on c2c554e, file data/locale/en/projects/git_task_list.html. This file had 1137 lines, which is 637 lines more than the maximum limit specified. Origin: LineCountBear, Section: |
Comment on c2c554e, file data/locale/en/projects/git_task_list.html, line 1137. Line contains following spacing inconsistencies:
Origin: SpaceConsistencyBear, Section: The issue can be fixed by applying the following patch: --- a/tmp/tmploc10vzf/data/locale/en/projects/git_task_list.html
+++ b/tmp/tmploc10vzf/data/locale/en/projects/git_task_list.html
@@ -1134,4 +1134,4 @@
<li>Add Gerrit support</li>
<li>Add Phabricator support</li>
<li>Improve UI and UX.</li>
-</ul></article></body></html>+</ul></article></body></html> |
_projects/git_task_list.html
Outdated
<li>Add Gerrit support</li> | ||
<li>Add Phabricator support</li> | ||
<li>Improve UI and UX.</li> | ||
</ul></article></body></html> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line contains following spacing inconsistencies:
- No newline at EOF.
Origin: SpaceConsistencyBear, Section: spacing
.
The issue can be fixed by applying the following patch:
--- a/tmp/tmploc10vzf/_projects/git_task_list.html
+++ b/tmp/tmploc10vzf/_projects/git_task_list.html
@@ -1134,4 +1134,4 @@
<li>Add Gerrit support</li>
<li>Add Phabricator support</li>
<li>Improve UI and UX.</li>
-</ul></article></body></html>+</ul></article></body></html>
Travis tests have failedHey @bekicot, Ruby: 2.3.3docker run -v=$(pwd):/app --workdir=/app coala/base coala --ci
|
_projects/git_task_list.html
Outdated
@@ -0,0 +1,1137 @@ | |||
<!DOCTYPE html><html><head><meta charset="utf-8"><meta name="collaborating_projects" content=""><style>body { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wtf is this :P
this commit is 30 mins old in the review queue, and you havent fixed it.
_projects/git_task_list.md
Outdated
- web | ||
--- | ||
The basic idea is an extended version of [GSOC Task List](http://summerofcode.github.io/gsoc-prep-tasks) | ||
which was initialy intended for GSOC Applicans who don't have or only have a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Applicants.
_projects/git_task_list.md
Outdated
way to find issues that has not been reviewed. It also help project’s maintainer | ||
/ developer do review more efficient. | ||
|
||
This also help engage developer to keep contributing to a project where they |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will also help engage the developer to keep contributing to a project where they
_projects/git_task_list.md
Outdated
/ developer do review more efficient. | ||
|
||
This also help engage developer to keep contributing to a project where they | ||
can’t find any issue that they can fix or keep the new comer issue for new comer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/new comer/newcomer/g
_projects/git_task_list.md
Outdated
|
||
This also help engage developer to keep contributing to a project where they | ||
can’t find any issue that they can fix or keep the new comer issue for new comer | ||
as learning path. And developer with more experience can contribute by reviewing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should end the previous line. s/. And/ and /
. I think developers
will fit a lot better.
_projects/git_task_list.md
Outdated
This also help engage developer to keep contributing to a project where they | ||
can’t find any issue that they can fix or keep the new comer issue for new comer | ||
as learning path. And developer with more experience can contribute by reviewing | ||
new comer’s work PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
newcomer :P
_projects/git_task_list.md
Outdated
as learning path. And developer with more experience can contribute by reviewing | ||
new comer’s work PR | ||
|
||
This project is also related to “New Comer Metrics And Gamification”. Where some |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Newcomer Metrics and Gamification"
_projects/git_task_list.md
Outdated
new comer’s work PR | ||
|
||
This project is also related to “New Comer Metrics And Gamification”. Where some | ||
of the activities that will be given some point is involving: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find this a bit confusing. What kind of activities? Does both project share some features/goal or something else?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't share the same features. In my opinion part of the goal is the same, Engaging Developer.
_projects/git_task_list.md
Outdated
|
||
Which is addressed by this project. | ||
|
||
The Goal of this projects is a serverless web page where the user can find Pull |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The goal
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also what do you mean by serverless
. The "serverless" marketing doublespeak is a bit inconsistent. Does it refer to the fact this project won't require a running backend and it is only a static-site javascript client? Or are you referring to stuff like AWS Functional Server?
_projects/git_task_list.md
Outdated
|
||
The Goal of this projects is a serverless web page where the user can find Pull | ||
Request that haven’t been reviewed. User can select projects in Open Source | ||
hosting services like GitHub or GitLab. They also have the ability to select |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are other projects hosting sites outside of GitHub/GitLab are considered or is it just github and gitlab for now?
cfb55a7
to
ad56be5
Compare
_projects/git_task_list.md
Outdated
#### Milestone | ||
|
||
##### Phase 1 | ||
- Support adding user token |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not a feature, and should not be listed here.
c.f. #579 (comment)
I am being very pedantic about this as I do not want this project to be doing anything like coala/git-task-list#15 , which is cool but not in scope and will be an enormous time drain (especially when getting it to work on GitLab, Phabricator, etc,etc), and that type of functionality has been put into the gh-board
meta-review project so it is not needed or wanted by coala in the git-tasks project, as it could potentially even cause problems for the meta-review project if there are two tools which allow that type of user functionality.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jayvdb removed
ad56be5
to
dea09ab
Compare
_projects/git_task_list.md
Outdated
reviewing newcomer’s work PR. | ||
|
||
The goal of this projects is a static-site javascript web page where the user | ||
can find Pull Request that haven’t been reviewed. User can select projects in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PRs and issues?
_projects/git_task_list.md
Outdated
comer as learning path and developer with more experience can contribute by | ||
reviewing newcomer’s work PR. | ||
|
||
The goal of this projects is a static-site javascript web page where the user |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think static-site javascript web page
is really verbose, static site
is enough.
dea09ab
to
fce277e
Compare
_projects/git_task_list.md
Outdated
requests, and other metadata that is provided by the web services | ||
(GitHub/GitLab). | ||
|
||
Because the concept of this project, is the same as [GSOC prep task](http://summerofcode.github.io/gsoc-prep-tasks), it can be used as the starting point of this project. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
long line.
fce277e
to
f5ca3b5
Compare
ack f5ca3b5 |
@gitmate-bot ff |
Hey @blazeu, you do not have the access to perform the fastforward action with GitMate.io. Please ask a maintainer to give you access. |
@gitmate-bot ff |
Hey! I'm GitMate.io! This pull request is being fastforwarded automatically. Please DO NOT push while fastforward is in progress or your changes would be lost permanently |
Automated fastforward with GitMate.io was successful! 🎉 |
Related to:
#480
coala/coala#4080
For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!
Checklist
them.
individually. It is not sufficient to have "fixup commits" on your PR,
our bot will still report the issues for the previous commit.) You will
likely receive a lot of bot comments and build failures if coala does not
pass on every single commit!
After you submit your pull request, DO NOT click the 'Update Branch' button.
When asked for a rebase, consult coala.io/rebase
instead.
Please consider helping us by reviewing other peoples pull requests as well:
cobot mark wip <URL>
to get it outof the review queue.
The more you review, the more your score will grow at coala.io and we will
review your PRs faster!