Fix-of-issue-653

[Aditya-138-12]

Changes / Fixes

1. Added a shortcode file for tab.html.
2. Modified tabs.html file for href, scrolling and removed prefix "nav-" from the id of tag of tablist, Added js Script in tabs.html for making the url change in adress bar when a tab is pressed.
3. Modified index.md, added tabID in {{< tab tabName="Investment" tabID="Investment">}} for all tabs.

This PR fixes #653

[netlify]

✅ Deploy Preview for tag-app-delivery ready!

Name	Link
🔨 Latest commit	07f909d
🔍 Latest deploy log	https://app.netlify.com/sites/tag-app-delivery/deploys/6676d7ab4feae800080c1cd4
😎 Deploy Preview	https://deploy-preview-698--tag-app-delivery.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[Aditya-138-12]

Hi, @abangser
I completely forgot about this issue taken by me, I am so soory for that...
Could you please take a look?

[abangser]

No stress @Aditya-138-12 , thanks for taking the time to do this! I just had a look at the preview branch and I am not sure it quite behaves as I would have expected. Specifically I would expect:

1. When I click on the header of an aspect within the table
   a. Expected: the URL should display the aspect I have selected
   b. Actual: The URL gets a # but no other indicator, thereby not allowing users to link to a specific aspect by URL
2. When I click on the header of an aspect within the table
   a. Expected: The page scrolls to the details section
   b. Actual: the details section (correctly) switches tabs, but the page does not scroll
3. When I click on the 'anchor link' for a characteristics section in the details
   a. Expected: it should be unique and something I can share a direct URL to
   b. Actual: it is just #characteristics in the URL thereby not being unique to that aspect/level combo

These anchor tags prove to be quite tricky but I am not sure this specific change hits the mark just yet! Happy to keep reviewing as you make progress though 😊

[Aditya-138-12]

Hi @abangser
Yeah, It looks quite tricky though, but I will try to fix them,
Thanks for your time!!