[crucible apps] Feature/ingress-updates #64
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Updates crucible application manifests to use a
crucible-common
library for templating commonly used features.This first pass introduces the use of the common library for generating kubernetes ingress resources.
In the short term, this change makes the
consoleIngress
deploy work for theplayer/vm-api
sub-application.In the long term, the use of a common library will make maintaining charts easier whenever changes are needed to
common components, as the change will often be able to be made only to the underlying common template elements.
Features
crucible-common
library chartMaintenance
Chart.yaml
filesBugfix
consoleIngress
now deploys fromplayer/
vm-api`Testing
To test:
Clone the repository
Choose an app to compare formats
Replace the
dependencies
stanza in charts/<app>/Chart.yaml with:Run
helm dependency build
in the app folder, this will build thecrucible-common
dependencyWrite (or use an existing) values.yaml for the app
run from the root of the charts repo:
Check that everything matches
If it looks good, may then deploy to a development cluster.
Possible Drawbacks
Requiring a dependency does add another (small) layer of complexity for airgapped/offline installs, but as shown in testing it is possible to replace the dependency source with local files.