Skip to content

GB UI - default settingsYaml to null #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 6, 2025
Merged

GB UI - default settingsYaml to null #116

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
15b761c
Default settingsYaml to null rather than a default config to avoid in…
sei-bstein Sep 24, 2025
fd2c3ec
Code review feedback
sei-bstein Sep 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/gameboard/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,4 +15,4 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 0.5.7
version: 0.5.8
2 changes: 1 addition & 1 deletion charts/gameboard/charts/gameboard-ui/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 0.5.7
version: 0.5.8

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
Expand Down
10 changes: 6 additions & 4 deletions charts/gameboard/charts/gameboard-ui/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,8 +89,10 @@ basehref: ""
settings: "{}"

## assets/settings.json content in yaml form. Takes precedence over settings: value when populated.
settingsYaml:
appname: Gameboard
## NOTE: If specified here, will override the generated settings.json for installations that are using
## the `settings` key. Change with caution.
settingsYaml: {}
# appname: Gameboard
# apphost: http://localhost:5002
# basehref: "gb"
# imghost: 'http://localhost:5002/img'
Expand All @@ -99,15 +101,15 @@ settingsYaml:
# tocfile: ''
# countdownStartSecondsAtMinute: 5
# custom_background: 'custom-bg-dark-gray'
consoleForgeConfig:
# consoleForgeConfig:
# canvasRecording:
# autoDownloadCompletedRecordings: true
# chunkLength: 1000
# frameRate: 25
# maxDuration: 10000
# mimeType: 'video/webm'
# consoleBackgroundStyle: 'rgb(40, 40, 40)'
defaultConsoleType: vmware # or "proxmox"
# defaultConsoleType: vmware # or "proxmox"
# disabledFeatures:
# clipboard: false
# consoleScreenRecord: false
Expand Down
10 changes: 6 additions & 4 deletions charts/gameboard/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,8 +289,10 @@ gameboard-ui:
settings: "{}"

## assets/settings.json content in yaml form. Takes precedence over settings: value when populated.
settingsYaml:
appname: Gameboard
## NOTE: If specified here, will override the generated settings.json for installations that are using
## the `settings` key. Change with caution.
settingsYaml: {}
# appname: Gameboard
# apphost: http://localhost:5002
# basehref: "gb"
# imghost: 'http://localhost:5002/img'
Expand All @@ -299,15 +301,15 @@ gameboard-ui:
# tocfile: ''
# countdownStartSecondsAtMinute: 5
# custom_background: 'custom-bg-dark-gray'
consoleForgeConfig:
# consoleForgeConfig:
# canvasRecording:
# autoDownloadCompletedRecordings: true
# chunkLength: 1000
# frameRate: 25
# maxDuration: 10000
# mimeType: 'video/webm'
# consoleBackgroundStyle: 'rgb(40, 40, 40)'
defaultConsoleType: vmware # or "proxmox"
# defaultConsoleType: vmware # or "proxmox"
# disabledFeatures:
# clipboard: false
# consoleScreenRecord: false
Expand Down