Update data attributions #2
Conversation
brookslogan
changed the title
brookslogan
force-pushed
the
lcb/adjust-attribution
branch
from
78ed183 to
01b71e3
Compare
DESCRIPTION
Outdated
| person("Johns Hopkins University Center for Systems Science and Engineering", role = "dtc", comment = "Owner of COVID-19 cases and deaths data sourced from the COVID-19 Data Repository"), | ||
| person("Johns Hopkins University", role = "cph", comment = "Copyright holder of COVID-19 cases and deaths data sourced from the COVID-19 Data Repository"), | ||
| person("Carnegie Mellon University Delphi Group", role = "dtc", comment = "Owner of masking and social-distancing data sourced from the COVID-19 Trends and Impacts Survey"), | ||
| person("Carnegie Mellon University", role = "cph", comment = "Copyright holder of masking and social-distancing data sourced from the COVID-19 Trends and Impacts Survey") |
There was a problem hiding this comment.
question: Not sure this is true. Is Delphi the copyright holder?
There was a problem hiding this comment.
(Not quite an answer. I based this on https://cmu-delphi.github.io/delphi-epidata/api/covidcast_licensing.html:
[...]
You may use this data for any purpose, provided you attribute us as the original source, as shown above.
So if this is imprecise, we also need to update there.)
There was a problem hiding this comment.
Dropping the CMU CTIS cph line. We can resolve it as part of issue cmu-delphi/epiprocess#348
Right now, we only list Dan and data citations. Who else is an author? Is it only you? |
|
What did you want to include in |
There was a problem hiding this comment.
I can't approve this as it's "my" PR. But I think it's good to go after addressing the inline comments. I like the current format but think there's some missing attribution + licensing stuff for doctor visits and Canada data. I've also made a whole bunch of minor mechanical suggestions (probably should have just made a commit, sorry) + a typo fix.
|
@brookslogan I think this is actually ready now. |
There was a problem hiding this comment.
Great! I think this can be merged now after:
- updating for epiprocess update (
grad_employ_subsetneeds slight tweak) - a few typo fixes.
That said, there does seem to be some extra files / complications / package size that could be avoided, though these don't seem to be impacting the functionality.
[I would approve this but I can't, as it's "my" PR.]
Co-authored-by: brookslogan <[email protected]>
Co-authored-by: brookslogan <[email protected]>
Co-authored-by: brookslogan <[email protected]>
Co-authored-by: brookslogan <[email protected]>
nmdefries
force-pushed
the
lcb/adjust-attribution
branch
from
5313fa6 to
c6f8fcc
Compare
WIP on updating data attribution. We still lack Authors@R entries and/or inst/COPYRIGHTS, and maybe some individual
@source/ other roxygen needs updated.