-
Notifications
You must be signed in to change notification settings - Fork 67
Adding COVID mobility data source #351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Adding COVID mobility data
Adding COVID mobility data insertion files
Adding COVID mobility test file
Adding COVID mobility data table creation script
Adding COVID mobility source
Add COVID Mobility API
Add COVID mobility API
Add COVID mobility API
Add COVID mobility API
|
Thanks for this! This is quite a lot of work, and I'm impressed you were able to find your way around the codebase quickly. At this point we have a few design decisions to make before we integrate this code. First is our prioritization; once we add these indicators, we'll need to maintain them and run them regularly, which will require devoting some resources. @krivard and the engineering team will need to discuss this. Second, it looks like you've added new Epidata endpoints, and you store county-level data for Google and some similar level ( The advantage here is that covidcast-indicators contains a utility module that can, for instance, take county-level data and produce aggregates for states, metropolitan statistical areas, hospital referral regions, HHS regions, and so on. Using the covidcast system would also allow the R and Python covidcast packages to fetch the data easily, and since you've already done the hard work of extracting the data, maybe the code wouldn't be too difficult. (Depends on how closely their geographic coding matches ours, I think.) If you'd like to go that route, it'd be a good idea to coordinate with @krivard and the engineering team so they can guide you to the best way to implement this code so we can integrate it. |
|
Dr. Alex Reinhart, Thank you for the reviews and your quick response. |
Added fips code to Google and Apple mobility table
Added fips code to Apple and Google mobility data
Added fips code to Apple mobility data
fips code value for each county
fips code value for each county
Added fips code for Google mobility data
Added fips code to Apple and Google mobility data
Added fips code to test cases
|
Dr. Alex Reinhart, FIPS code for each county has been added to the Apple and Google mobility data. Can you please provide me with your reviews. Also planning on adding vaccination data. But it may not contain county level details. Would that be fine Dr. Dr. Alex Reinhart. Would be creating a datasource to capture vaccination details. Dr. Katie Mazaitis, can you please let me know how do we integrate mobility data with the main stream. Need your assistance and help. |
|
Hello, I agree with Alex that we will want to approach this as a covidcast indicator and not its own Epidata endpoint. I am sorry to be giving you the runaround -- answers to the questions on the original PR would have helped us give you better instructions. Covidcast indicator pipelines are hosted in this repository: https://github.com/cmu-delphi/covidcast-indicators The rough requirements of an indicator are:
There is a template module there: https://github.com/cmu-delphi/covidcast-indicators/tree/main/_template_python & you can also look at other CSV-reading indicators like Before we accept your PR and deploy the new indicator, we will also want to know:
Feel free to email me ([email protected]) if you want to discuss further. |
|
Dr. Alex Reinhart and Dr. Katie Mazaitis Thank you for the review and guidance. Will be adding mobility data as covidcast indicators. |
Dr. Alex Reinhart,
As discussed in the pull request#384. COVID mobility data can now be used as an API source. Have commited all the required files. Can you please review and provide me your input.
cmu-delphi/covidcast#384