Fixes in anticipation of ggplot update #670
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was a combination of POLYGON and LINESTRING, but geom_sf() filters out non-MULTIPOLYGON shapes. This meant there were n-1 spatial features, but any provided fill aesthetics had n features, meaning a mismatch. Manually rewrite to be a MULTIPOLYGON containing only the POLYGON.
It now complains extensively about length-0 fill variables. When geographic plots were subset to not include all regions, some of the geom_sf() calls would have no data; for example, a plot without Hawaii still called geom_sf() to show a translated but non-existent Hawaii. This raised warnings. Instead, check if there is data to plot, and use geom_blank() if there isn't.
|
I'll need to check if the test failures are just rendering differences between Mac and Linux; I suspect they are. If so, I'll revert to the version that works on Linux. |
This reverts commit 2a9c595.
dshemetov
approved these changes
Jun 30, 2025
|
I think the failing tests are all just cross-platform differences in plot rendering. Given that we're not going to be adding any features to the package or doing any more than minimal maintenance, I don't think it's worth trying to fix that, so I'll go ahead and submit the release. (The plot tests are not run on CRAN.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in response to #669. The commit messages explain each issue that had to be fixed to keep the upcoming ggplot2 happy.
I'll test this again, and then we can submit to CRAN to avoid covidcast being deleted after the new ggplot2 version is released.