Add hhs and nation to DV #935
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
:( converted if/else block it to a dict for now. |
|
@mariajahja if this is good we'll want to update the copy on the magic server once it's merged |
mariajahja
approved these changes
Mar 19, 2021
There was a problem hiding this comment.
Actual PR looks good and some quick checks for county/hrr/state line up with existing estimates.
Noticed that there were some params.json changes from the version running on the magic server, but there some small adjustments needed (dropped f-strings prefixes and change from 60->70 days of updates). @krivard OK for me to open a separate PR for these?
|
@mariajahja yep, separate PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaces #616.
Cherrypicked 588f805 and made one small typo change.
Changelog
Itemize code/test/documentation changes and files added/removed.
Fixes