Skip to content

Change join condition to match datafusion and fix type errors from pr…

Sign in for the full log view
GitHub Actions / clippy failed Jan 28, 2025 in 1s

reviewdog [clippy] report

reported by reviewdog 🐶

Findings (52)

infra/src/lib.rs|9 col 5| warning: unused import: std::collections::HashMap
--> infra/src/lib.rs:9:5
|
9 | use std::collections::HashMap;
| ^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: #[warn(unused_imports)] on by default
infra/src/lib.rs|10 col 22| warning: unused import: Mutex
--> infra/src/lib.rs:10:22
|
10 | use std::sync::{Arc, Mutex};
| ^^^^^
infra/src/lib.rs|18 col 32| warning: unused imports: Explain, PlanType, TableSource, and ToStringifiedPlan
--> infra/src/lib.rs:18:32
|
18 | use datafusion::logical_expr::{Explain, LogicalPlan, PlanType, TableSource, ToStringifiedPlan};
| ^^^^^^^ ^^^^^^^^ ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^
infra/src/lib.rs|21 col 27| warning: unused import: log
--> infra/src/lib.rs:21:27
|
21 | use datafusion::prelude::{log, Expr, SessionConfig, SessionContext};
| ^^^
infra/src/lib.rs|65 col 21| warning: redundant field names in struct initialization
--> infra/src/lib.rs:65:21
|
65 | predicate: predicate,
| ^^^^^^^^^^^^^^^^^^^^ help: replace it with: predicate
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
= note: #[warn(clippy::redundant_field_names)] on by default
infra/src/lib.rs|81 col 25| warning: redundant field names in struct initialization
--> infra/src/lib.rs:81:25
|
81 | condition: condition,
| ^^^^^^^^^^^^^^^^^^^^ help: replace it with: condition
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
infra/src/lib.rs|16 col 41| warning: use of deprecated type alias datafusion::execution::runtime_env::RuntimeConfig: please use RuntimeEnvBuilder instead
--> infra/src/lib.rs:16:41
|
16 | use datafusion::execution::runtime_env::RuntimeConfig;
| ^^^^^^^^^^^^^
|
= note: #[warn(deprecated)] on by default
infra/src/lib.rs|201 col 23| warning: use of deprecated type alias datafusion::execution::runtime_env::RuntimeConfig: please use RuntimeEnvBuilder instead
--> infra/src/lib.rs:201:23
|
201 | rn_config: Option,
| ^^^^^^^^^^^^^
infra/src/lib.rs|216 col 9| warning: use of deprecated type alias datafusion::execution::runtime_env::RuntimeConfig: please use RuntimeEnvBuilder instead
--> infra/src/lib.rs:216:9
|
216 | RuntimeConfig::new()
| ^^^^^^^^^^^^^
infra/src/lib.rs|160 col 13| warning: unused variable: optdLogicalPlan
--> infra/src/lib.rs:160:13
|
160 | let optdLogicalPlan = Self::get_optd_logical_plan(logical_plan);
| ^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: _optdLogicalPlan
|
= note: #[warn(unused_variables)] on by default
infra/src/lib.rs|161 col 17| warning: unused variable: optimizer
--> infra/src/lib.rs:161:17
|
161 | let mut optimizer = self.optimizer.clone();
| ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: _optimizer
infra/src/lib.rs|161 col 13| warning: variable does not need to be mutable
--> infra/src/lib.rs:161:13
|
161 | let mut optimizer = self.optimizer.clone();
| ----^^^^^^^^^
| |
| help: remove this mut
|
= note: #[warn(unused_mut)] on by default
infra/src/types/memo.rs|7 col 38| warning: unused variable: logical_expr
--> infra/src/types/memo.rs:7:38
|
7 | pub async fn add_expr(&mut self, logical_expr: Expr) -> (ExprId, GroupId) {
| ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: _logical_expr
infra/src/types/memo.rs|11 col 47| warning: unused variable: logical_expr
--> infra/src/types/memo.rs:11:47
|
11 | pub async fn add_expr_to_group(&mut self, logical_expr: Expr, group_id: GroupId) -> ExprId {
| ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: _logical_expr
infra/src/types/memo.rs|11 col 67| warning: unused variable: group_id
--> infra/src/types/memo.rs:11:67
|
11 | pub async fn add_expr_to_group(&mut self, logical_expr: Expr, group_id: GroupId) -> ExprId {
| ^^^^^^^^ help: if this is intentional, prefix it with an underscore: _group_id
infra/src/types/memo.rs|15 col 45| warning: unused variable: group_id
--> infra/src/types/memo.rs:15:45
|
15 | pub async fn get_group_exprs(&mut self, group_id: GroupId) -> Vec<(ExprId, Expr)> {
| ^^^^^^^^ help: if this is intentional, prefix it with an underscore: _group_id
infra/src/types/memo.rs|19 col 44| warning: unused variable: logical_expr_id
--> infra/src/types/memo.rs:19:44
|
19 | pub async fn get_expr_group(&mut self, logical_expr_id: ExprId) -> GroupId {
| ^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: _logical_expr_id
infra/src/lib.rs|87 col 26| warning: unused variable: logical_plan
--> infra/src/lib.rs:87:26
|
87 | pub fn mock_optimize(logical_plan: OptDLogicalPlan) -> PhysicalPlan {
| ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: _logical_plan
infra/src/lib.rs|97 col 33| warning: unused variable: predicate_expr
--> infra/src/lib.rs:97:33
|
97 | fn convert_into_optd_scalar(predicate_expr: Expr) -> Scalar {
| ^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: _predicate_expr
infra/src/lib.rs|93 col 5| warning: type OptdOptimizer is more private than the item OptdQueryPlanner::optimizer
--> infra/src/lib.rs:93:5
|
93 | pub optimizer: Arc,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ field OptdQueryPlanner::optimizer is reachable at visibility pub
|
note: but type OptdOptimizer is only usable at visibility pub(crate)
--> infra/src/lib.rs:43:1
|
43 | struct OptdOptimizer {}
| ^^^^^^^^^^^^^^^^^^^^
= note: #[warn(private_interfaces)] on by default
infra/src/lib.rs|172 col 5| warning: type OptdOptimizer is more private than the item OptdQueryPlanner::new
--> infra/src/lib.rs:172:5
|
172 | pub fn new(optimizer: OptdOptimizer) -> Self {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ associated function OptdQueryPlanner::new is reachable at visibility pub
|
note: but type OptdOptimizer is only usable at visibility pub(crate)
--> infra/src/lib.rs:43:1
|
43 | struct OptdOptimizer {}
| ^^^^^^^^^^^^^^^^^^^^
infra/src/lib.rs|45 col 1| warning: associated functions conv_logical_to_physical and mock_optimize are never used
--> infra/src/lib.rs:46:8
|
45 | impl OptdOptimizer {
| ------------------ associated functions in this implementation
46 | fn conv_logical_to_physical(
| ^^^^^^^^^^^^^^^^^^^^^^^^
...
87 | pub fn mock_optimize(logical_plan: OptDLogicalPlan) -> PhysicalPlan {
| ^^^^^^^^^^^^^
|
= note: #[warn(dead_code)] on by default
infra/src/types/expression/mod.rs|5 col 10| warning: enum Expr is never used
--> infra/src/types/expression/mod.rs:5:10
|
5 | pub enum Expr {
| ^^^^
infra/src/types/expression/relational/mod.rs|5 col 10| warning: enum RelationalExpr is never used
--> infra/src/types/expression/relational/mod.rs:5:10
|
5 | pub enum RelationalExpr {
| ^^^^^^^^^^^^^^
infra/src/types/expression/relational/logical.rs|2 col 10| warning: enum LogicalExpr is never used
--> infra/src/types/expression/relational/logical.rs:2:10
|
2 | pub enum LogicalExpr {
| ^^^^^^^^^^^
infra/src/types/expression/relational/logical.rs|8 col 12| warning: struct LogicalScanExpr is never constructed
--> infra/src/types/expression/relational/logical.rs:8:12
|
8 | pub struct LogicalScanExpr;
| ^^^^^^^^^^^^^^^
infra/src/types/expression/relational/logical.rs|10 col 12| warning: struct LogicalFilterExpr is never constructed
--> infra/src/types/expression/relational/logical.rs:10:12
|
10 | pub struct LogicalFilterExpr;
| ^^^^^^^^^^^^^^^^^
infra/src/types/expression/relational/logical.rs|12 col 12| warning: struct LogicalJoinExpr is never constructed
--> infra/src/types/expression/relational/logical.rs:12:12
|
12 | pub struct LogicalJoinExpr;
| ^^^^^^^^^^^^^^^
infra/src/types/expression/relational/physical.rs|2 col 10| warning: enum PhysicalExpr is never used
--> infra/src/types/expression/relational/physical.rs:2:10
|
2 | pub enum PhysicalExpr {
| ^^^^^^^^^^^^
infra/src/types/expression/relational/physical.rs|8 col 12| warning: struct TableScanExpr is never constructed
--> infra/src/types/expression/relational/physical.rs:8:12
|
8 | pub struct TableScanExpr;
| ^^^^^^^^^^^^^
infra/src/types/expression/relational/physical.rs|10 col 12| warning: struct PhysicalFilterExpr is never constructed
--> infra/src/types/expression/relational/physical.rs:10:12
|
10 | pub struct PhysicalFilterExpr;
| ^^^^^^^^^^^^^^^^^^
infra/src/types/expression/relational/physical.rs|12 col 12| warning: struct HashJoinExpr is never constructed
--> infra/src/types/expression/relational/physical.rs:12:12
|
12 | pub struct HashJoinExpr;
| ^^^^^^^^^^^^
infra/src/types/expression/scalar.rs|4 col 12| warning: struct ScalarExpr is never constructed
--> infra/src/types/expression/scalar.rs:4:12
|
4 | pub struct ScalarExpr;
| ^^^^^^^^^^
infra/src/types/memo.rs|4 col 12| warning: struct Memo is never constructed
--> infra/src/types/memo.rs:4:12
|
4 | pub struct Memo;
| ^^^^
infra/src/types/memo.rs|6 col 1| warning: methods add_expr, add_expr_to_group, get_group_exprs, get_expr_group, and create_new_group are never used
--> infra/src/types/memo.rs:7:18
|
6 | impl Memo {
| --------- methods in this implementation
7 | pub async fn add_expr(&mut self, logical_expr: Expr) -> (ExprId, GroupId) {
| ^^^^^^^^
...
11 | pub async fn add_expr_to_group(&mut self, logical_expr: Expr, group_id: GroupId) -> ExprId {
| ^^^^^^^^^^^^^^^^^
...
15 | pub async fn get_group_exprs(&mut self, group_id: GroupId) -> Vec<(ExprId, Expr)> {
| ^^^^^^^^^^^^^^^
...
19 | pub async fn get_expr_group(&mut self, logical_expr_id: ExprId) -> GroupId {
| ^^^^^^^^^^^^^^
...
23 | pub async fn create_new_group(&mut self) -> GroupId {
| ^^^^^^^^^^^^^^^^
infra/src/types/operator/logical.rs|23 col 5| warning: field 0 is never read
--> infra/src/types/operator/logical.rs:23:10
|
23 | Scan(LogicalScanOperator),
| ---- ^^^^^^^^^^^^^^^^^^^
| |
| field in this variant
|
help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field
|
23 | Scan(()),
| ~~
infra/src/types/operator/logical.rs|29 col 12| warning: fields table_name and predicate are never read
--> infra/src/types/operator/logical.rs:30:9
|
29 | pub struct LogicalScanOperator {
| ------------------- fields in this struct
30 | pub table_name: String,
| ^^^^^^^^^^
31 | pub predicate: Option,
| ^^^^^^^^^
infra/src/types/operator/logical.rs|35 col 12| warning: fields child and predicate are never read
--> infra/src/types/operator/logical.rs:36:9
|
35 | pub struct LogicalFilterOperator {
| --------------------- fields in this struct
36 | pub child: Link,
| ^^^^^
37 | pub predicate: Scalar,
| ^^^^^^^^^
infra/src/types/operator/logical.rs|41 col 12| warning: fields join_type, left, right, and condition are never read
--> infra/src/types/operator/logical.rs:42:9
|
41 | pub struct LogicalJoinOperator {
| ------------------- fields in this struct
42 | pub join_type: (),
| ^^^^^^^^^
43 | pub left: Link,
| ^^^^
44 | pub right: Link,
| ^^^^^
45 | pub condition: Arc<Vec<(Scalar, Scalar)>>,
| ^^^^^^^^^
infra/src/types/operator/physical.rs|23 col 10| warning: enum PhysicalOperator is never used
--> infra/src/types/operator/physical.rs:23:10
|
23 | pub enum PhysicalOperator {
| ^^^^^^^^^^^^^^^^
infra/src/types/operator/physical.rs|30 col 12| warning: struct TableScanOperator is never constructed
--> infra/src/types/operator/physical.rs:30:12
|
30 | pub struct TableScanOperator {
| ^^^^^^^^^^^^^^^^^
infra/src/types/operator/physical.rs|36 col 12| warning: struct PhysicalFilterOperator is never constructed
--> infra/src/types/operator/physical.rs:36:12
|
36 | pub struct PhysicalFilterOperator {
| ^^^^^^^^^^^^^^^^^^^^^^
infra/src/types/operator/physical.rs|42 col 12| warning: struct HashJoinOperator is never constructed
--> infra/src/types/operator/physical.rs:42:12
|
42 | pub struct HashJoinOperator {
| ^^^^^^^^^^^^^^^^
infra/src/types/plan/logical_plan.rs|15 col 12| warning: field root is never read
--> infra/src/types/plan/logical_plan.rs:16:9
|
15 | pub struct LogicalPlan {
| ----------- field in this struct
16 | pub root: Arc<LogicalOperator>,
| ^^^^
|
= note: LogicalPlan has a derived impl for the trait Clone, but this is intentionally ignored during dead code analysis
infra/src/types/plan/logical_plan.rs|32 col 5| warning: field 0 is never read
--> infra/src/types/plan/logical_plan.rs:32:17
|
32 | LogicalNode(Arc<LogicalOperator>),
| ----------- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
| |
| field in this variant
|
= note: LogicalLink has a derived impl for the trait Clone, but this is intentionally ignored during dead code analysis
help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field
|
32 | LogicalNode(()),
| ~~
infra/src/types/plan/partial_logical_plan.rs|19 col 10| warning: enum PartialLogicalPlan is never used
--> infra/src/types/plan/partial_logical_plan.rs:19:10
|
19 | pub enum PartialLogicalPlan {
| ^^^^^^^^^^^^^^^^^^
|
= note: PartialLogicalPlan has a derived impl for the trait Clone, but this is intentionally ignored during dead code analysis
infra/src/types/plan/partial_logical_plan.rs|36 col 10| warning: enum LogicalLink is never used
--> infra/src/types/plan/partial_logical_plan.rs:36:10
|
36 | pub enum LogicalLink {
| ^^^^^^^^^^^
|
= note: LogicalLink has a derived impl for the trait Clone, but this is intentionally ignored during dead code analysis
infra/src/types/plan/physical_plan.rs|6 col 12| warning: struct PhysicalPlan is never constructed
--> infra/src/types/plan/physical_plan.rs:6:12
|
6 | pub struct PhysicalPlan {
| ^^^^^^^^^^^^
|
= note: PhysicalPlan has a derived impl for the trait Clone, but this is intentionally ignored during dead code analysis
infra/src/types/plan/physical_plan.rs|12 col 10| warning: enum PhysicalLink is never used
--> infra/src/types/plan/physical_plan.rs:12:10
|
12 | pub enum PhysicalLink {
| ^^^^^^^^^^^^
|
= note: PhysicalLink has a derived impl for the trait Clone, but this is intentionally ignored during dead code analysis
infra/src/lib.rs|160 col 13| warning: variable optdLogicalPlan should have a snake case name
--> infra/src/lib.rs:160:13
|
160 | let optdLogicalPlan = Self::get_optd_logical_plan(logical_plan);
| ^^^^^^^^^^^^^^^ help: convert the identifier to snake case: optd_logical_plan
|
= note: #[warn(non_snake_case)] on by default
infra/src/main.rs|4 col 41| warning: use of deprecated type alias datafusion::execution::runtime_env::RuntimeConfig: please use RuntimeEnvBuilder instead
--> infra/src/main.rs:4:41
|
4 | use datafusion::execution::runtime_env::RuntimeConfig;
| ^^^^^^^^^^^^^
|
= note: #[warn(deprecated)] on by default
infra/src/main.rs|15 col 21| warning: use of deprecated type alias datafusion::execution::runtime_env::RuntimeConfig: please use RuntimeEnvBuilder instead
--> infra/src/main.rs:15:21
|
15 | let rt_config = RuntimeConfig::new();
| ^^^^^^^^^^^^^

Filtered Findings (0)

Annotations

Check warning on line 9 in infra/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] infra/src/lib.rs#L9

warning: unused import: `std::collections::HashMap`
 --> infra/src/lib.rs:9:5
  |
9 | use std::collections::HashMap;
  |     ^^^^^^^^^^^^^^^^^^^^^^^^^
  |
  = note: `#[warn(unused_imports)]` on by default
Raw output
infra/src/lib.rs:9:5:w:warning: unused import: `std::collections::HashMap`
 --> infra/src/lib.rs:9:5
  |
9 | use std::collections::HashMap;
  |     ^^^^^^^^^^^^^^^^^^^^^^^^^
  |
  = note: `#[warn(unused_imports)]` on by default


__END__

Check warning on line 10 in infra/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] infra/src/lib.rs#L10

warning: unused import: `Mutex`
  --> infra/src/lib.rs:10:22
   |
10 | use std::sync::{Arc, Mutex};
   |                      ^^^^^
Raw output
infra/src/lib.rs:10:22:w:warning: unused import: `Mutex`
  --> infra/src/lib.rs:10:22
   |
10 | use std::sync::{Arc, Mutex};
   |                      ^^^^^


__END__

Check warning on line 18 in infra/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] infra/src/lib.rs#L18

warning: unused imports: `Explain`, `PlanType`, `TableSource`, and `ToStringifiedPlan`
  --> infra/src/lib.rs:18:32
   |
18 | use datafusion::logical_expr::{Explain, LogicalPlan, PlanType, TableSource, ToStringifiedPlan};
   |                                ^^^^^^^               ^^^^^^^^  ^^^^^^^^^^^  ^^^^^^^^^^^^^^^^^
Raw output
infra/src/lib.rs:18:32:w:warning: unused imports: `Explain`, `PlanType`, `TableSource`, and `ToStringifiedPlan`
  --> infra/src/lib.rs:18:32
   |
18 | use datafusion::logical_expr::{Explain, LogicalPlan, PlanType, TableSource, ToStringifiedPlan};
   |                                ^^^^^^^               ^^^^^^^^  ^^^^^^^^^^^  ^^^^^^^^^^^^^^^^^


__END__

Check warning on line 21 in infra/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] infra/src/lib.rs#L21

warning: unused import: `log`
  --> infra/src/lib.rs:21:27
   |
21 | use datafusion::prelude::{log, Expr, SessionConfig, SessionContext};
   |                           ^^^
Raw output
infra/src/lib.rs:21:27:w:warning: unused import: `log`
  --> infra/src/lib.rs:21:27
   |
21 | use datafusion::prelude::{log, Expr, SessionConfig, SessionContext};
   |                           ^^^


__END__

Check warning on line 65 in infra/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] infra/src/lib.rs#L65

warning: redundant field names in struct initialization
  --> infra/src/lib.rs:65:21
   |
65 |                     predicate: predicate,
   |                     ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `predicate`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
   = note: `#[warn(clippy::redundant_field_names)]` on by default
Raw output
infra/src/lib.rs:65:21:w:warning: redundant field names in struct initialization
  --> infra/src/lib.rs:65:21
   |
65 |                     predicate: predicate,
   |                     ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `predicate`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
   = note: `#[warn(clippy::redundant_field_names)]` on by default


__END__

Check warning on line 81 in infra/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] infra/src/lib.rs#L81

warning: redundant field names in struct initialization
  --> infra/src/lib.rs:81:25
   |
81 |                         condition: condition,
   |                         ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `condition`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
Raw output
infra/src/lib.rs:81:25:w:warning: redundant field names in struct initialization
  --> infra/src/lib.rs:81:25
   |
81 |                         condition: condition,
   |                         ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `condition`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names


__END__

Check warning on line 16 in infra/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] infra/src/lib.rs#L16

warning: use of deprecated type alias `datafusion::execution::runtime_env::RuntimeConfig`: please use `RuntimeEnvBuilder` instead
  --> infra/src/lib.rs:16:41
   |
16 | use datafusion::execution::runtime_env::RuntimeConfig;
   |                                         ^^^^^^^^^^^^^
   |
   = note: `#[warn(deprecated)]` on by default
Raw output
infra/src/lib.rs:16:41:w:warning: use of deprecated type alias `datafusion::execution::runtime_env::RuntimeConfig`: please use `RuntimeEnvBuilder` instead
  --> infra/src/lib.rs:16:41
   |
16 | use datafusion::execution::runtime_env::RuntimeConfig;
   |                                         ^^^^^^^^^^^^^
   |
   = note: `#[warn(deprecated)]` on by default


__END__

Check warning on line 201 in infra/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] infra/src/lib.rs#L201

warning: use of deprecated type alias `datafusion::execution::runtime_env::RuntimeConfig`: please use `RuntimeEnvBuilder` instead
   --> infra/src/lib.rs:201:23
    |
201 |     rn_config: Option<RuntimeConfig>,
    |                       ^^^^^^^^^^^^^
Raw output
infra/src/lib.rs:201:23:w:warning: use of deprecated type alias `datafusion::execution::runtime_env::RuntimeConfig`: please use `RuntimeEnvBuilder` instead
   --> infra/src/lib.rs:201:23
    |
201 |     rn_config: Option<RuntimeConfig>,
    |                       ^^^^^^^^^^^^^


__END__

Check warning on line 216 in infra/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] infra/src/lib.rs#L216

warning: use of deprecated type alias `datafusion::execution::runtime_env::RuntimeConfig`: please use `RuntimeEnvBuilder` instead
   --> infra/src/lib.rs:216:9
    |
216 |         RuntimeConfig::new()
    |         ^^^^^^^^^^^^^
Raw output
infra/src/lib.rs:216:9:w:warning: use of deprecated type alias `datafusion::execution::runtime_env::RuntimeConfig`: please use `RuntimeEnvBuilder` instead
   --> infra/src/lib.rs:216:9
    |
216 |         RuntimeConfig::new()
    |         ^^^^^^^^^^^^^


__END__

Check warning on line 160 in infra/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] infra/src/lib.rs#L160

warning: unused variable: `optdLogicalPlan`
   --> infra/src/lib.rs:160:13
    |
160 |         let optdLogicalPlan = Self::get_optd_logical_plan(logical_plan);
    |             ^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_optdLogicalPlan`
    |
    = note: `#[warn(unused_variables)]` on by default
Raw output
infra/src/lib.rs:160:13:w:warning: unused variable: `optdLogicalPlan`
   --> infra/src/lib.rs:160:13
    |
160 |         let optdLogicalPlan = Self::get_optd_logical_plan(logical_plan);
    |             ^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_optdLogicalPlan`
    |
    = note: `#[warn(unused_variables)]` on by default


__END__

Check warning on line 161 in infra/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] infra/src/lib.rs#L161

warning: unused variable: `optimizer`
   --> infra/src/lib.rs:161:17
    |
161 |         let mut optimizer = self.optimizer.clone();
    |                 ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_optimizer`
Raw output
infra/src/lib.rs:161:17:w:warning: unused variable: `optimizer`
   --> infra/src/lib.rs:161:17
    |
161 |         let mut optimizer = self.optimizer.clone();
    |                 ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_optimizer`


__END__

Check warning on line 161 in infra/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] infra/src/lib.rs#L161

warning: variable does not need to be mutable
   --> infra/src/lib.rs:161:13
    |
161 |         let mut optimizer = self.optimizer.clone();
    |             ----^^^^^^^^^
    |             |
    |             help: remove this `mut`
    |
    = note: `#[warn(unused_mut)]` on by default
Raw output
infra/src/lib.rs:161:13:w:warning: variable does not need to be mutable
   --> infra/src/lib.rs:161:13
    |
161 |         let mut optimizer = self.optimizer.clone();
    |             ----^^^^^^^^^
    |             |
    |             help: remove this `mut`
    |
    = note: `#[warn(unused_mut)]` on by default


__END__

Check warning on line 7 in infra/src/types/memo.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] infra/src/types/memo.rs#L7

warning: unused variable: `logical_expr`
 --> infra/src/types/memo.rs:7:38
  |
7 |     pub async fn add_expr(&mut self, logical_expr: Expr) -> (ExprId, GroupId) {
  |                                      ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_logical_expr`
Raw output
infra/src/types/memo.rs:7:38:w:warning: unused variable: `logical_expr`
 --> infra/src/types/memo.rs:7:38
  |
7 |     pub async fn add_expr(&mut self, logical_expr: Expr) -> (ExprId, GroupId) {
  |                                      ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_logical_expr`


__END__

Check warning on line 11 in infra/src/types/memo.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] infra/src/types/memo.rs#L11

warning: unused variable: `logical_expr`
  --> infra/src/types/memo.rs:11:47
   |
11 |     pub async fn add_expr_to_group(&mut self, logical_expr: Expr, group_id: GroupId) -> ExprId {
   |                                               ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_logical_expr`
Raw output
infra/src/types/memo.rs:11:47:w:warning: unused variable: `logical_expr`
  --> infra/src/types/memo.rs:11:47
   |
11 |     pub async fn add_expr_to_group(&mut self, logical_expr: Expr, group_id: GroupId) -> ExprId {
   |                                               ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_logical_expr`


__END__

Check warning on line 11 in infra/src/types/memo.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] infra/src/types/memo.rs#L11

warning: unused variable: `group_id`
  --> infra/src/types/memo.rs:11:67
   |
11 |     pub async fn add_expr_to_group(&mut self, logical_expr: Expr, group_id: GroupId) -> ExprId {
   |                                                                   ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_group_id`
Raw output
infra/src/types/memo.rs:11:67:w:warning: unused variable: `group_id`
  --> infra/src/types/memo.rs:11:67
   |
11 |     pub async fn add_expr_to_group(&mut self, logical_expr: Expr, group_id: GroupId) -> ExprId {
   |                                                                   ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_group_id`


__END__

Check warning on line 15 in infra/src/types/memo.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] infra/src/types/memo.rs#L15

warning: unused variable: `group_id`
  --> infra/src/types/memo.rs:15:45
   |
15 |     pub async fn get_group_exprs(&mut self, group_id: GroupId) -> Vec<(ExprId, Expr)> {
   |                                             ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_group_id`
Raw output
infra/src/types/memo.rs:15:45:w:warning: unused variable: `group_id`
  --> infra/src/types/memo.rs:15:45
   |
15 |     pub async fn get_group_exprs(&mut self, group_id: GroupId) -> Vec<(ExprId, Expr)> {
   |                                             ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_group_id`


__END__

Check warning on line 19 in infra/src/types/memo.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] infra/src/types/memo.rs#L19

warning: unused variable: `logical_expr_id`
  --> infra/src/types/memo.rs:19:44
   |
19 |     pub async fn get_expr_group(&mut self, logical_expr_id: ExprId) -> GroupId {
   |                                            ^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_logical_expr_id`
Raw output
infra/src/types/memo.rs:19:44:w:warning: unused variable: `logical_expr_id`
  --> infra/src/types/memo.rs:19:44
   |
19 |     pub async fn get_expr_group(&mut self, logical_expr_id: ExprId) -> GroupId {
   |                                            ^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_logical_expr_id`


__END__

Check warning on line 87 in infra/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] infra/src/lib.rs#L87

warning: unused variable: `logical_plan`
  --> infra/src/lib.rs:87:26
   |
87 |     pub fn mock_optimize(logical_plan: OptDLogicalPlan) -> PhysicalPlan {
   |                          ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_logical_plan`
Raw output
infra/src/lib.rs:87:26:w:warning: unused variable: `logical_plan`
  --> infra/src/lib.rs:87:26
   |
87 |     pub fn mock_optimize(logical_plan: OptDLogicalPlan) -> PhysicalPlan {
   |                          ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_logical_plan`


__END__

Check warning on line 97 in infra/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] infra/src/lib.rs#L97

warning: unused variable: `predicate_expr`
  --> infra/src/lib.rs:97:33
   |
97 |     fn convert_into_optd_scalar(predicate_expr: Expr) -> Scalar {
   |                                 ^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_predicate_expr`
Raw output
infra/src/lib.rs:97:33:w:warning: unused variable: `predicate_expr`
  --> infra/src/lib.rs:97:33
   |
97 |     fn convert_into_optd_scalar(predicate_expr: Expr) -> Scalar {
   |                                 ^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_predicate_expr`


__END__

Check warning on line 93 in infra/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] infra/src/lib.rs#L93

warning: type `OptdOptimizer` is more private than the item `OptdQueryPlanner::optimizer`
  --> infra/src/lib.rs:93:5
   |
93 |     pub optimizer: Arc<OptdOptimizer>,
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ field `OptdQueryPlanner::optimizer` is reachable at visibility `pub`
   |
note: but type `OptdOptimizer` is only usable at visibility `pub(crate)`
  --> infra/src/lib.rs:43:1
   |
43 | struct OptdOptimizer {}
   | ^^^^^^^^^^^^^^^^^^^^
   = note: `#[warn(private_interfaces)]` on by default
Raw output
infra/src/lib.rs:93:5:w:warning: type `OptdOptimizer` is more private than the item `OptdQueryPlanner::optimizer`
  --> infra/src/lib.rs:93:5
   |
93 |     pub optimizer: Arc<OptdOptimizer>,
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ field `OptdQueryPlanner::optimizer` is reachable at visibility `pub`
   |
note: but type `OptdOptimizer` is only usable at visibility `pub(crate)`
  --> infra/src/lib.rs:43:1
   |
43 | struct OptdOptimizer {}
   | ^^^^^^^^^^^^^^^^^^^^
   = note: `#[warn(private_interfaces)]` on by default


__END__

Check warning on line 172 in infra/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] infra/src/lib.rs#L172

warning: type `OptdOptimizer` is more private than the item `OptdQueryPlanner::new`
   --> infra/src/lib.rs:172:5
    |
172 |     pub fn new(optimizer: OptdOptimizer) -> Self {
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ associated function `OptdQueryPlanner::new` is reachable at visibility `pub`
    |
note: but type `OptdOptimizer` is only usable at visibility `pub(crate)`
   --> infra/src/lib.rs:43:1
    |
43  | struct OptdOptimizer {}
    | ^^^^^^^^^^^^^^^^^^^^
Raw output
infra/src/lib.rs:172:5:w:warning: type `OptdOptimizer` is more private than the item `OptdQueryPlanner::new`
   --> infra/src/lib.rs:172:5
    |
172 |     pub fn new(optimizer: OptdOptimizer) -> Self {
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ associated function `OptdQueryPlanner::new` is reachable at visibility `pub`
    |
note: but type `OptdOptimizer` is only usable at visibility `pub(crate)`
   --> infra/src/lib.rs:43:1
    |
43  | struct OptdOptimizer {}
    | ^^^^^^^^^^^^^^^^^^^^


__END__

Check warning on line 45 in infra/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] infra/src/lib.rs#L45

warning: associated functions `conv_logical_to_physical` and `mock_optimize` are never used
  --> infra/src/lib.rs:46:8
   |
45 | impl OptdOptimizer {
   | ------------------ associated functions in this implementation
46 |     fn conv_logical_to_physical(
   |        ^^^^^^^^^^^^^^^^^^^^^^^^
...
87 |     pub fn mock_optimize(logical_plan: OptDLogicalPlan) -> PhysicalPlan {
   |            ^^^^^^^^^^^^^
   |
   = note: `#[warn(dead_code)]` on by default
Raw output
infra/src/lib.rs:45:1:w:warning: associated functions `conv_logical_to_physical` and `mock_optimize` are never used
  --> infra/src/lib.rs:46:8
   |
45 | impl OptdOptimizer {
   | ------------------ associated functions in this implementation
46 |     fn conv_logical_to_physical(
   |        ^^^^^^^^^^^^^^^^^^^^^^^^
...
87 |     pub fn mock_optimize(logical_plan: OptDLogicalPlan) -> PhysicalPlan {
   |            ^^^^^^^^^^^^^
   |
   = note: `#[warn(dead_code)]` on by default


__END__

Check warning on line 5 in infra/src/types/expression/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] infra/src/types/expression/mod.rs#L5

warning: enum `Expr` is never used
 --> infra/src/types/expression/mod.rs:5:10
  |
5 | pub enum Expr {
  |          ^^^^
Raw output
infra/src/types/expression/mod.rs:5:10:w:warning: enum `Expr` is never used
 --> infra/src/types/expression/mod.rs:5:10
  |
5 | pub enum Expr {
  |          ^^^^


__END__

Check warning on line 5 in infra/src/types/expression/relational/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] infra/src/types/expression/relational/mod.rs#L5

warning: enum `RelationalExpr` is never used
 --> infra/src/types/expression/relational/mod.rs:5:10
  |
5 | pub enum RelationalExpr {
  |          ^^^^^^^^^^^^^^
Raw output
infra/src/types/expression/relational/mod.rs:5:10:w:warning: enum `RelationalExpr` is never used
 --> infra/src/types/expression/relational/mod.rs:5:10
  |
5 | pub enum RelationalExpr {
  |          ^^^^^^^^^^^^^^


__END__

Check warning on line 2 in infra/src/types/expression/relational/logical.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] infra/src/types/expression/relational/logical.rs#L2

warning: enum `LogicalExpr` is never used
 --> infra/src/types/expression/relational/logical.rs:2:10
  |
2 | pub enum LogicalExpr {
  |          ^^^^^^^^^^^
Raw output
infra/src/types/expression/relational/logical.rs:2:10:w:warning: enum `LogicalExpr` is never used
 --> infra/src/types/expression/relational/logical.rs:2:10
  |
2 | pub enum LogicalExpr {
  |          ^^^^^^^^^^^


__END__