Skip to content

first draft of an datafusion logical to optd logical plan conversion …

Sign in for the full log view
GitHub Actions / clippy failed Jan 28, 2025 in 1s

reviewdog [clippy] report

reported by reviewdog 🐶

Findings (74)

infra/src/lib.rs|8 col 5| warning: unused import: std::collections::HashMap
--> infra/src/lib.rs:8:5
|
8 | use std::collections::HashMap;
| ^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: #[warn(unused_imports)] on by default
infra/src/lib.rs|17 col 32| warning: unused imports: Explain, PlanType, TableSource, and ToStringifiedPlan
--> infra/src/lib.rs:17:32
|
17 | use datafusion::logical_expr::{Explain, LogicalPlan, PlanType, TableSource, ToStringifiedPlan};
| ^^^^^^^ ^^^^^^^^ ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^
infra/src/types/memo/implementation.rs|1 col 32| warning: unused import: relational::logical::LogicalExpr
--> infra/src/types/memo/implementation.rs:1:32
|
1 | use crate::types::expression::{relational::logical::LogicalExpr, Expr};
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
infra/src/types/memo/implementation.rs|2 col 5| warning: unused import: crate::types::plan::partial_logical_plan::PartialLogicalPlan
--> infra/src/types/memo/implementation.rs:2:5
|
2 | use crate::types::plan::partial_logical_plan::PartialLogicalPlan;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
infra/src/types/memo/implementation.rs|3 col 5| warning: unused import: crate::types::plan::partial_physical_plan::PartialPhysicalPlan
--> infra/src/types/memo/implementation.rs:3:5
|
3 | use crate::types::plan::partial_physical_plan::PartialPhysicalPlan;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
infra/src/types/operator/mod.rs|1 col 32| warning: unused import: sync::Arc
--> infra/src/types/operator/mod.rs:1:32
|
1 | use std::{marker::PhantomData, sync::Arc};
| ^^^^^^^^^
infra/src/types/plan/physical_plan.rs|2 col 5| warning: unused import: logical::LogicalOperator
--> infra/src/types/plan/physical_plan.rs:2:5
|
2 | logical::LogicalOperator,
| ^^^^^^^^^^^^^^^^^^^^^^^^
infra/src/lib.rs|36 col 46| warning: unused import: LogicalPlan as OptDLogicalPlan
--> infra/src/lib.rs:36:46
|
36 | use types::plan::logical_plan::{LogicalLink, LogicalPlan as OptDLogicalPlan, ScalarLink};
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
infra/src/lib.rs|64 col 17| warning: consider removing unnecessary double parentheses
--> infra/src/lib.rs:64:17
|
64 | / (LogicalJoinOperator {
65 | | join_type: (),
66 | | left: LogicalLink::LogicalNode(Self::convert_into_optd_logical(
67 | | join.left.clone(),
... |
72 | | condition: LogicalLink::ScalarNode(Arc::new(todo!())),
73 | | }),
| |^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens
= note: #[warn(clippy::double_parens)] on by default
infra/src/lib.rs|64 col 17| warning: unnecessary parentheses around function argument
--> infra/src/lib.rs:64:17
|
64 | (LogicalJoinOperator {
| ^
...
73 | }),
| ^
|
= note: #[warn(unused_parens)] on by default
help: remove these parentheses
|
64 ~ LogicalJoinOperator {
65 | join_type: (),
...
72 | condition: LogicalLink::ScalarNode(Arc::new(todo!())),
73 ~ },
|
infra/src/lib.rs|77 col 17| warning: consider removing unnecessary double parentheses
--> infra/src/lib.rs:77:17
|
77 | / (LogicalScanOperator {
78 | | table_name: table_scan.table_name.to_quoted_string(),
79 | | predicate: None, // TODO fix this: there are multiple predicates in the scan but our IR only accepts one
80 | | }),
| |
^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens
infra/src/lib.rs|77 col 17| warning: unnecessary parentheses around function argument
--> infra/src/lib.rs:77:17
|
77 | (LogicalScanOperator {
| ^
...
80 | }),
| ^
|
help: remove these parentheses
|
77 ~ LogicalScanOperator {
78 | table_name: table_scan.table_name.to_quoted_string(),
79 | predicate: None, // TODO fix this: there are multiple predicates in the scan but our IR only accepts one
80 ~ },
|
infra/src/lib.rs|15 col 41| warning: use of deprecated type alias datafusion::execution::runtime_env::RuntimeConfig: please use RuntimeEnvBuilder instead
--> infra/src/lib.rs:15:41
|
15 | use datafusion::execution::runtime_env::RuntimeConfig;
| ^^^^^^^^^^^^^
|
= note: #[warn(deprecated)] on by default
infra/src/lib.rs|143 col 23| warning: use of deprecated type alias datafusion::execution::runtime_env::RuntimeConfig: please use RuntimeEnvBuilder instead
--> infra/src/lib.rs:143:23
|
143 | rn_config: Option,
| ^^^^^^^^^^^^^
infra/src/lib.rs|158 col 9| warning: use of deprecated type alias datafusion::execution::runtime_env::RuntimeConfig: please use RuntimeEnvBuilder instead
--> infra/src/lib.rs:158:9
|
158 | RuntimeConfig::new()
| ^^^^^^^^^^^^^
infra/src/lib.rs|103 col 17| warning: unused variable: optimizer
--> infra/src/lib.rs:103:17
|
103 | let mut optimizer = self.optimizer.lock().unwrap().take().unwrap();
| ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: _optimizer
|
= note: #[warn(unused_variables)] on by default
infra/src/lib.rs|103 col 13| warning: variable does not need to be mutable
--> infra/src/lib.rs:103:13
|
103 | let mut optimizer = self.optimizer.lock().unwrap().take().unwrap();
| ----^^^^^^^^^
| |
| help: remove this mut
|
= note: #[warn(unused_mut)] on by default
infra/src/types/memo/implementation.rs|9 col 38| warning: unused variable: logical_expr
--> infra/src/types/memo/implementation.rs:9:38
|
9 | pub async fn add_expr(&mut self, logical_expr: Expr) -> (ExprId, GroupId) {
| ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: _logical_expr
infra/src/types/memo/implementation.rs|13 col 47| warning: unused variable: logical_expr
--> infra/src/types/memo/implementation.rs:13:47
|
13 | pub async fn add_expr_to_group(&mut self, logical_expr: Expr, group_id: GroupId) -> ExprId {
| ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: _logical_expr
infra/src/types/memo/implementation.rs|13 col 67| warning: unused variable: group_id
--> infra/src/types/memo/implementation.rs:13:67
|
13 | pub async fn add_expr_to_group(&mut self, logical_expr: Expr, group_id: GroupId) -> ExprId {
| ^^^^^^^^ help: if this is intentional, prefix it with an underscore: _group_id
infra/src/types/memo/implementation.rs|17 col 45| warning: unused variable: group_id
--> infra/src/types/memo/implementation.rs:17:45
|
17 | pub async fn get_group_exprs(&mut self, group_id: GroupId) -> Vec<(ExprId, Expr)> {
| ^^^^^^^^ help: if this is intentional, prefix it with an underscore: _group_id
infra/src/types/memo/implementation.rs|21 col 44| warning: unused variable: logical_expr_id
--> infra/src/types/memo/implementation.rs:21:44
|
21 | pub async fn get_expr_group(&mut self, logical_expr_id: ExprId) -> GroupId {
| ^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: _logical_expr_id
infra/src/lib.rs|72 col 56| warning: unreachable call
--> infra/src/lib.rs:72:56
|
72 | condition: LogicalLink::ScalarNode(Arc::new(todo!())),
| ^^^^^^^^ ------- any code following this expression is unreachable
| |
| unreachable call
|
= note: #[warn(unreachable_code)] on by default
infra/src/types/plan/physical_plan.rs|50 col 17| warning: unused variable: table_name
--> infra/src/types/plan/physical_plan.rs:50:17
|
50 | table_name,
| ^^^^^^^^^^ help: try ignoring the field: table_name: _
infra/src/types/plan/physical_plan.rs|51 col 17| warning: unused variable: predicate
--> infra/src/types/plan/physical_plan.rs:51:17
|
51 | predicate,
| ^^^^^^^^^ help: try ignoring the field: predicate: _
infra/src/types/plan/physical_plan.rs|59 col 70| warning: unused variable: predicate
--> infra/src/types/plan/physical_plan.rs:59:70
|
59 | PhysicalOperator::Filter(PhysicalFilterOperator { child, predicate }) => {
| ^^^^^^^^^ help: try ignoring the field: predicate: _
infra/src/types/plan/physical_plan.rs|70 col 17| warning: unused variable: join_type
--> infra/src/types/plan/physical_plan.rs:70:17
|
70 | join_type,
| ^^^^^^^^^ help: try ignoring the field: join_type: _
infra/src/types/plan/physical_plan.rs|73 col 17| warning: unused variable: condition
--> infra/src/types/plan/physical_plan.rs:73:17
|
73 | condition,
| ^^^^^^^^^ help: try ignoring the field: condition: _
infra/src/lib.rs|45 col 33| warning: unused variable: predicate_expr
--> infra/src/lib.rs:45:33
|
45 | fn convert_into_optd_scalar(predicate_expr: Expr) -> Arc<ScalarOperator> {
| ^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: _predicate_expr
infra/src/lib.rs|41 col 5| warning: type OptdOptimizer is more private than the item OptdQueryPlanner::optimizer
--> infra/src/lib.rs:41:5
|
41 | pub optimizer: Arc<Mutex<Option<Box>>>,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ field OptdQueryPlanner::optimizer is reachable at visibility pub
|
note: but type OptdOptimizer is only usable at visibility pub(crate)
--> infra/src/lib.rs:38:1
|
38 | struct OptdOptimizer {}
| ^^^^^^^^^^^^^^^^^^^^
= note: #[warn(private_interfaces)] on by default
infra/src/lib.rs|114 col 5| warning: type OptdOptimizer is more private than the item OptdQueryPlanner::new
--> infra/src/lib.rs:114:5
|
114 | pub fn new(optimizer: OptdOptimizer) -> Self {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ associated function OptdQueryPlanner::new is reachable at visibility pub
|
note: but type OptdOptimizer is only usable at visibility pub(crate)
--> infra/src/lib.rs:38:1
|
38 | struct OptdOptimizer {}
| ^^^^^^^^^^^^^^^^^^^^
infra/src/lib.rs|44 col 1| warning: associated functions convert_into_optd_scalar and convert_into_optd_logical are never used
--> infra/src/lib.rs:45:8
|
44 | impl OptdQueryPlanner {
| --------------------- associated functions in this implementation
45 | fn convert_into_optd_scalar(predicate_expr: Expr) -> Arc<ScalarOperator> {
| ^^^^^^^^^^^^^^^^^^^^^^^^
...
50 | fn convert_into_optd_logical(plan_node: Arc) -> Arc<LogicalOperator> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: #[warn(dead_code)] on by default
infra/src/types/expression/mod.rs|5 col 10| warning: enum Expr is never used
--> infra/src/types/expression/mod.rs:5:10
|
5 | pub enum Expr {
| ^^^^
infra/src/types/expression/relational/mod.rs|5 col 10| warning: enum RelationalExpr is never used
--> infra/src/types/expression/relational/mod.rs:5:10
|
5 | pub enum RelationalExpr {
| ^^^^^^^^^^^^^^
infra/src/types/expression/relational/logical.rs|2 col 10| warning: enum LogicalExpr is never used
--> infra/src/types/expression/relational/logical.rs:2:10
|
2 | pub enum LogicalExpr {
| ^^^^^^^^^^^
infra/src/types/expression/relational/logical.rs|8 col 12| warning: struct LogicalScanExpr is never constructed
--> infra/src/types/expression/relational/logical.rs:8:12
|
8 | pub struct LogicalScanExpr;
| ^^^^^^^^^^^^^^^
infra/src/types/expression/relational/logical.rs|10 col 12| warning: struct LogicalFilterExpr is never constructed
--> infra/src/types/expression/relational/logical.rs:10:12
|
10 | pub struct LogicalFilterExpr;
| ^^^^^^^^^^^^^^^^^
infra/src/types/expression/relational/logical.rs|12 col 12| warning: struct LogicalJoinExpr is never constructed
--> infra/src/types/expression/relational/logical.rs:12:12
|
12 | pub struct LogicalJoinExpr;
| ^^^^^^^^^^^^^^^
infra/src/types/expression/relational/physical.rs|2 col 10| warning: enum PhysicalExpr is never used
--> infra/src/types/expression/relational/physical.rs:2:10
|
2 | pub enum PhysicalExpr {
| ^^^^^^^^^^^^
infra/src/types/expression/relational/physical.rs|8 col 12| warning: struct TableScanExpr is never constructed
--> infra/src/types/expression/relational/physical.rs:8:12
|
8 | pub struct TableScanExpr;
| ^^^^^^^^^^^^^
infra/src/types/expression/relational/physical.rs|10 col 12| warning: struct PhysicalFilterExpr is never constructed
--> infra/src/types/expression/relational/physical.rs:10:12
|
10 | pub struct PhysicalFilterExpr;
| ^^^^^^^^^^^^^^^^^^
infra/src/types/expression/relational/physical.rs|12 col 12| warning: struct HashJoinExpr is never constructed
--> infra/src/types/expression/relational/physical.rs:12:12
|
12 | pub struct HashJoinExpr;
| ^^^^^^^^^^^^
infra/src/types/expression/scalar.rs|4 col 12| warning: struct ScalarExpr is never constructed
--> infra/src/types/expression/scalar.rs:4:12
|
4 | pub struct ScalarExpr;
| ^^^^^^^^^^
infra/src/types/memo/mod.rs|3 col 12| warning: struct Memo is never constructed
--> infra/src/types/memo/mod.rs:3:12
|
3 | pub struct Memo;
| ^^^^
infra/src/types/memo/rule.rs|10 col 11| warning: trait TransformationRule is never used
--> infra/src/types/memo/rule.rs:10:11
|
10 | pub trait TransformationRule {
| ^^^^^^^^^^^^^^^^^^
infra/src/types/memo/rule.rs|36 col 11| warning: trait ImplementationRule is never used
--> infra/src/types/memo/rule.rs:36:11
|
36 | pub trait ImplementationRule {
| ^^^^^^^^^^^^^^^^^^
infra/src/types/memo/implementation.rs|8 col 1| warning: methods add_expr, add_expr_to_group, get_group_exprs, get_expr_group, and create_new_group are never used
--> infra/src/types/memo/implementation.rs:9:18
|
8 | impl Memo {
| --------- methods in this implementation
9 | pub async fn add_expr(&mut self, logical_expr: Expr) -> (ExprId, GroupId) {
| ^^^^^^^^
...
13 | pub async fn add_expr_to_group(&mut self, logical_expr: Expr, group_id: GroupId) -> ExprId {
| ^^^^^^^^^^^^^^^^^
...
17 | pub async fn get_group_exprs(&mut self, group_id: GroupId) -> Vec<(ExprId, Expr)> {
| ^^^^^^^^^^^^^^^
...
21 | pub async fn get_expr_group(&mut self, logical_expr_id: ExprId) -> GroupId {
| ^^^^^^^^^^^^^^
...
25 | pub async fn create_new_group(&mut self) -> GroupId {
| ^^^^^^^^^^^^^^^^
infra/src/types/operator/mod.rs|12 col 12| warning: struct ScalarOperator is never constructed
--> infra/src/types/operator/mod.rs:12:12
|
12 | pub struct ScalarOperator {
| ^^^^^^^^^^^^^^
infra/src/types/operator/mod.rs|16 col 1| warning: associated function new is never used
--> infra/src/types/operator/mod.rs:18:12
|
16 | impl ScalarOperator {
| ------------------------------- associated function in this implementation
17 | // Add a public constructor
18 | pub fn new() -> Self {
| ^^^
infra/src/types/operator/logical.rs|19 col 10| warning: enum LogicalOperator is never used
--> infra/src/types/operator/logical.rs:19:10
|
19 | pub enum LogicalOperator {
| ^^^^^^^^^^^^^^^
infra/src/types/operator/logical.rs|26 col 12| warning: struct LogicalScanOperator is never constructed
--> infra/src/types/operator/logical.rs:26:12
|
26 | pub struct LogicalScanOperator {
| ^^^^^^^^^^^^^^^^^^^
infra/src/types/operator/logical.rs|32 col 12| warning: struct LogicalFilterOperator is never constructed
--> infra/src/types/operator/logical.rs:32:12
|
32 | pub struct LogicalFilterOperator {
| ^^^^^^^^^^^^^^^^^^^^^
infra/src/types/operator/logical.rs|38 col 12| warning: struct LogicalJoinOperator is never constructed
--> infra/src/types/operator/logical.rs:38:12
|
38 | pub struct LogicalJoinOperator {
| ^^^^^^^^^^^^^^^^^^^
infra/src/types/operator/physical.rs|20 col 10| warning: enum PhysicalOperator is never used
--> infra/src/types/operator/physical.rs:20:10
|
20 | pub enum PhysicalOperator {
| ^^^^^^^^^^^^^^^^
infra/src/types/operator/physical.rs|27 col 12| warning: struct TableScanOperator is never constructed
--> infra/src/types/operator/physical.rs:27:12
|
27 | pub struct TableScanOperator {
| ^^^^^^^^^^^^^^^^^
infra/src/types/operator/physical.rs|33 col 12| warning: struct PhysicalFilterOperator is never constructed
--> infra/src/types/operator/physical.rs:33:12
|
33 | pub struct PhysicalFilterOperator {
| ^^^^^^^^^^^^^^^^^^^^^^
infra/src/types/operator/physical.rs|39 col 12| warning: struct HashJoinOperator is never constructed
--> infra/src/types/operator/physical.rs:39:12
|
39 | pub struct HashJoinOperator {
| ^^^^^^^^^^^^^^^^
infra/src/types/plan/logical_plan.rs|15 col 12| warning: struct LogicalPlan is never constructed
--> infra/src/types/plan/logical_plan.rs:15:12
|
15 | pub struct LogicalPlan {
| ^^^^^^^^^^^
|
= note: LogicalPlan has a derived impl for the trait Clone, but this is intentionally ignored during dead code analysis
infra/src/types/plan/logical_plan.rs|41 col 10| warning: enum LogicalLink is never used
--> infra/src/types/plan/logical_plan.rs:41:10
|
41 | pub enum LogicalLink {
| ^^^^^^^^^^^
|
= note: LogicalLink has a derived impl for the trait Clone, but this is intentionally ignored during dead code analysis
infra/src/types/plan/logical_plan.rs|54 col 10| warning: enum ScalarLink is never used
--> infra/src/types/plan/logical_plan.rs:54:10
|
54 | pub enum ScalarLink {
| ^^^^^^^^^^
|
= note: ScalarLink has a derived impl for the trait Clone, but this is intentionally ignored during dead code analysis
infra/src/types/plan/partial_logical_plan.rs|19 col 10| warning: enum PartialLogicalPlan is never used
--> infra/src/types/plan/partial_logical_plan.rs:19:10
|
19 | pub enum PartialLogicalPlan {
| ^^^^^^^^^^^^^^^^^^
|
= note: PartialLogicalPlan has a derived impl for the trait Clone, but this is intentionally ignored during dead code analysis
infra/src/types/plan/partial_logical_plan.rs|49 col 10| warning: enum LogicalLink is never used
--> infra/src/types/plan/partial_logical_plan.rs:49:10
|
49 | pub enum LogicalLink {
| ^^^^^^^^^^^
|
= note: LogicalLink has a derived impl for the trait Clone, but this is intentionally ignored during dead code analysis
infra/src/types/plan/partial_logical_plan.rs|65 col 10| warning: enum ScalarLink is never used
--> infra/src/types/plan/partial_logical_plan.rs:65:10
|
65 | pub enum ScalarLink {
| ^^^^^^^^^^
|
= note: ScalarLink has a derived impl for the trait Clone, but this is intentionally ignored during dead code analysis
infra/src/types/plan/partial_physical_plan.rs|9 col 10| warning: enum PartialPhysicalPlan is never used
--> infra/src/types/plan/partial_physical_plan.rs:9:10
|
9 | pub enum PartialPhysicalPlan {
| ^^^^^^^^^^^^^^^^^^^
|
= note: PartialPhysicalPlan has a derived impl for the trait Clone, but this is intentionally ignored during dead code analysis
infra/src/types/plan/partial_physical_plan.rs|16 col 10| warning: enum LogicalLink is never used
--> infra/src/types/plan/partial_physical_plan.rs:16:10
|
16 | pub enum LogicalLink {
| ^^^^^^^^^^^
|
= note: LogicalLink has a derived impl for the trait Clone, but this is intentionally ignored during dead code analysis
infra/src/types/plan/partial_physical_plan.rs|25 col 10| warning: enum PhysicalLink is never used
--> infra/src/types/plan/partial_physical_plan.rs:25:10
|
25 | pub enum PhysicalLink {
| ^^^^^^^^^^^^
|
= note: PhysicalLink has a derived impl for the trait Clone, but this is intentionally ignored during dead code analysis
infra/src/types/plan/partial_physical_plan.rs|33 col 10| warning: enum ScalarLink is never used
--> infra/src/types/plan/partial_physical_plan.rs:33:10
|
33 | pub enum ScalarLink {
| ^^^^^^^^^^
|
= note: ScalarLink has a derived impl for the trait Clone, but this is intentionally ignored during dead code analysis
infra/src/types/plan/physical_plan.rs|21 col 12| warning: struct PhysicalPlan is never constructed
--> infra/src/types/plan/physical_plan.rs:21:12
|
21 | pub struct PhysicalPlan {
| ^^^^^^^^^^^^
|
= note: PhysicalPlan has a derived impl for the trait Clone, but this is intentionally ignored during dead code analysis
infra/src/types/plan/physical_plan.rs|26 col 1| warning: method as_datafusion_execution_plan is never used
--> infra/src/types/plan/physical_plan.rs:27:8
|
26 | impl PhysicalPlan {
| ----------------- method in this implementation
27 | fn as_datafusion_execution_plan(&self) -> Arc {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
infra/src/types/plan/physical_plan.rs|34 col 10| warning: enum PhysicalLink is never used
--> infra/src/types/plan/physical_plan.rs:34:10
|
34 | pub enum PhysicalLink {
| ^^^^^^^^^^^^
|
= note: PhysicalLink has a derived impl for the trait Clone, but this is intentionally ignored during dead code analysis
infra/src/types/plan/physical_plan.rs|41 col 10| warning: enum ScalarLink is never used
--> infra/src/types/plan/physical_plan.rs:41:10
|
41 | pub enum ScalarLink {
| ^^^^^^^^^^
|
= note: ScalarLink has a derived impl for the trait Clone, but this is intentionally ignored during dead code analysis
infra/src/types/plan/physical_plan.rs|46 col 1| warning: method as_datafusion_execution_plan is never used
--> infra/src/types/plan/physical_plan.rs:47:8
|
46 | impl PhysicalOperator {
| ----------------------------------- method in this implementation
47 | fn as_datafusion_execution_plan(&self) -> Arc {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
infra/src/main.rs|4 col 41| warning: use of deprecated type alias datafusion::execution::runtime_env::RuntimeConfig: please use RuntimeEnvBuilder instead
--> infra/src/main.rs:4:41
|
4 | use datafusion::execution::runtime_env::RuntimeConfig;
| ^^^^^^^^^^^^^
|
= note: #[warn(deprecated)] on by default
infra/src/main.rs|15 col 21| warning: use of deprecated type alias datafusion::execution::runtime_env::RuntimeConfig: please use RuntimeEnvBuilder instead
--> infra/src/main.rs:15:21
|
15 | let rt_config = RuntimeConfig::new();
| ^^^^^^^^^^^^^

Filtered Findings (0)

Annotations

Check warning on line 8 in infra/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] infra/src/lib.rs#L8

warning: unused import: `std::collections::HashMap`
 --> infra/src/lib.rs:8:5
  |
8 | use std::collections::HashMap;
  |     ^^^^^^^^^^^^^^^^^^^^^^^^^
  |
  = note: `#[warn(unused_imports)]` on by default
Raw output
infra/src/lib.rs:8:5:w:warning: unused import: `std::collections::HashMap`
 --> infra/src/lib.rs:8:5
  |
8 | use std::collections::HashMap;
  |     ^^^^^^^^^^^^^^^^^^^^^^^^^
  |
  = note: `#[warn(unused_imports)]` on by default


__END__

Check warning on line 17 in infra/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] infra/src/lib.rs#L17

warning: unused imports: `Explain`, `PlanType`, `TableSource`, and `ToStringifiedPlan`
  --> infra/src/lib.rs:17:32
   |
17 | use datafusion::logical_expr::{Explain, LogicalPlan, PlanType, TableSource, ToStringifiedPlan};
   |                                ^^^^^^^               ^^^^^^^^  ^^^^^^^^^^^  ^^^^^^^^^^^^^^^^^
Raw output
infra/src/lib.rs:17:32:w:warning: unused imports: `Explain`, `PlanType`, `TableSource`, and `ToStringifiedPlan`
  --> infra/src/lib.rs:17:32
   |
17 | use datafusion::logical_expr::{Explain, LogicalPlan, PlanType, TableSource, ToStringifiedPlan};
   |                                ^^^^^^^               ^^^^^^^^  ^^^^^^^^^^^  ^^^^^^^^^^^^^^^^^


__END__

Check warning on line 1 in infra/src/types/memo/implementation.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] infra/src/types/memo/implementation.rs#L1

warning: unused import: `relational::logical::LogicalExpr`
 --> infra/src/types/memo/implementation.rs:1:32
  |
1 | use crate::types::expression::{relational::logical::LogicalExpr, Expr};
  |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Raw output
infra/src/types/memo/implementation.rs:1:32:w:warning: unused import: `relational::logical::LogicalExpr`
 --> infra/src/types/memo/implementation.rs:1:32
  |
1 | use crate::types::expression::{relational::logical::LogicalExpr, Expr};
  |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^


__END__

Check warning on line 2 in infra/src/types/memo/implementation.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] infra/src/types/memo/implementation.rs#L2

warning: unused import: `crate::types::plan::partial_logical_plan::PartialLogicalPlan`
 --> infra/src/types/memo/implementation.rs:2:5
  |
2 | use crate::types::plan::partial_logical_plan::PartialLogicalPlan;
  |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Raw output
infra/src/types/memo/implementation.rs:2:5:w:warning: unused import: `crate::types::plan::partial_logical_plan::PartialLogicalPlan`
 --> infra/src/types/memo/implementation.rs:2:5
  |
2 | use crate::types::plan::partial_logical_plan::PartialLogicalPlan;
  |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^


__END__

Check warning on line 3 in infra/src/types/memo/implementation.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] infra/src/types/memo/implementation.rs#L3

warning: unused import: `crate::types::plan::partial_physical_plan::PartialPhysicalPlan`
 --> infra/src/types/memo/implementation.rs:3:5
  |
3 | use crate::types::plan::partial_physical_plan::PartialPhysicalPlan;
  |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Raw output
infra/src/types/memo/implementation.rs:3:5:w:warning: unused import: `crate::types::plan::partial_physical_plan::PartialPhysicalPlan`
 --> infra/src/types/memo/implementation.rs:3:5
  |
3 | use crate::types::plan::partial_physical_plan::PartialPhysicalPlan;
  |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^


__END__

Check warning on line 1 in infra/src/types/operator/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] infra/src/types/operator/mod.rs#L1

warning: unused import: `sync::Arc`
 --> infra/src/types/operator/mod.rs:1:32
  |
1 | use std::{marker::PhantomData, sync::Arc};
  |                                ^^^^^^^^^
Raw output
infra/src/types/operator/mod.rs:1:32:w:warning: unused import: `sync::Arc`
 --> infra/src/types/operator/mod.rs:1:32
  |
1 | use std::{marker::PhantomData, sync::Arc};
  |                                ^^^^^^^^^


__END__

Check warning on line 2 in infra/src/types/plan/physical_plan.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] infra/src/types/plan/physical_plan.rs#L2

warning: unused import: `logical::LogicalOperator`
 --> infra/src/types/plan/physical_plan.rs:2:5
  |
2 |     logical::LogicalOperator,
  |     ^^^^^^^^^^^^^^^^^^^^^^^^
Raw output
infra/src/types/plan/physical_plan.rs:2:5:w:warning: unused import: `logical::LogicalOperator`
 --> infra/src/types/plan/physical_plan.rs:2:5
  |
2 |     logical::LogicalOperator,
  |     ^^^^^^^^^^^^^^^^^^^^^^^^


__END__

Check warning on line 36 in infra/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] infra/src/lib.rs#L36

warning: unused import: `LogicalPlan as OptDLogicalPlan`
  --> infra/src/lib.rs:36:46
   |
36 | use types::plan::logical_plan::{LogicalLink, LogicalPlan as OptDLogicalPlan, ScalarLink};
   |                                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Raw output
infra/src/lib.rs:36:46:w:warning: unused import: `LogicalPlan as OptDLogicalPlan`
  --> infra/src/lib.rs:36:46
   |
36 | use types::plan::logical_plan::{LogicalLink, LogicalPlan as OptDLogicalPlan, ScalarLink};
   |                                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^


__END__

Check warning on line 64 in infra/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] infra/src/lib.rs#L64

warning: consider removing unnecessary double parentheses
  --> infra/src/lib.rs:64:17
   |
64 | /                 (LogicalJoinOperator {
65 | |                     join_type: (),
66 | |                     left: LogicalLink::LogicalNode(Self::convert_into_optd_logical(
67 | |                         join.left.clone(),
...  |
72 | |                     condition: LogicalLink::ScalarNode(Arc::new(todo!())),
73 | |                 }),
   | |__________________^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens
   = note: `#[warn(clippy::double_parens)]` on by default
Raw output
infra/src/lib.rs:64:17:w:warning: consider removing unnecessary double parentheses
  --> infra/src/lib.rs:64:17
   |
64 | /                 (LogicalJoinOperator {
65 | |                     join_type: (),
66 | |                     left: LogicalLink::LogicalNode(Self::convert_into_optd_logical(
67 | |                         join.left.clone(),
...  |
72 | |                     condition: LogicalLink::ScalarNode(Arc::new(todo!())),
73 | |                 }),
   | |__________________^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens
   = note: `#[warn(clippy::double_parens)]` on by default


__END__

Check warning on line 64 in infra/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] infra/src/lib.rs#L64

warning: unnecessary parentheses around function argument
  --> infra/src/lib.rs:64:17
   |
64 |                 (LogicalJoinOperator {
   |                 ^
...
73 |                 }),
   |                  ^
   |
   = note: `#[warn(unused_parens)]` on by default
help: remove these parentheses
   |
64 ~                 LogicalJoinOperator {
65 |                     join_type: (),
...
72 |                     condition: LogicalLink::ScalarNode(Arc::new(todo!())),
73 ~                 },
   |
Raw output
infra/src/lib.rs:64:17:w:warning: unnecessary parentheses around function argument
  --> infra/src/lib.rs:64:17
   |
64 |                 (LogicalJoinOperator {
   |                 ^
...
73 |                 }),
   |                  ^
   |
   = note: `#[warn(unused_parens)]` on by default
help: remove these parentheses
   |
64 ~                 LogicalJoinOperator {
65 |                     join_type: (),
...
72 |                     condition: LogicalLink::ScalarNode(Arc::new(todo!())),
73 ~                 },
   |


__END__

Check warning on line 77 in infra/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] infra/src/lib.rs#L77

warning: consider removing unnecessary double parentheses
  --> infra/src/lib.rs:77:17
   |
77 | /                 (LogicalScanOperator {
78 | |                     table_name: table_scan.table_name.to_quoted_string(),
79 | |                     predicate: None, // TODO fix this: there are multiple predicates in the scan but our IR only accepts one
80 | |                 }),
   | |__________________^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens
Raw output
infra/src/lib.rs:77:17:w:warning: consider removing unnecessary double parentheses
  --> infra/src/lib.rs:77:17
   |
77 | /                 (LogicalScanOperator {
78 | |                     table_name: table_scan.table_name.to_quoted_string(),
79 | |                     predicate: None, // TODO fix this: there are multiple predicates in the scan but our IR only accepts one
80 | |                 }),
   | |__________________^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens


__END__

Check warning on line 77 in infra/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] infra/src/lib.rs#L77

warning: unnecessary parentheses around function argument
  --> infra/src/lib.rs:77:17
   |
77 |                 (LogicalScanOperator {
   |                 ^
...
80 |                 }),
   |                  ^
   |
help: remove these parentheses
   |
77 ~                 LogicalScanOperator {
78 |                     table_name: table_scan.table_name.to_quoted_string(),
79 |                     predicate: None, // TODO fix this: there are multiple predicates in the scan but our IR only accepts one
80 ~                 },
   |
Raw output
infra/src/lib.rs:77:17:w:warning: unnecessary parentheses around function argument
  --> infra/src/lib.rs:77:17
   |
77 |                 (LogicalScanOperator {
   |                 ^
...
80 |                 }),
   |                  ^
   |
help: remove these parentheses
   |
77 ~                 LogicalScanOperator {
78 |                     table_name: table_scan.table_name.to_quoted_string(),
79 |                     predicate: None, // TODO fix this: there are multiple predicates in the scan but our IR only accepts one
80 ~                 },
   |


__END__

Check warning on line 15 in infra/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] infra/src/lib.rs#L15

warning: use of deprecated type alias `datafusion::execution::runtime_env::RuntimeConfig`: please use `RuntimeEnvBuilder` instead
  --> infra/src/lib.rs:15:41
   |
15 | use datafusion::execution::runtime_env::RuntimeConfig;
   |                                         ^^^^^^^^^^^^^
   |
   = note: `#[warn(deprecated)]` on by default
Raw output
infra/src/lib.rs:15:41:w:warning: use of deprecated type alias `datafusion::execution::runtime_env::RuntimeConfig`: please use `RuntimeEnvBuilder` instead
  --> infra/src/lib.rs:15:41
   |
15 | use datafusion::execution::runtime_env::RuntimeConfig;
   |                                         ^^^^^^^^^^^^^
   |
   = note: `#[warn(deprecated)]` on by default


__END__

Check warning on line 143 in infra/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] infra/src/lib.rs#L143

warning: use of deprecated type alias `datafusion::execution::runtime_env::RuntimeConfig`: please use `RuntimeEnvBuilder` instead
   --> infra/src/lib.rs:143:23
    |
143 |     rn_config: Option<RuntimeConfig>,
    |                       ^^^^^^^^^^^^^
Raw output
infra/src/lib.rs:143:23:w:warning: use of deprecated type alias `datafusion::execution::runtime_env::RuntimeConfig`: please use `RuntimeEnvBuilder` instead
   --> infra/src/lib.rs:143:23
    |
143 |     rn_config: Option<RuntimeConfig>,
    |                       ^^^^^^^^^^^^^


__END__

Check warning on line 158 in infra/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] infra/src/lib.rs#L158

warning: use of deprecated type alias `datafusion::execution::runtime_env::RuntimeConfig`: please use `RuntimeEnvBuilder` instead
   --> infra/src/lib.rs:158:9
    |
158 |         RuntimeConfig::new()
    |         ^^^^^^^^^^^^^
Raw output
infra/src/lib.rs:158:9:w:warning: use of deprecated type alias `datafusion::execution::runtime_env::RuntimeConfig`: please use `RuntimeEnvBuilder` instead
   --> infra/src/lib.rs:158:9
    |
158 |         RuntimeConfig::new()
    |         ^^^^^^^^^^^^^


__END__

Check warning on line 103 in infra/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] infra/src/lib.rs#L103

warning: unused variable: `optimizer`
   --> infra/src/lib.rs:103:17
    |
103 |         let mut optimizer = self.optimizer.lock().unwrap().take().unwrap();
    |                 ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_optimizer`
    |
    = note: `#[warn(unused_variables)]` on by default
Raw output
infra/src/lib.rs:103:17:w:warning: unused variable: `optimizer`
   --> infra/src/lib.rs:103:17
    |
103 |         let mut optimizer = self.optimizer.lock().unwrap().take().unwrap();
    |                 ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_optimizer`
    |
    = note: `#[warn(unused_variables)]` on by default


__END__

Check warning on line 103 in infra/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] infra/src/lib.rs#L103

warning: variable does not need to be mutable
   --> infra/src/lib.rs:103:13
    |
103 |         let mut optimizer = self.optimizer.lock().unwrap().take().unwrap();
    |             ----^^^^^^^^^
    |             |
    |             help: remove this `mut`
    |
    = note: `#[warn(unused_mut)]` on by default
Raw output
infra/src/lib.rs:103:13:w:warning: variable does not need to be mutable
   --> infra/src/lib.rs:103:13
    |
103 |         let mut optimizer = self.optimizer.lock().unwrap().take().unwrap();
    |             ----^^^^^^^^^
    |             |
    |             help: remove this `mut`
    |
    = note: `#[warn(unused_mut)]` on by default


__END__

Check warning on line 9 in infra/src/types/memo/implementation.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] infra/src/types/memo/implementation.rs#L9

warning: unused variable: `logical_expr`
 --> infra/src/types/memo/implementation.rs:9:38
  |
9 |     pub async fn add_expr(&mut self, logical_expr: Expr) -> (ExprId, GroupId) {
  |                                      ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_logical_expr`
Raw output
infra/src/types/memo/implementation.rs:9:38:w:warning: unused variable: `logical_expr`
 --> infra/src/types/memo/implementation.rs:9:38
  |
9 |     pub async fn add_expr(&mut self, logical_expr: Expr) -> (ExprId, GroupId) {
  |                                      ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_logical_expr`


__END__

Check warning on line 13 in infra/src/types/memo/implementation.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] infra/src/types/memo/implementation.rs#L13

warning: unused variable: `logical_expr`
  --> infra/src/types/memo/implementation.rs:13:47
   |
13 |     pub async fn add_expr_to_group(&mut self, logical_expr: Expr, group_id: GroupId) -> ExprId {
   |                                               ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_logical_expr`
Raw output
infra/src/types/memo/implementation.rs:13:47:w:warning: unused variable: `logical_expr`
  --> infra/src/types/memo/implementation.rs:13:47
   |
13 |     pub async fn add_expr_to_group(&mut self, logical_expr: Expr, group_id: GroupId) -> ExprId {
   |                                               ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_logical_expr`


__END__

Check warning on line 13 in infra/src/types/memo/implementation.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] infra/src/types/memo/implementation.rs#L13

warning: unused variable: `group_id`
  --> infra/src/types/memo/implementation.rs:13:67
   |
13 |     pub async fn add_expr_to_group(&mut self, logical_expr: Expr, group_id: GroupId) -> ExprId {
   |                                                                   ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_group_id`
Raw output
infra/src/types/memo/implementation.rs:13:67:w:warning: unused variable: `group_id`
  --> infra/src/types/memo/implementation.rs:13:67
   |
13 |     pub async fn add_expr_to_group(&mut self, logical_expr: Expr, group_id: GroupId) -> ExprId {
   |                                                                   ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_group_id`


__END__

Check warning on line 17 in infra/src/types/memo/implementation.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] infra/src/types/memo/implementation.rs#L17

warning: unused variable: `group_id`
  --> infra/src/types/memo/implementation.rs:17:45
   |
17 |     pub async fn get_group_exprs(&mut self, group_id: GroupId) -> Vec<(ExprId, Expr)> {
   |                                             ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_group_id`
Raw output
infra/src/types/memo/implementation.rs:17:45:w:warning: unused variable: `group_id`
  --> infra/src/types/memo/implementation.rs:17:45
   |
17 |     pub async fn get_group_exprs(&mut self, group_id: GroupId) -> Vec<(ExprId, Expr)> {
   |                                             ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_group_id`


__END__

Check warning on line 21 in infra/src/types/memo/implementation.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] infra/src/types/memo/implementation.rs#L21

warning: unused variable: `logical_expr_id`
  --> infra/src/types/memo/implementation.rs:21:44
   |
21 |     pub async fn get_expr_group(&mut self, logical_expr_id: ExprId) -> GroupId {
   |                                            ^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_logical_expr_id`
Raw output
infra/src/types/memo/implementation.rs:21:44:w:warning: unused variable: `logical_expr_id`
  --> infra/src/types/memo/implementation.rs:21:44
   |
21 |     pub async fn get_expr_group(&mut self, logical_expr_id: ExprId) -> GroupId {
   |                                            ^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_logical_expr_id`


__END__

Check warning on line 72 in infra/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] infra/src/lib.rs#L72

warning: unreachable call
  --> infra/src/lib.rs:72:56
   |
72 |                     condition: LogicalLink::ScalarNode(Arc::new(todo!())),
   |                                                        ^^^^^^^^ ------- any code following this expression is unreachable
   |                                                        |
   |                                                        unreachable call
   |
   = note: `#[warn(unreachable_code)]` on by default
Raw output
infra/src/lib.rs:72:56:w:warning: unreachable call
  --> infra/src/lib.rs:72:56
   |
72 |                     condition: LogicalLink::ScalarNode(Arc::new(todo!())),
   |                                                        ^^^^^^^^ ------- any code following this expression is unreachable
   |                                                        |
   |                                                        unreachable call
   |
   = note: `#[warn(unreachable_code)]` on by default


__END__

Check warning on line 50 in infra/src/types/plan/physical_plan.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] infra/src/types/plan/physical_plan.rs#L50

warning: unused variable: `table_name`
  --> infra/src/types/plan/physical_plan.rs:50:17
   |
50 |                 table_name,
   |                 ^^^^^^^^^^ help: try ignoring the field: `table_name: _`
Raw output
infra/src/types/plan/physical_plan.rs:50:17:w:warning: unused variable: `table_name`
  --> infra/src/types/plan/physical_plan.rs:50:17
   |
50 |                 table_name,
   |                 ^^^^^^^^^^ help: try ignoring the field: `table_name: _`


__END__

Check warning on line 51 in infra/src/types/plan/physical_plan.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] infra/src/types/plan/physical_plan.rs#L51

warning: unused variable: `predicate`
  --> infra/src/types/plan/physical_plan.rs:51:17
   |
51 |                 predicate,
   |                 ^^^^^^^^^ help: try ignoring the field: `predicate: _`
Raw output
infra/src/types/plan/physical_plan.rs:51:17:w:warning: unused variable: `predicate`
  --> infra/src/types/plan/physical_plan.rs:51:17
   |
51 |                 predicate,
   |                 ^^^^^^^^^ help: try ignoring the field: `predicate: _`


__END__