-
Notifications
You must be signed in to change notification settings - Fork 2
(feat) Type Inference Constraints #72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlSchlo
added a commit
that referenced
this pull request
Apr 17, 2025
### quick overview This PR is the next step for type inference in our DSL, and follows #72 . To solve the constraints, we need two core functions: `greatest_lower_bound` and `least_upper_bound`. - The least upper bound is the most specific type that is a supertype of both input types. - The greatest lower bound is the most general type that is a subtype of both input types. See tests for examples. Furthermore, some code in `types.rs` was broken, but is now fixed. - Map key was not contravariant, but covariant. - `T` was not a subtype of `Optional[T]`. ### next steps Writing the solver is the next and final step for practical type inference. We would still need to handle `Generics` properly, and propagate `Costed`/`Stored`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
quick overview
This PR is the first step to type inference. Specifically:
from_ast
conversion type. All other types that cannot be directly inferred are assigned a strictly monotonicunknown_id
.Solver
struct.HIR
.No real new tests, as it makes more sense to test inference as a whole feature later on.
next steps
Writing the solver is the next logical step. More details coming in subsequent PRs.