warning: question mark operator is useless here --> optd-core/src/storage/memo.rs:67:9 | 67 | Ok(Transaction::new(txn).await?) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing question mark and `Ok()`: `Transaction::new(txn).await` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark = note: `#[warn(clippy::needless_question_mark)]` on by default

warning: deref which would be done by auto-deref --> optd-core/src/storage/memo.rs:84:42 | 84 | .get_representative_group_id(&mut *txn, group_id) | ^^^^^^^^^ help: try: `&mut txn` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref = note: `#[warn(clippy::explicit_auto_deref)]` on by default

warning: deref which would be done by auto-deref --> optd-core/src/storage/memo.rs:132:49 | 132 | .get_representative_scalar_group_id(&mut *txn, group_id) | ^^^^^^^^^ help: try: `&mut txn` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref

warning: deref which would be done by auto-deref --> optd-core/src/storage/memo.rs:171:42 | 171 | self.set_representative_group_id(&mut *txn, from, to) | ^^^^^^^^^ help: try: `&mut txn` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref

warning: deref which would be done by auto-deref --> optd-core/src/storage/memo.rs:183:49 | 183 | self.set_representative_scalar_group_id(&mut *txn, from, to) | ^^^^^^^^^ help: try: `&mut txn` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref

warning: returning the result of a `let` binding from a block --> optd-core/src/storage/memo.rs:284:17 | 278 | / ... let group_id = sqlx::query_scalar("INSERT INTO scalar_constants (scalar_expression_id, group_id, value) VALUES ($1, $2, $3) ON CONF... 279 | | ... .bind(scalar_expr_id) 280 | | ... .bind(group_id) 281 | | ... .bind(serde_json::to_string(&constant)?) 282 | | ... .fetch_one(&mut *txn) 283 | | ... .await?; | |__________________- unnecessary `let` binding 284 | ... group_id | ^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return = note: `#[warn(clippy::let_and_return)]` on by default help: return the expression directly | 278 ~ 279 ~ sqlx::query_scalar("INSERT INTO scalar_constants (scalar_expression_id, group_id, value) VALUES ($1, $2, $3) ON CONFLICT DO UPDATE SET group_id = group_id RETURNING group_id") 280 + .bind(scalar_expr_id) 281 + .bind(group_id) 282 + .bind(serde_json::to_string(&constant)?) 283 + .fetch_one(&mut *txn) 284 + .await? |

warning: returning the result of a `let` binding from a block --> optd-core/src/storage/memo.rs:300:17 | 294 | / ... let group_id = sqlx::query_scalar("INSERT INTO scalar_column_refs (scalar_expression_id, group_id, column_index) VALUES ($1, $2, $3... 295 | | ... .bind(scalar_expr_id) 296 | | ... .bind(group_id) 297 | | ... .bind(serde_json::to_string(&column_ref.column_index)?) 298 | | ... .fetch_one(&mut *txn) 299 | | ... .await?; | |__________________- unnecessary `let` binding 300 | ... group_id | ^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return help: return the expression directly | 294 ~ 295 ~ sqlx::query_scalar("INSERT INTO scalar_column_refs (scalar_expression_id, group_id, column_index) VALUES ($1, $2, $3) ON CONFLICT DO UPDATE SET group_id = group_id RETURNING group_id") 296 + .bind(scalar_expr_id) 297 + .bind(group_id) 298 + .bind(serde_json::to_string(&column_ref.column_index)?) 299 + .fetch_one(&mut *txn) 300 + .await? |

warning: returning the result of a `let` binding from a block --> optd-core/src/storage/memo.rs:320:17 | 313 | / ... let group_id = sqlx::query_scalar("INSERT INTO scalar_adds (scalar_expression_id, group_id, left_group_id, right_group_id) VALUES (... 314 | | ... .bind(scalar_expr_id) 315 | | ... .bind(group_id) 316 | | ... .bind(add.left) 317 | | ... .bind(add.right) 318 | | ... .fetch_one(&mut *txn) 319 | | ... .await?; | |__________________- unnecessary `let` binding 320 | ... group_id | ^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return help: return the expression directly | 313 ~ 314 ~ sqlx::query_scalar("INSERT INTO scalar_adds (scalar_expression_id, group_id, left_group_id, right_group_id) VALUES ($1, $2, $3, $4) ON CONFLICT DO UPDATE SET group_id = group_id RETURNING group_id") 315 + .bind(scalar_expr_id) 316 + .bind(group_id) 317 + .bind(add.left) 318 + .bind(add.right) 319 + .fetch_one(&mut *txn) 320 + .await? |

warning: returning the result of a `let` binding from a block --> optd-core/src/storage/memo.rs:337:17 | 330 | / ... let group_id = sqlx::query_scalar("INSERT INTO scalar_equals (scalar_expression_id, group_id, left_group_id, right_group_id) VALUES... 331 | | ... .bind(scalar_expr_id) 332 | | ... .bind(group_id) 333 | | ... .bind(equal.left) 334 | | ... .bind(equal.right) 335 | | ... .fetch_one(&mut *txn) 336 | | ... .await?; | |__________________- unnecessary `let` binding 337 | ... group_id | ^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return help: return the expression directly | 330 ~ 331 ~ sqlx::query_scalar("INSERT INTO scalar_equals (scalar_expression_id, group_id, left_group_id, right_group_id) VALUES ($1, $2, $3, $4) ON CONFLICT DO UPDATE SET group_id = group_id RETURNING group_id") 332 + .bind(scalar_expr_id) 333 + .bind(group_id) 334 + .bind(equal.left) 335 + .bind(equal.right) 336 + .fetch_one(&mut *txn) 337 + .await? |

warning: returning the result of a `let` binding from a block --> optd-core/src/storage/memo.rs:427:17 | 420 | / ... let group_id= sqlx::query_scalar("INSERT INTO scans (logical_expression_id, group_id, table_name, predicate_group_id) VALUES ($1, $... 421 | | ... .bind(logical_expr_id) 422 | | ... .bind(group_id) 423 | | ... .bind(serde_json::to_string(&scan.table_name)?) 424 | | ... .bind(scan.predicate) 425 | | ... .fetch_one(&mut *txn) 426 | | ... .await?; | |__________________- unnecessary `let` binding 427 | ... group_id | ^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return help: return the expression directly | 420 ~ 421 ~ sqlx::query_scalar("INSERT INTO scans (logical_expression_id, group_id, table_name, predicate_group_id) VALUES ($1, $2, $3, $4) ON CONFLICT DO UPDATE SET group_id = group_id RETURNING group_id") 422 + .bind(logical_expr_id) 423 + .bind(group_id) 424 + .bind(serde_json::to_string(&scan.table_name)?) 425 + .bind(scan.predicate) 426 + .fetch_one(&mut *txn) 427 + .await? |

warning: returning the result of a `let` binding from a block --> optd-core/src/storage/memo.rs:444:17 | 437 | / ... let group_id = sqlx::query_scalar("INSERT INTO filters (logical_expression_id, group_id, child_group_id, predicate_group_id) VALUES... 438 | | ... .bind(logical_expr_id) 439 | | ... .bind(group_id) 440 | | ... .bind(filter.child) 441 | | ... .bind(filter.predicate) 442 | | ... .fetch_one(&mut *txn) 443 | | ... .await?; | |__________________- unnecessary `let` binding 444 | ... group_id | ^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return help: return the expression directly | 437 ~ 438 ~ sqlx::query_scalar("INSERT INTO filters (logical_expression_id, group_id, child_group_id, predicate_group_id) VALUES ($1, $2, $3, $4) ON CONFLICT DO UPDATE SET group_id = group_id RETURNING group_id") 439 + .bind(logical_expr_id) 440 + .bind(group_id) 441 + .bind(filter.child) 442 + .bind(filter.predicate) 443 + .fetch_one(&mut *txn) 444 + .await? |

warning: returning the result of a `let` binding from a block --> optd-core/src/storage/memo.rs:463:17 | 454 | / ... let group_id = sqlx::query_scalar("INSERT INTO joins (logical_expression_id, group_id, join_type, left_group_id, right_group_id, co... 455 | | ... .bind(logical_expr_id) 456 | | ... .bind(group_id) 457 | | ... .bind(serde_json::to_string(&join.join_type)?) ... | 461 | | ... .fetch_one(&mut *txn) 462 | | ... .await?; | |__________________- unnecessary `let` binding 463 | ... group_id | ^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return help: return the expression directly | 454 ~ 455 ~ sqlx::query_scalar("INSERT INTO joins (logical_expression_id, group_id, join_type, left_group_id, right_group_id, condition_group_id) VALUES ($1, $2, $3, $4, $5, $6) ON CONFLICT DO UPDATE SET group_id = group_id RETURNING group_id") 456 + .bind(logical_expr_id) 457 + .bind(group_id) 458 + .bind(serde_json::to_string(&join.join_type)?) 459 + .bind(join.left) 460 + .bind(join.right) 461 + .bind(join.condition) 462 + .fetch_one(&mut *txn) 463 + .await? |

warning: deref which would be done by auto-deref --> optd-core/src/storage/transaction.rs:44:45 | 44 | let current_value = Sequence::value(&mut *txn).await?; | ^^^^^^^^^ help: try: `&mut txn` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref

warning: deref which would be done by auto-deref --> optd-core/src/storage/transaction.rs:50:29 | 50 | Sequence::set_value(&mut *self.txn, self.current_value).await?; | ^^^^^^^^^^^^^^ help: try: `&mut self.txn` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref

warning: deref which would be done by auto-deref --> optd-core/src/storage/transaction.rs:101:9 | 101 | &mut *self.txn | ^^^^^^^^^^^^^^ help: try: `&mut self.txn` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref

warning: question mark operator is useless here --> optd-core/src/storage/memo.rs:67:9 | 67 | Ok(Transaction::new(txn).await?) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing question mark and `Ok()`: `Transaction::new(txn).await` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark = note: `#[warn(clippy::needless_question_mark)]` on by default

warning: deref which would be done by auto-deref --> optd-core/src/storage/memo.rs:84:42 | 84 | .get_representative_group_id(&mut *txn, group_id) | ^^^^^^^^^ help: try: `&mut txn` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref = note: `#[warn(clippy::explicit_auto_deref)]` on by default

warning: deref which would be done by auto-deref --> optd-core/src/storage/memo.rs:132:49 | 132 | .get_representative_scalar_group_id(&mut *txn, group_id) | ^^^^^^^^^ help: try: `&mut txn` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref

warning: deref which would be done by auto-deref --> optd-core/src/storage/memo.rs:171:42 | 171 | self.set_representative_group_id(&mut *txn, from, to) | ^^^^^^^^^ help: try: `&mut txn` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref

warning: deref which would be done by auto-deref --> optd-core/src/storage/memo.rs:183:49 | 183 | self.set_representative_scalar_group_id(&mut *txn, from, to) | ^^^^^^^^^ help: try: `&mut txn` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref

warning: returning the result of a `let` binding from a block --> optd-core/src/storage/memo.rs:284:17 | 278 | / ... let group_id = sqlx::query_scalar("INSERT INTO scalar_constants (scalar_expression_id, group_id, value) VALUES ($1, $2, $3) ON CONF... 279 | | ... .bind(scalar_expr_id) 280 | | ... .bind(group_id) 281 | | ... .bind(serde_json::to_string(&constant)?) 282 | | ... .fetch_one(&mut *txn) 283 | | ... .await?; | |__________________- unnecessary `let` binding 284 | ... group_id | ^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return = note: `#[warn(clippy::let_and_return)]` on by default help: return the expression directly | 278 ~ 279 ~ sqlx::query_scalar("INSERT INTO scalar_constants (scalar_expression_id, group_id, value) VALUES ($1, $2, $3) ON CONFLICT DO UPDATE SET group_id = group_id RETURNING group_id") 280 + .bind(scalar_expr_id) 281 + .bind(group_id) 282 + .bind(serde_json::to_string(&constant)?) 283 + .fetch_one(&mut *txn) 284 + .await? |

warning: returning the result of a `let` binding from a block --> optd-core/src/storage/memo.rs:300:17 | 294 | / ... let group_id = sqlx::query_scalar("INSERT INTO scalar_column_refs (scalar_expression_id, group_id, column_index) VALUES ($1, $2, $3... 295 | | ... .bind(scalar_expr_id) 296 | | ... .bind(group_id) 297 | | ... .bind(serde_json::to_string(&column_ref.column_index)?) 298 | | ... .fetch_one(&mut *txn) 299 | | ... .await?; | |__________________- unnecessary `let` binding 300 | ... group_id | ^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return help: return the expression directly | 294 ~ 295 ~ sqlx::query_scalar("INSERT INTO scalar_column_refs (scalar_expression_id, group_id, column_index) VALUES ($1, $2, $3) ON CONFLICT DO UPDATE SET group_id = group_id RETURNING group_id") 296 + .bind(scalar_expr_id) 297 + .bind(group_id) 298 + .bind(serde_json::to_string(&column_ref.column_index)?) 299 + .fetch_one(&mut *txn) 300 + .await? |

warning: returning the result of a `let` binding from a block --> optd-core/src/storage/memo.rs:320:17 | 313 | / ... let group_id = sqlx::query_scalar("INSERT INTO scalar_adds (scalar_expression_id, group_id, left_group_id, right_group_id) VALUES (... 314 | | ... .bind(scalar_expr_id) 315 | | ... .bind(group_id) 316 | | ... .bind(add.left) 317 | | ... .bind(add.right) 318 | | ... .fetch_one(&mut *txn) 319 | | ... .await?; | |__________________- unnecessary `let` binding 320 | ... group_id | ^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return help: return the expression directly | 313 ~ 314 ~ sqlx::query_scalar("INSERT INTO scalar_adds (scalar_expression_id, group_id, left_group_id, right_group_id) VALUES ($1, $2, $3, $4) ON CONFLICT DO UPDATE SET group_id = group_id RETURNING group_id") 315 + .bind(scalar_expr_id) 316 + .bind(group_id) 317 + .bind(add.left) 318 + .bind(add.right) 319 + .fetch_one(&mut *txn) 320 + .await? |

warning: returning the result of a `let` binding from a block --> optd-core/src/storage/memo.rs:337:17 | 330 | / ... let group_id = sqlx::query_scalar("INSERT INTO scalar_equals (scalar_expression_id, group_id, left_group_id, right_group_id) VALUES... 331 | | ... .bind(scalar_expr_id) 332 | | ... .bind(group_id) 333 | | ... .bind(equal.left) 334 | | ... .bind(equal.right) 335 | | ... .fetch_one(&mut *txn) 336 | | ... .await?; | |__________________- unnecessary `let` binding 337 | ... group_id | ^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return help: return the expression directly | 330 ~ 331 ~ sqlx::query_scalar("INSERT INTO scalar_equals (scalar_expression_id, group_id, left_group_id, right_group_id) VALUES ($1, $2, $3, $4) ON CONFLICT DO UPDATE SET group_id = group_id RETURNING group_id") 332 + .bind(scalar_expr_id) 333 + .bind(group_id) 334 + .bind(equal.left) 335 + .bind(equal.right) 336 + .fetch_one(&mut *txn) 337 + .await? |

warning: returning the result of a `let` binding from a block --> optd-core/src/storage/memo.rs:427:17 | 420 | / ... let group_id= sqlx::query_scalar("INSERT INTO scans (logical_expression_id, group_id, table_name, predicate_group_id) VALUES ($1, $... 421 | | ... .bind(logical_expr_id) 422 | | ... .bind(group_id) 423 | | ... .bind(serde_json::to_string(&scan.table_name)?) 424 | | ... .bind(scan.predicate) 425 | | ... .fetch_one(&mut *txn) 426 | | ... .await?; | |__________________- unnecessary `let` binding 427 | ... group_id | ^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return help: return the expression directly | 420 ~ 421 ~ sqlx::query_scalar("INSERT INTO scans (logical_expression_id, group_id, table_name, predicate_group_id) VALUES ($1, $2, $3, $4) ON CONFLICT DO UPDATE SET group_id = group_id RETURNING group_id") 422 + .bind(logical_expr_id) 423 + .bind(group_id) 424 + .bind(serde_json::to_string(&scan.table_name)?) 425 + .bind(scan.predicate) 426 + .fetch_one(&mut *txn) 427 + .await? |

warning: returning the result of a `let` binding from a block --> optd-core/src/storage/memo.rs:444:17 | 437 | / ... let group_id = sqlx::query_scalar("INSERT INTO filters (logical_expression_id, group_id, child_group_id, predicate_group_id) VALUES... 438 | | ... .bind(logical_expr_id) 439 | | ... .bind(group_id) 440 | | ... .bind(filter.child) 441 | | ... .bind(filter.predicate) 442 | | ... .fetch_one(&mut *txn) 443 | | ... .await?; | |__________________- unnecessary `let` binding 444 | ... group_id | ^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return help: return the expression directly | 437 ~ 438 ~ sqlx::query_scalar("INSERT INTO filters (logical_expression_id, group_id, child_group_id, predicate_group_id) VALUES ($1, $2, $3, $4) ON CONFLICT DO UPDATE SET group_id = group_id RETURNING group_id") 439 + .bind(logical_expr_id) 440 + .bind(group_id) 441 + .bind(filter.child) 442 + .bind(filter.predicate) 443 + .fetch_one(&mut *txn) 444 + .await? |

warning: returning the result of a `let` binding from a block --> optd-core/src/storage/memo.rs:463:17 | 454 | / ... let group_id = sqlx::query_scalar("INSERT INTO joins (logical_expression_id, group_id, join_type, left_group_id, right_group_id, co... 455 | | ... .bind(logical_expr_id) 456 | | ... .bind(group_id) 457 | | ... .bind(serde_json::to_string(&join.join_type)?) ... | 461 | | ... .fetch_one(&mut *txn) 462 | | ... .await?; | |__________________- unnecessary `let` binding 463 | ... group_id | ^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return help: return the expression directly | 454 ~ 455 ~ sqlx::query_scalar("INSERT INTO joins (logical_expression_id, group_id, join_type, left_group_id, right_group_id, condition_group_id) VALUES ($1, $2, $3, $4, $5, $6) ON CONFLICT DO UPDATE SET group_id = group_id RETURNING group_id") 456 + .bind(logical_expr_id) 457 + .bind(group_id) 458 + .bind(serde_json::to_string(&join.join_type)?) 459 + .bind(join.left) 460 + .bind(join.right) 461 + .bind(join.condition) 462 + .fetch_one(&mut *txn) 463 + .await? |

warning: deref which would be done by auto-deref --> optd-core/src/storage/transaction.rs:44:45 | 44 | let current_value = Sequence::value(&mut *txn).await?; | ^^^^^^^^^ help: try: `&mut txn` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref

warning: deref which would be done by auto-deref --> optd-core/src/storage/transaction.rs:50:29 | 50 | Sequence::set_value(&mut *self.txn, self.current_value).await?; | ^^^^^^^^^^^^^^ help: try: `&mut self.txn` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref