Process completed with exit code 101.

The job was canceled because "beta" failed.

Process completed with exit code 101.

Process completed with exit code 101.

Process completed with exit code 101.

Process completed with exit code 1.

Process completed with exit code 1.

warning: missing documentation for a struct field --> optd-core/src/memo/persistent_memo.rs:14:5 | 14 | storage: StorageManager, | ^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_docs_in_private_items note: the lint level is defined here --> optd-core/src/lib.rs:4:9 | 4 | #![warn(clippy::missing_docs_in_private_items)] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

warning: docs for function returning `Result` missing `# Errors` section --> optd-core/src/memo/persistent_memo.rs:23:5 | 23 | pub async fn new(database_url: &str) -> anyhow::Result<Self> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc note: the lint level is defined here --> optd-core/src/lib.rs:5:9 | 5 | #![warn(clippy::missing_errors_doc)] | ^^^^^^^^^^^^^^^^^^^^^^^^^^

warning: docs for function returning `Result` missing `# Errors` section --> optd-core/src/memo/persistent_memo.rs:41:5 | 41 | pub async fn new_in_memory() -> anyhow::Result<Self> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc

warning: missing documentation for a method --> optd-core/src/memo/persistent_memo.rs:62:5 | 62 | / async fn get_representative_group_id( 63 | | &self, 64 | | db: &mut SqliteConnection, 65 | | group_id: GroupId, ... | 72 | | Ok(representative_group_id) 73 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_docs_in_private_items

warning: missing documentation for a method --> optd-core/src/memo/persistent_memo.rs:75:5 | 75 | / async fn set_representative_group_id( 76 | | &self, 77 | | db: &mut SqliteConnection, 78 | | group_id: GroupId, ... | 86 | | Ok(()) 87 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_docs_in_private_items

warning: missing documentation for a method --> optd-core/src/memo/persistent_memo.rs:89:5 | 89 | / async fn get_representative_scalar_group_id( 90 | | &self, 91 | | db: &mut SqliteConnection, 92 | | group_id: ScalarGroupId, ... | 99 | | Ok(representative_group_id) 100 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_docs_in_private_items

warning: missing documentation for a method --> optd-core/src/memo/persistent_memo.rs:102:5 | 102 | / async fn set_representative_scalar_group_id( 103 | | &self, 104 | | db: &mut SqliteConnection, 105 | | group_id: ScalarGroupId, ... | 113 | | Ok(()) 114 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_docs_in_private_items

warning: missing documentation for a method --> optd-core/src/memo/persistent_memo.rs:116:5 | 116 | / async fn add_scalar_expr_to_group_inner( 117 | | &self, 118 | | scalar_expr: &ScalarExpression, 119 | | add_to_group_id: Option<ScalarGroupId>, ... | 222 | | Ok(inserted_group_id) 223 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_docs_in_private_items

warning: returning the result of a `let` binding from a block --> optd-core/src/memo/persistent_memo.rs:154:17 | 148 | / ... let group_id = sqlx::query_scalar("INSERT INTO scalar_constants (scalar_expression_id, group_id, payload) VALUES ($1, $2, $3) ON CO... 149 | | ... .bind(scalar_expr_id) 150 | | ... .bind(group_id) 151 | | ... .bind(serde_json::to_value(constant)?) 152 | | ... .fetch_one(&mut *txn) 153 | | ... .await?; | |__________________- unnecessary `let` binding 154 | ... group_id | ^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return = note: `#[warn(clippy::let_and_return)]` on by default help: return the expression directly | 148 ~ 149 ~ sqlx::query_scalar("INSERT INTO scalar_constants (scalar_expression_id, group_id, payload) VALUES ($1, $2, $3) ON CONFLICT DO UPDATE SET group_id = group_id RETURNING group_id") 150 + .bind(scalar_expr_id) 151 + .bind(group_id) 152 + .bind(serde_json::to_value(constant)?) 153 + .fetch_one(&mut *txn) 154 + .await? |

warning: returning the result of a `let` binding from a block --> optd-core/src/memo/persistent_memo.rs:170:17 | 164 | / ... let group_id = sqlx::query_scalar("INSERT INTO scalar_column_refs (scalar_expression_id, group_id, payload) VALUES ($1, $2, $3) ON ... 165 | | ... .bind(scalar_expr_id) 166 | | ... .bind(group_id) 167 | | ... .bind(serde_json::to_value(column_ref)?) 168 | | ... .fetch_one(&mut *txn) 169 | | ... .await?; | |__________________- unnecessary `let` binding 170 | ... group_id | ^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return help: return the expression directly | 164 ~ 165 ~ sqlx::query_scalar("INSERT INTO scalar_column_refs (scalar_expression_id, group_id, payload) VALUES ($1, $2, $3) ON CONFLICT DO UPDATE SET group_id = group_id RETURNING group_id") 166 + .bind(scalar_expr_id) 167 + .bind(group_id) 168 + .bind(serde_json::to_value(column_ref)?) 169 + .fetch_one(&mut *txn) 170 + .await? |

warning: returning the result of a `let` binding from a block --> optd-core/src/memo/persistent_memo.rs:187:17 | 180 | / ... let group_id = sqlx::query_scalar("INSERT INTO scalar_adds (scalar_expression_id, group_id, left_group_id, right_group_id) VALUES (... 181 | | ... .bind(scalar_expr_id) 182 | | ... .bind(group_id) 183 | | ... .bind(add.left) 184 | | ... .bind(add.right) 185 | | ... .fetch_one(&mut *txn) 186 | | ... .await?; | |__________________- unnecessary `let` binding 187 | ... group_id | ^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return help: return the expression directly | 180 ~ 181 ~ sqlx::query_scalar("INSERT INTO scalar_adds (scalar_expression_id, group_id, left_group_id, right_group_id) VALUES ($1, $2, $3, $4) ON CONFLICT DO UPDATE SET group_id = group_id RETURNING group_id") 182 + .bind(scalar_expr_id) 183 + .bind(group_id) 184 + .bind(add.left) 185 + .bind(add.right) 186 + .fetch_one(&mut *txn) 187 + .await? |

warning: returning the result of a `let` binding from a block --> optd-core/src/memo/persistent_memo.rs:204:17 | 197 | / ... let group_id = sqlx::query_scalar("INSERT INTO scalar_equals (scalar_expression_id, group_id, left_group_id, right_group_id) VALUES... 198 | | ... .bind(scalar_expr_id) 199 | | ... .bind(group_id) 200 | | ... .bind(equal.left) 201 | | ... .bind(equal.right) 202 | | ... .fetch_one(&mut *txn) 203 | | ... .await?; | |__________________- unnecessary `let` binding 204 | ... group_id | ^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return help: return the expression directly | 197 ~ 198 ~ sqlx::query_scalar("INSERT INTO scalar_equals (scalar_expression_id, group_id, left_group_id, right_group_id) VALUES ($1, $2, $3, $4) ON CONFLICT DO UPDATE SET group_id = group_id RETURNING group_id") 199 + .bind(scalar_expr_id) 200 + .bind(group_id) 201 + .bind(equal.left) 202 + .bind(equal.right) 203 + .fetch_one(&mut *txn) 204 + .await? |

warning: missing documentation for a method --> optd-core/src/memo/persistent_memo.rs:242:5 | 242 | / async fn remove_dangling_scalar_expr( 243 | | &self, 244 | | db: &mut SqliteConnection, 245 | | scalar_expr_id: ScalarExpressionId, ... | 251 | | Ok(()) 252 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_docs_in_private_items

warning: missing documentation for a method --> optd-core/src/memo/persistent_memo.rs:254:5 | 254 | / async fn add_logical_expr_to_group_inner( 255 | | &self, 256 | | logical_expr: &LogicalExpression, 257 | | add_to_group_id: Option<GroupId>, ... | 366 | | Ok(inserted_group_id) 367 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_docs_in_private_items

warning: returning the result of a `let` binding from a block --> optd-core/src/memo/persistent_memo.rs:295:17 | 288 | / ... let group_id= sqlx::query_scalar("INSERT INTO scans (logical_expression_id, group_id, table_name, predicate_group_id) VALUES ($1, $... 289 | | ... .bind(logical_expr_id) 290 | | ... .bind(group_id) 291 | | ... .bind(&scan.table_name) 292 | | ... .bind(scan.predicate) 293 | | ... .fetch_one(&mut *txn) 294 | | ... .await?; | |__________________- unnecessary `let` binding 295 | ... group_id | ^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return help: return the expression directly | 288 ~ 289 ~ sqlx::query_scalar("INSERT INTO scans (logical_expression_id, group_id, table_name, predicate_group_id) VALUES ($1, $2, $3, $4) ON CONFLICT DO UPDATE SET group_id = group_id RETURNING group_id") 290 + .bind(logical_expr_id) 291 + .bind(group_id) 292 + .bind(&scan.table_name) 293 + .bind(scan.predicate) 294 + .fetch_one(&mut *txn) 295 + .await? |

warning: returning the result of a `let` binding from a block --> optd-core/src/memo/persistent_memo.rs:312:17 | 305 | / ... let group_id = sqlx::query_scalar("INSERT INTO filters (logical_expression_id, group_id, child_group_id, predicate_group_id) VALUES... 306 | | ... .bind(logical_expr_id) 307 | | ... .bind(group_id) 308 | | ... .bind(filter.child) 309 | | ... .bind(filter.predicate) 310 | | ... .fetch_one(&mut *txn) 311 | | ... .await?; | |__________________- unnecessary `let` binding 312 | ... group_id | ^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return help: return the expression directly | 305 ~ 306 ~ sqlx::query_scalar("INSERT INTO filters (logical_expression_id, group_id, child_group_id, predicate_group_id) VALUES ($1, $2, $3, $4) ON CONFLICT DO UPDATE SET group_id = group_id RETURNING group_id") 307 + .bind(logical_expr_id) 308 + .bind(group_id) 309 + .bind(filter.child) 310 + .bind(filter.predicate) 311 + .fetch_one(&mut *txn) 312 + .await? |

warning: returning the result of a `let` binding from a block --> optd-core/src/memo/persistent_memo.rs:329:17 | 322 | / ... let group_id = sqlx::query_scalar("INSERT INTO projects (logical_expression_id, group_id, child_group_id, fields_group_ids) VALUES ... 323 | | ... .bind(logical_expr_id) 324 | | ... .bind(group_id) 325 | | ... .bind(project.child) 326 | | ... .bind(serde_json::to_value(&project.fields)?) 327 | | ... .fetch_one(&mut *txn) 328 | | ... .await?; | |__________________- unnecessary `let` binding 329 | ... group_id | ^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return help: return the expression directly | 322 ~ 323 ~ sqlx::query_scalar("INSERT INTO projects (logical_expression_id, group_id, child_group_id, fields_group_ids) VALUES ($1, $2, $3, $4) ON CONFLICT DO UPDATE SET group_id = group_id RETURNING group_id") 324 + .bind(logical_expr_id) 325 + .bind(group_id) 326 + .bind(project.child) 327 + .bind(serde_json::to_value(&project.fields)?) 328 + .fetch_one(&mut *txn) 329 + .await? |

warning: returning the result of a `let` binding from a block --> optd-core/src/memo/persistent_memo.rs:348:17 | 339 | / ... let group_id = sqlx::query_scalar("INSERT INTO joins (logical_expression_id, group_id, join_type, left_group_id, right_group_id, co... 340 | | ... .bind(logical_expr_id) 341 | | ... .bind(group_id) 342 | | ... .bind(join.join_type) ... | 346 | | ... .fetch_one(&mut *txn) 347 | | ... .await?; | |__________________- unnecessary `let` binding 348 | ... group_id | ^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return help: return the expression directly | 339 ~ 340 ~ sqlx::query_scalar("INSERT INTO joins (logical_expression_id, group_id, join_type, left_group_id, right_group_id, condition_group_id) VALUES ($1, $2, $3, $4, $5, $6) ON CONFLICT DO UPDATE SET group_id = group_id RETURNING group_id") 341 + .bind(logical_expr_id) 342 + .bind(group_id) 343 + .bind(join.join_type) 344 + .bind(join.left) 345 + .bind(join.right) 346 + .bind(join.condition) 347 + .fetch_one(&mut *txn) 348 + .await? |

warning: missing documentation for an associated function --> optd-core/src/memo/persistent_memo.rs:369:5 | 369 | / async fn insert_into_logical_expressions( 370 | | txn: &mut SqliteConnection, 371 | | logical_expr_id: LogicalExpressionId, 372 | | group_id: GroupId, ... | 382 | | Ok(()) 383 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_docs_in_private_items

warning: missing documentation for a method --> optd-core/src/memo/persistent_memo.rs:385:5 | 385 | / async fn remove_dangling_logical_expr( 386 | | &self, 387 | | db: &mut SqliteConnection, 388 | | logical_expr_id: LogicalExpressionId, ... | 394 | | Ok(()) 395 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_docs_in_private_items

warning: missing documentation for a struct field --> optd-core/src/memo/persistent_memo.rs:436:13 | 436 | data: sqlx::types::Json<LogicalExpression>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_docs_in_private_items

warning: missing documentation for a struct field --> optd-core/src/memo/persistent_memo.rs:504:13 | 504 | data: sqlx::types::Json<ScalarExpression>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_docs_in_private_items

warning: missing documentation for a struct field --> optd-core/src/operator/relational/logical/scan.rs:23:5 | 23 | _phantom: PhantomData<Relation>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_docs_in_private_items

warning: missing documentation for a struct field --> optd-core/src/operator/relational/physical/scan/table_scan.rs:13:5 | 13 | _phantom: PhantomData<Relation>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_docs_in_private_items

warning: docs for function returning `Result` missing `# Errors` section --> optd-core/src/storage/sequence.rs:10:5 | 10 | pub async fn value(db: &mut SqliteConnection) -> anyhow::Result<i64> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc

warning: docs for function returning `Result` missing `# Errors` section --> optd-core/src/storage/sequence.rs:18:5 | 18 | pub async fn set_value(db: &mut SqliteConnection, value: i64) -> anyhow::Result<()> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc

warning: docs for function returning `Result` missing `# Errors` section --> optd-core/src/storage/mod.rs:23:5 | 23 | pub async fn new(database_url: &str) -> anyhow::Result<Self> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc

warning: docs for function returning `Result` missing `# Errors` section --> optd-core/src/storage/mod.rs:29:5 | 29 | pub async fn begin(&self) -> anyhow::Result<Transaction<'_>> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc

warning: deref which would be done by auto-deref --> optd-core/src/storage/mod.rs:31:45 | 31 | let current_value = Sequence::value(&mut *txn).await?; | ^^^^^^^^^ help: try: `&mut txn` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref = note: `#[warn(clippy::explicit_auto_deref)]` on by default

warning: docs for function returning `Result` missing `# Errors` section --> optd-core/src/storage/mod.rs:37:5 | 37 | pub async fn new_in_memory() -> anyhow::Result<Self> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc

warning: docs for function returning `Result` missing `# Errors` section --> optd-core/src/storage/mod.rs:42:5 | 42 | pub async fn migrate(&self) -> anyhow::Result<()> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc

warning: docs for function returning `Result` missing `# Errors` section --> optd-core/src/storage/mod.rs:51:5 | 51 | pub async fn db(&self) -> anyhow::Result<PoolConnection<sqlx::Sqlite>> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc

warning: missing documentation for a struct field --> optd-core/src/storage/mod.rs:61:5 | 61 | current_value: i64, | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_docs_in_private_items

warning: docs for function returning `Result` missing `# Errors` section --> optd-core/src/storage/mod.rs:66:5 | 66 | pub async fn commit(mut self) -> anyhow::Result<()> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc

warning: deref which would be done by auto-deref --> optd-core/src/storage/mod.rs:67:29 | 67 | Sequence::set_value(&mut *self.txn, self.current_value).await?; | ^^^^^^^^^^^^^^ help: try: `&mut self.txn` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref

warning: docs for function returning `Result` missing `# Errors` section --> optd-core/src/storage/mod.rs:73:5 | 73 | pub async fn new_group_id(&mut self) -> anyhow::Result<GroupId> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc

warning: docs for function returning `Result` missing `# Errors` section --> optd-core/src/storage/mod.rs:80:5 | 80 | pub async fn new_scalar_group_id(&mut self) -> anyhow::Result<ScalarGroupId> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc

warning: docs for function returning `Result` missing `# Errors` section --> optd-core/src/storage/mod.rs:87:5 | 87 | pub async fn new_logical_expression_id(&mut self) -> anyhow::Result<LogicalExpressionId> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc

warning: docs for function returning `Result` missing `# Errors` section --> optd-core/src/storage/mod.rs:94:5 | 94 | pub async fn new_physical_expression_id(&mut self) -> anyhow::Result<PhysicalExpressionId> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc

warning: docs for function returning `Result` missing `# Errors` section --> optd-core/src/storage/mod.rs:101:5 | 101 | pub async fn new_scalar_expression_id(&mut self) -> anyhow::Result<ScalarExpressionId> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc

warning: deref which would be done by auto-deref --> optd-core/src/storage/mod.rs:118:9 | 118 | &mut *self.txn | ^^^^^^^^^^^^^^ help: try: `&mut self.txn` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref

warning: missing documentation for a struct field --> optd-core/src/memo/persistent_memo.rs:14:5 | 14 | storage: StorageManager, | ^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_docs_in_private_items note: the lint level is defined here --> optd-core/src/lib.rs:4:9 | 4 | #![warn(clippy::missing_docs_in_private_items)] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

warning: docs for function returning `Result` missing `# Errors` section --> optd-core/src/memo/persistent_memo.rs:23:5 | 23 | pub async fn new(database_url: &str) -> anyhow::Result<Self> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc note: the lint level is defined here --> optd-core/src/lib.rs:5:9 | 5 | #![warn(clippy::missing_errors_doc)] | ^^^^^^^^^^^^^^^^^^^^^^^^^^

warning: docs for function returning `Result` missing `# Errors` section --> optd-core/src/memo/persistent_memo.rs:41:5 | 41 | pub async fn new_in_memory() -> anyhow::Result<Self> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc

warning: missing documentation for a method --> optd-core/src/memo/persistent_memo.rs:62:5 | 62 | / async fn get_representative_group_id( 63 | | &self, 64 | | db: &mut SqliteConnection, 65 | | group_id: GroupId, ... | 72 | | Ok(representative_group_id) 73 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_docs_in_private_items

warning: missing documentation for a method --> optd-core/src/memo/persistent_memo.rs:75:5 | 75 | / async fn set_representative_group_id( 76 | | &self, 77 | | db: &mut SqliteConnection, 78 | | group_id: GroupId, ... | 86 | | Ok(()) 87 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_docs_in_private_items

warning: missing documentation for a method --> optd-core/src/memo/persistent_memo.rs:89:5 | 89 | / async fn get_representative_scalar_group_id( 90 | | &self, 91 | | db: &mut SqliteConnection, 92 | | group_id: ScalarGroupId, ... | 99 | | Ok(representative_group_id) 100 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_docs_in_private_items

warning: missing documentation for a method --> optd-core/src/memo/persistent_memo.rs:102:5 | 102 | / async fn set_representative_scalar_group_id( 103 | | &self, 104 | | db: &mut SqliteConnection, 105 | | group_id: ScalarGroupId, ... | 113 | | Ok(()) 114 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_docs_in_private_items

warning: missing documentation for a method --> optd-core/src/memo/persistent_memo.rs:116:5 | 116 | / async fn add_scalar_expr_to_group_inner( 117 | | &self, 118 | | scalar_expr: &ScalarExpression, 119 | | add_to_group_id: Option<ScalarGroupId>, ... | 222 | | Ok(inserted_group_id) 223 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_docs_in_private_items

warning: returning the result of a `let` binding from a block --> optd-core/src/memo/persistent_memo.rs:154:17 | 148 | / ... let group_id = sqlx::query_scalar("INSERT INTO scalar_constants (scalar_expression_id, group_id, payload) VALUES ($1, $2, $3) ON CO... 149 | | ... .bind(scalar_expr_id) 150 | | ... .bind(group_id) 151 | | ... .bind(serde_json::to_value(constant)?) 152 | | ... .fetch_one(&mut *txn) 153 | | ... .await?; | |__________________- unnecessary `let` binding 154 | ... group_id | ^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return = note: `#[warn(clippy::let_and_return)]` on by default help: return the expression directly | 148 ~ 149 ~ sqlx::query_scalar("INSERT INTO scalar_constants (scalar_expression_id, group_id, payload) VALUES ($1, $2, $3) ON CONFLICT DO UPDATE SET group_id = group_id RETURNING group_id") 150 + .bind(scalar_expr_id) 151 + .bind(group_id) 152 + .bind(serde_json::to_value(constant)?) 153 + .fetch_one(&mut *txn) 154 + .await? |

warning: returning the result of a `let` binding from a block --> optd-core/src/memo/persistent_memo.rs:170:17 | 164 | / ... let group_id = sqlx::query_scalar("INSERT INTO scalar_column_refs (scalar_expression_id, group_id, payload) VALUES ($1, $2, $3) ON ... 165 | | ... .bind(scalar_expr_id) 166 | | ... .bind(group_id) 167 | | ... .bind(serde_json::to_value(column_ref)?) 168 | | ... .fetch_one(&mut *txn) 169 | | ... .await?; | |__________________- unnecessary `let` binding 170 | ... group_id | ^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return help: return the expression directly | 164 ~ 165 ~ sqlx::query_scalar("INSERT INTO scalar_column_refs (scalar_expression_id, group_id, payload) VALUES ($1, $2, $3) ON CONFLICT DO UPDATE SET group_id = group_id RETURNING group_id") 166 + .bind(scalar_expr_id) 167 + .bind(group_id) 168 + .bind(serde_json::to_value(column_ref)?) 169 + .fetch_one(&mut *txn) 170 + .await? |

warning: returning the result of a `let` binding from a block --> optd-core/src/memo/persistent_memo.rs:187:17 | 180 | / ... let group_id = sqlx::query_scalar("INSERT INTO scalar_adds (scalar_expression_id, group_id, left_group_id, right_group_id) VALUES (... 181 | | ... .bind(scalar_expr_id) 182 | | ... .bind(group_id) 183 | | ... .bind(add.left) 184 | | ... .bind(add.right) 185 | | ... .fetch_one(&mut *txn) 186 | | ... .await?; | |__________________- unnecessary `let` binding 187 | ... group_id | ^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return help: return the expression directly | 180 ~ 181 ~ sqlx::query_scalar("INSERT INTO scalar_adds (scalar_expression_id, group_id, left_group_id, right_group_id) VALUES ($1, $2, $3, $4) ON CONFLICT DO UPDATE SET group_id = group_id RETURNING group_id") 182 + .bind(scalar_expr_id) 183 + .bind(group_id) 184 + .bind(add.left) 185 + .bind(add.right) 186 + .fetch_one(&mut *txn) 187 + .await? |

warning: returning the result of a `let` binding from a block --> optd-core/src/memo/persistent_memo.rs:204:17 | 197 | / ... let group_id = sqlx::query_scalar("INSERT INTO scalar_equals (scalar_expression_id, group_id, left_group_id, right_group_id) VALUES... 198 | | ... .bind(scalar_expr_id) 199 | | ... .bind(group_id) 200 | | ... .bind(equal.left) 201 | | ... .bind(equal.right) 202 | | ... .fetch_one(&mut *txn) 203 | | ... .await?; | |__________________- unnecessary `let` binding 204 | ... group_id | ^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return help: return the expression directly | 197 ~ 198 ~ sqlx::query_scalar("INSERT INTO scalar_equals (scalar_expression_id, group_id, left_group_id, right_group_id) VALUES ($1, $2, $3, $4) ON CONFLICT DO UPDATE SET group_id = group_id RETURNING group_id") 199 + .bind(scalar_expr_id) 200 + .bind(group_id) 201 + .bind(equal.left) 202 + .bind(equal.right) 203 + .fetch_one(&mut *txn) 204 + .await? |

warning: missing documentation for a method --> optd-core/src/memo/persistent_memo.rs:242:5 | 242 | / async fn remove_dangling_scalar_expr( 243 | | &self, 244 | | db: &mut SqliteConnection, 245 | | scalar_expr_id: ScalarExpressionId, ... | 251 | | Ok(()) 252 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_docs_in_private_items

warning: missing documentation for a method --> optd-core/src/memo/persistent_memo.rs:254:5 | 254 | / async fn add_logical_expr_to_group_inner( 255 | | &self, 256 | | logical_expr: &LogicalExpression, 257 | | add_to_group_id: Option<GroupId>, ... | 366 | | Ok(inserted_group_id) 367 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_docs_in_private_items

warning: returning the result of a `let` binding from a block --> optd-core/src/memo/persistent_memo.rs:295:17 | 288 | / ... let group_id= sqlx::query_scalar("INSERT INTO scans (logical_expression_id, group_id, table_name, predicate_group_id) VALUES ($1, $... 289 | | ... .bind(logical_expr_id) 290 | | ... .bind(group_id) 291 | | ... .bind(&scan.table_name) 292 | | ... .bind(scan.predicate) 293 | | ... .fetch_one(&mut *txn) 294 | | ... .await?; | |__________________- unnecessary `let` binding 295 | ... group_id | ^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return help: return the expression directly | 288 ~ 289 ~ sqlx::query_scalar("INSERT INTO scans (logical_expression_id, group_id, table_name, predicate_group_id) VALUES ($1, $2, $3, $4) ON CONFLICT DO UPDATE SET group_id = group_id RETURNING group_id") 290 + .bind(logical_expr_id) 291 + .bind(group_id) 292 + .bind(&scan.table_name) 293 + .bind(scan.predicate) 294 + .fetch_one(&mut *txn) 295 + .await? |

warning: returning the result of a `let` binding from a block --> optd-core/src/memo/persistent_memo.rs:312:17 | 305 | / ... let group_id = sqlx::query_scalar("INSERT INTO filters (logical_expression_id, group_id, child_group_id, predicate_group_id) VALUES... 306 | | ... .bind(logical_expr_id) 307 | | ... .bind(group_id) 308 | | ... .bind(filter.child) 309 | | ... .bind(filter.predicate) 310 | | ... .fetch_one(&mut *txn) 311 | | ... .await?; | |__________________- unnecessary `let` binding 312 | ... group_id | ^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return help: return the expression directly | 305 ~ 306 ~ sqlx::query_scalar("INSERT INTO filters (logical_expression_id, group_id, child_group_id, predicate_group_id) VALUES ($1, $2, $3, $4) ON CONFLICT DO UPDATE SET group_id = group_id RETURNING group_id") 307 + .bind(logical_expr_id) 308 + .bind(group_id) 309 + .bind(filter.child) 310 + .bind(filter.predicate) 311 + .fetch_one(&mut *txn) 312 + .await? |

warning: returning the result of a `let` binding from a block --> optd-core/src/memo/persistent_memo.rs:329:17 | 322 | / ... let group_id = sqlx::query_scalar("INSERT INTO projects (logical_expression_id, group_id, child_group_id, fields_group_ids) VALUES ... 323 | | ... .bind(logical_expr_id) 324 | | ... .bind(group_id) 325 | | ... .bind(project.child) 326 | | ... .bind(serde_json::to_value(&project.fields)?) 327 | | ... .fetch_one(&mut *txn) 328 | | ... .await?; | |__________________- unnecessary `let` binding 329 | ... group_id | ^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return help: return the expression directly | 322 ~ 323 ~ sqlx::query_scalar("INSERT INTO projects (logical_expression_id, group_id, child_group_id, fields_group_ids) VALUES ($1, $2, $3, $4) ON CONFLICT DO UPDATE SET group_id = group_id RETURNING group_id") 324 + .bind(logical_expr_id) 325 + .bind(group_id) 326 + .bind(project.child) 327 + .bind(serde_json::to_value(&project.fields)?) 328 + .fetch_one(&mut *txn) 329 + .await? |

warning: returning the result of a `let` binding from a block --> optd-core/src/memo/persistent_memo.rs:348:17 | 339 | / ... let group_id = sqlx::query_scalar("INSERT INTO joins (logical_expression_id, group_id, join_type, left_group_id, right_group_id, co... 340 | | ... .bind(logical_expr_id) 341 | | ... .bind(group_id) 342 | | ... .bind(join.join_type) ... | 346 | | ... .fetch_one(&mut *txn) 347 | | ... .await?; | |__________________- unnecessary `let` binding 348 | ... group_id | ^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return help: return the expression directly | 339 ~ 340 ~ sqlx::query_scalar("INSERT INTO joins (logical_expression_id, group_id, join_type, left_group_id, right_group_id, condition_group_id) VALUES ($1, $2, $3, $4, $5, $6) ON CONFLICT DO UPDATE SET group_id = group_id RETURNING group_id") 341 + .bind(logical_expr_id) 342 + .bind(group_id) 343 + .bind(join.join_type) 344 + .bind(join.left) 345 + .bind(join.right) 346 + .bind(join.condition) 347 + .fetch_one(&mut *txn) 348 + .await? |

warning: missing documentation for an associated function --> optd-core/src/memo/persistent_memo.rs:369:5 | 369 | / async fn insert_into_logical_expressions( 370 | | txn: &mut SqliteConnection, 371 | | logical_expr_id: LogicalExpressionId, 372 | | group_id: GroupId, ... | 382 | | Ok(()) 383 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_docs_in_private_items

warning: missing documentation for a method --> optd-core/src/memo/persistent_memo.rs:385:5 | 385 | / async fn remove_dangling_logical_expr( 386 | | &self, 387 | | db: &mut SqliteConnection, 388 | | logical_expr_id: LogicalExpressionId, ... | 394 | | Ok(()) 395 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_docs_in_private_items

warning: missing documentation for a struct field --> optd-core/src/memo/persistent_memo.rs:436:13 | 436 | data: sqlx::types::Json<LogicalExpression>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_docs_in_private_items

warning: missing documentation for a struct field --> optd-core/src/memo/persistent_memo.rs:504:13 | 504 | data: sqlx::types::Json<ScalarExpression>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_docs_in_private_items

warning: missing documentation for a struct field --> optd-core/src/operator/relational/logical/scan.rs:23:5 | 23 | _phantom: PhantomData<Relation>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_docs_in_private_items

warning: missing documentation for a struct field --> optd-core/src/operator/relational/physical/scan/table_scan.rs:13:5 | 13 | _phantom: PhantomData<Relation>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_docs_in_private_items

warning: docs for function returning `Result` missing `# Errors` section --> optd-core/src/storage/sequence.rs:10:5 | 10 | pub async fn value(db: &mut SqliteConnection) -> anyhow::Result<i64> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc

warning: docs for function returning `Result` missing `# Errors` section --> optd-core/src/storage/sequence.rs:18:5 | 18 | pub async fn set_value(db: &mut SqliteConnection, value: i64) -> anyhow::Result<()> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc

warning: docs for function returning `Result` missing `# Errors` section --> optd-core/src/storage/mod.rs:23:5 | 23 | pub async fn new(database_url: &str) -> anyhow::Result<Self> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc

warning: docs for function returning `Result` missing `# Errors` section --> optd-core/src/storage/mod.rs:29:5 | 29 | pub async fn begin(&self) -> anyhow::Result<Transaction<'_>> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc

warning: deref which would be done by auto-deref --> optd-core/src/storage/mod.rs:31:45 | 31 | let current_value = Sequence::value(&mut *txn).await?; | ^^^^^^^^^ help: try: `&mut txn` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref = note: `#[warn(clippy::explicit_auto_deref)]` on by default

warning: docs for function returning `Result` missing `# Errors` section --> optd-core/src/storage/mod.rs:37:5 | 37 | pub async fn new_in_memory() -> anyhow::Result<Self> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc

warning: docs for function returning `Result` missing `# Errors` section --> optd-core/src/storage/mod.rs:42:5 | 42 | pub async fn migrate(&self) -> anyhow::Result<()> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc

warning: docs for function returning `Result` missing `# Errors` section --> optd-core/src/storage/mod.rs:51:5 | 51 | pub async fn db(&self) -> anyhow::Result<PoolConnection<sqlx::Sqlite>> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc

warning: missing documentation for a struct field --> optd-core/src/storage/mod.rs:61:5 | 61 | current_value: i64, | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_docs_in_private_items

warning: docs for function returning `Result` missing `# Errors` section --> optd-core/src/storage/mod.rs:66:5 | 66 | pub async fn commit(mut self) -> anyhow::Result<()> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc

warning: deref which would be done by auto-deref --> optd-core/src/storage/mod.rs:67:29 | 67 | Sequence::set_value(&mut *self.txn, self.current_value).await?; | ^^^^^^^^^^^^^^ help: try: `&mut self.txn` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref

warning: docs for function returning `Result` missing `# Errors` section --> optd-core/src/storage/mod.rs:73:5 | 73 | pub async fn new_group_id(&mut self) -> anyhow::Result<GroupId> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc

warning: docs for function returning `Result` missing `# Errors` section --> optd-core/src/storage/mod.rs:80:5 | 80 | pub async fn new_scalar_group_id(&mut self) -> anyhow::Result<ScalarGroupId> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc

warning: docs for function returning `Result` missing `# Errors` section --> optd-core/src/storage/mod.rs:87:5 | 87 | pub async fn new_logical_expression_id(&mut self) -> anyhow::Result<LogicalExpressionId> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc

warning: docs for function returning `Result` missing `# Errors` section --> optd-core/src/storage/mod.rs:94:5 | 94 | pub async fn new_physical_expression_id(&mut self) -> anyhow::Result<PhysicalExpressionId> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc

warning: docs for function returning `Result` missing `# Errors` section --> optd-core/src/storage/mod.rs:101:5 | 101 | pub async fn new_scalar_expression_id(&mut self) -> anyhow::Result<ScalarExpressionId> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc