Skip to content

[WIP] storage

[WIP] storage #110

Triggered via pull request February 3, 2025 03:11
Status Success
Total duration 59s
Artifacts

check.yml

on: pull_request
stable / fmt
11s
stable / fmt
ubuntu / stable / features
44s
ubuntu / stable / features
Matrix: clippy
Matrix: msrv
Fit to window
Zoom out
Zoom in

Annotations

54 warnings
[clippy] optd-core/src/memo/persistent_memo.rs#L11: optd-core/src/memo/persistent_memo.rs#L11
warning: missing documentation for a struct field --> optd-core/src/memo/persistent_memo.rs:11:5 | 11 | storage: StorageManager, | ^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_docs_in_private_items note: the lint level is defined here --> optd-core/src/lib.rs:4:9 | 4 | #![warn(clippy::missing_docs_in_private_items)] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[clippy] optd-core/src/memo/persistent_memo.rs#L12: optd-core/src/memo/persistent_memo.rs#L12
warning: missing documentation for a struct field --> optd-core/src/memo/persistent_memo.rs:12:5 | 12 | get_all_logical_exprs_in_group_query: String, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_docs_in_private_items
[clippy] optd-core/src/memo/persistent_memo.rs#L17: optd-core/src/memo/persistent_memo.rs#L17
warning: docs for function returning `Result` missing `# Errors` section --> optd-core/src/memo/persistent_memo.rs:17:5 | 17 | pub async fn new(database_url: &str) -> anyhow::Result<Self> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc note: the lint level is defined here --> optd-core/src/lib.rs:5:9 | 5 | #![warn(clippy::missing_errors_doc)] | ^^^^^^^^^^^^^^^^^^^^^^^^^^
[clippy] optd-core/src/memo/persistent_memo.rs#L33: optd-core/src/memo/persistent_memo.rs#L33
warning: docs for function returning `Result` missing `# Errors` section --> optd-core/src/memo/persistent_memo.rs:33:5 | 33 | pub async fn new_in_memory() -> anyhow::Result<Self> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc
[clippy] optd-core/src/memo/persistent_memo.rs#L67: optd-core/src/memo/persistent_memo.rs#L67
warning: missing documentation for a method --> optd-core/src/memo/persistent_memo.rs:67:5 | 67 | / async fn set_representative_group_id( 68 | | &self, 69 | | db: &mut SqliteConnection, 70 | | group_id: GroupId, ... | 78 | | Ok(()) 79 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_docs_in_private_items
[clippy] optd-core/src/memo/persistent_memo.rs#L81: optd-core/src/memo/persistent_memo.rs#L81
warning: missing documentation for a method --> optd-core/src/memo/persistent_memo.rs:81:5 | 81 | / async fn remove_dangling_logical_expr( 82 | | &self, 83 | | db: &mut SqliteConnection, 84 | | logical_expr_id: LogicalExpressionId, ... | 90 | | Ok(()) 91 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_docs_in_private_items
[clippy] optd-core/src/memo/persistent_memo.rs#L93: optd-core/src/memo/persistent_memo.rs#L93
warning: missing documentation for an associated function --> optd-core/src/memo/persistent_memo.rs:93:5 | 93 | / async fn insert_into_logical_expressions( 94 | | txn: &mut SqliteConnection, 95 | | logical_expr_id: LogicalExpressionId, 96 | | group_id: GroupId, ... | 106 | | Ok(()) 107 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_docs_in_private_items
[clippy] optd-core/src/memo/persistent_memo.rs#L109: optd-core/src/memo/persistent_memo.rs#L109
warning: missing documentation for a method --> optd-core/src/memo/persistent_memo.rs:109:5 | 109 | / async fn add_logical_expr_to_group_inner( 110 | | &self, 111 | | logical_expr: &LogicalExpression, 112 | | add_to_group_id: Option<GroupId>, ... | 209 | | Ok(inserted_group_id) 210 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_docs_in_private_items
[clippy] optd-core/src/memo/persistent_memo.rs#L251: optd-core/src/memo/persistent_memo.rs#L251
warning: missing documentation for a struct field --> optd-core/src/memo/persistent_memo.rs:251:13 | 251 | data: sqlx::types::Json<LogicalExpression>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_docs_in_private_items
[clippy] optd-core/src/operator/relational/logical/scan.rs#L23: optd-core/src/operator/relational/logical/scan.rs#L23
warning: missing documentation for a struct field --> optd-core/src/operator/relational/logical/scan.rs:23:5 | 23 | _phantom: PhantomData<Relation>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_docs_in_private_items
[clippy] optd-core/src/operator/relational/physical/scan/table_scan.rs#L13: optd-core/src/operator/relational/physical/scan/table_scan.rs#L13
warning: missing documentation for a struct field --> optd-core/src/operator/relational/physical/scan/table_scan.rs:13:5 | 13 | _phantom: PhantomData<Relation>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_docs_in_private_items
[clippy] optd-core/src/storage/sequence.rs#L10: optd-core/src/storage/sequence.rs#L10
warning: docs for function returning `Result` missing `# Errors` section --> optd-core/src/storage/sequence.rs:10:5 | 10 | pub async fn value(db: &mut SqliteConnection) -> anyhow::Result<i64> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc
[clippy] optd-core/src/storage/sequence.rs#L18: optd-core/src/storage/sequence.rs#L18
warning: docs for function returning `Result` missing `# Errors` section --> optd-core/src/storage/sequence.rs:18:5 | 18 | pub async fn set_value(db: &mut SqliteConnection, value: i64) -> anyhow::Result<()> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc
[clippy] optd-core/src/storage/mod.rs#L21: optd-core/src/storage/mod.rs#L21
warning: docs for function returning `Result` missing `# Errors` section --> optd-core/src/storage/mod.rs:21:5 | 21 | pub async fn new(database_url: &str) -> anyhow::Result<Self> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc
[clippy] optd-core/src/storage/mod.rs#L27: optd-core/src/storage/mod.rs#L27
warning: docs for function returning `Result` missing `# Errors` section --> optd-core/src/storage/mod.rs:27:5 | 27 | pub async fn begin(&self) -> anyhow::Result<Transaction<'_>> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc
[clippy] optd-core/src/storage/mod.rs#L29: optd-core/src/storage/mod.rs#L29
warning: deref which would be done by auto-deref --> optd-core/src/storage/mod.rs:29:45 | 29 | let current_value = Sequence::value(&mut *txn).await?; | ^^^^^^^^^ help: try: `&mut txn` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref = note: `#[warn(clippy::explicit_auto_deref)]` on by default
[clippy] optd-core/src/storage/mod.rs#L35: optd-core/src/storage/mod.rs#L35
warning: docs for function returning `Result` missing `# Errors` section --> optd-core/src/storage/mod.rs:35:5 | 35 | pub async fn new_in_memory() -> anyhow::Result<Self> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc
[clippy] optd-core/src/storage/mod.rs#L40: optd-core/src/storage/mod.rs#L40
warning: docs for function returning `Result` missing `# Errors` section --> optd-core/src/storage/mod.rs:40:5 | 40 | pub async fn migrate(&self) -> anyhow::Result<()> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc
[clippy] optd-core/src/storage/mod.rs#L49: optd-core/src/storage/mod.rs#L49
warning: docs for function returning `Result` missing `# Errors` section --> optd-core/src/storage/mod.rs:49:5 | 49 | pub async fn db(&self) -> anyhow::Result<PoolConnection<sqlx::Sqlite>> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc
[clippy] optd-core/src/storage/mod.rs#L59: optd-core/src/storage/mod.rs#L59
warning: missing documentation for a struct field --> optd-core/src/storage/mod.rs:59:5 | 59 | current_value: i64, | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_docs_in_private_items
[clippy] optd-core/src/storage/mod.rs#L64: optd-core/src/storage/mod.rs#L64
warning: docs for function returning `Result` missing `# Errors` section --> optd-core/src/storage/mod.rs:64:5 | 64 | pub async fn commit(mut self) -> anyhow::Result<()> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc
[clippy] optd-core/src/storage/mod.rs#L65: optd-core/src/storage/mod.rs#L65
warning: deref which would be done by auto-deref --> optd-core/src/storage/mod.rs:65:29 | 65 | Sequence::set_value(&mut *self.txn, self.current_value).await?; | ^^^^^^^^^^^^^^ help: try: `&mut self.txn` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref
[clippy] optd-core/src/storage/mod.rs#L71: optd-core/src/storage/mod.rs#L71
warning: docs for function returning `Result` missing `# Errors` section --> optd-core/src/storage/mod.rs:71:5 | 71 | pub async fn new_group_id(&mut self) -> anyhow::Result<GroupId> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc
[clippy] optd-core/src/storage/mod.rs#L78: optd-core/src/storage/mod.rs#L78
warning: docs for function returning `Result` missing `# Errors` section --> optd-core/src/storage/mod.rs:78:5 | 78 | pub async fn new_scalar_group_id(&mut self) -> anyhow::Result<ScalarGroupId> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc
[clippy] optd-core/src/storage/mod.rs#L85: optd-core/src/storage/mod.rs#L85
warning: docs for function returning `Result` missing `# Errors` section --> optd-core/src/storage/mod.rs:85:5 | 85 | pub async fn new_logical_expression_id(&mut self) -> anyhow::Result<LogicalExpressionId> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc
[clippy] optd-core/src/storage/mod.rs#L92: optd-core/src/storage/mod.rs#L92
warning: docs for function returning `Result` missing `# Errors` section --> optd-core/src/storage/mod.rs:92:5 | 92 | pub async fn new_physical_expression_id(&mut self) -> anyhow::Result<PhysicalExpressionId> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc
[clippy] optd-core/src/storage/mod.rs#L109: optd-core/src/storage/mod.rs#L109
warning: deref which would be done by auto-deref --> optd-core/src/storage/mod.rs:109:9 | 109 | &mut *self.txn | ^^^^^^^^^^^^^^ help: try: `&mut self.txn` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref
[clippy] optd-core/src/memo/persistent_memo.rs#L11: optd-core/src/memo/persistent_memo.rs#L11
warning: missing documentation for a struct field --> optd-core/src/memo/persistent_memo.rs:11:5 | 11 | storage: StorageManager, | ^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_docs_in_private_items note: the lint level is defined here --> optd-core/src/lib.rs:4:9 | 4 | #![warn(clippy::missing_docs_in_private_items)] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[clippy] optd-core/src/memo/persistent_memo.rs#L12: optd-core/src/memo/persistent_memo.rs#L12
warning: missing documentation for a struct field --> optd-core/src/memo/persistent_memo.rs:12:5 | 12 | get_all_logical_exprs_in_group_query: String, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_docs_in_private_items
[clippy] optd-core/src/memo/persistent_memo.rs#L17: optd-core/src/memo/persistent_memo.rs#L17
warning: docs for function returning `Result` missing `# Errors` section --> optd-core/src/memo/persistent_memo.rs:17:5 | 17 | pub async fn new(database_url: &str) -> anyhow::Result<Self> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc note: the lint level is defined here --> optd-core/src/lib.rs:5:9 | 5 | #![warn(clippy::missing_errors_doc)] | ^^^^^^^^^^^^^^^^^^^^^^^^^^
[clippy] optd-core/src/memo/persistent_memo.rs#L33: optd-core/src/memo/persistent_memo.rs#L33
warning: docs for function returning `Result` missing `# Errors` section --> optd-core/src/memo/persistent_memo.rs:33:5 | 33 | pub async fn new_in_memory() -> anyhow::Result<Self> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc
[clippy] optd-core/src/memo/persistent_memo.rs#L67: optd-core/src/memo/persistent_memo.rs#L67
warning: missing documentation for a method --> optd-core/src/memo/persistent_memo.rs:67:5 | 67 | / async fn set_representative_group_id( 68 | | &self, 69 | | db: &mut SqliteConnection, 70 | | group_id: GroupId, ... | 78 | | Ok(()) 79 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_docs_in_private_items
[clippy] optd-core/src/memo/persistent_memo.rs#L81: optd-core/src/memo/persistent_memo.rs#L81
warning: missing documentation for a method --> optd-core/src/memo/persistent_memo.rs:81:5 | 81 | / async fn remove_dangling_logical_expr( 82 | | &self, 83 | | db: &mut SqliteConnection, 84 | | logical_expr_id: LogicalExpressionId, ... | 90 | | Ok(()) 91 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_docs_in_private_items
[clippy] optd-core/src/memo/persistent_memo.rs#L93: optd-core/src/memo/persistent_memo.rs#L93
warning: missing documentation for an associated function --> optd-core/src/memo/persistent_memo.rs:93:5 | 93 | / async fn insert_into_logical_expressions( 94 | | txn: &mut SqliteConnection, 95 | | logical_expr_id: LogicalExpressionId, 96 | | group_id: GroupId, ... | 106 | | Ok(()) 107 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_docs_in_private_items
[clippy] optd-core/src/memo/persistent_memo.rs#L109: optd-core/src/memo/persistent_memo.rs#L109
warning: missing documentation for a method --> optd-core/src/memo/persistent_memo.rs:109:5 | 109 | / async fn add_logical_expr_to_group_inner( 110 | | &self, 111 | | logical_expr: &LogicalExpression, 112 | | add_to_group_id: Option<GroupId>, ... | 209 | | Ok(inserted_group_id) 210 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_docs_in_private_items
[clippy] optd-core/src/memo/persistent_memo.rs#L251: optd-core/src/memo/persistent_memo.rs#L251
warning: missing documentation for a struct field --> optd-core/src/memo/persistent_memo.rs:251:13 | 251 | data: sqlx::types::Json<LogicalExpression>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_docs_in_private_items
[clippy] optd-core/src/operator/relational/logical/scan.rs#L23: optd-core/src/operator/relational/logical/scan.rs#L23
warning: missing documentation for a struct field --> optd-core/src/operator/relational/logical/scan.rs:23:5 | 23 | _phantom: PhantomData<Relation>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_docs_in_private_items
[clippy] optd-core/src/operator/relational/physical/scan/table_scan.rs#L13: optd-core/src/operator/relational/physical/scan/table_scan.rs#L13
warning: missing documentation for a struct field --> optd-core/src/operator/relational/physical/scan/table_scan.rs:13:5 | 13 | _phantom: PhantomData<Relation>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_docs_in_private_items
[clippy] optd-core/src/storage/sequence.rs#L10: optd-core/src/storage/sequence.rs#L10
warning: docs for function returning `Result` missing `# Errors` section --> optd-core/src/storage/sequence.rs:10:5 | 10 | pub async fn value(db: &mut SqliteConnection) -> anyhow::Result<i64> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc
[clippy] optd-core/src/storage/sequence.rs#L18: optd-core/src/storage/sequence.rs#L18
warning: docs for function returning `Result` missing `# Errors` section --> optd-core/src/storage/sequence.rs:18:5 | 18 | pub async fn set_value(db: &mut SqliteConnection, value: i64) -> anyhow::Result<()> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc
[clippy] optd-core/src/storage/mod.rs#L21: optd-core/src/storage/mod.rs#L21
warning: docs for function returning `Result` missing `# Errors` section --> optd-core/src/storage/mod.rs:21:5 | 21 | pub async fn new(database_url: &str) -> anyhow::Result<Self> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc
[clippy] optd-core/src/storage/mod.rs#L27: optd-core/src/storage/mod.rs#L27
warning: docs for function returning `Result` missing `# Errors` section --> optd-core/src/storage/mod.rs:27:5 | 27 | pub async fn begin(&self) -> anyhow::Result<Transaction<'_>> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc
[clippy] optd-core/src/storage/mod.rs#L29: optd-core/src/storage/mod.rs#L29
warning: deref which would be done by auto-deref --> optd-core/src/storage/mod.rs:29:45 | 29 | let current_value = Sequence::value(&mut *txn).await?; | ^^^^^^^^^ help: try: `&mut txn` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref = note: `#[warn(clippy::explicit_auto_deref)]` on by default
[clippy] optd-core/src/storage/mod.rs#L35: optd-core/src/storage/mod.rs#L35
warning: docs for function returning `Result` missing `# Errors` section --> optd-core/src/storage/mod.rs:35:5 | 35 | pub async fn new_in_memory() -> anyhow::Result<Self> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc
[clippy] optd-core/src/storage/mod.rs#L40: optd-core/src/storage/mod.rs#L40
warning: docs for function returning `Result` missing `# Errors` section --> optd-core/src/storage/mod.rs:40:5 | 40 | pub async fn migrate(&self) -> anyhow::Result<()> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc
[clippy] optd-core/src/storage/mod.rs#L49: optd-core/src/storage/mod.rs#L49
warning: docs for function returning `Result` missing `# Errors` section --> optd-core/src/storage/mod.rs:49:5 | 49 | pub async fn db(&self) -> anyhow::Result<PoolConnection<sqlx::Sqlite>> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc
[clippy] optd-core/src/storage/mod.rs#L59: optd-core/src/storage/mod.rs#L59
warning: missing documentation for a struct field --> optd-core/src/storage/mod.rs:59:5 | 59 | current_value: i64, | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_docs_in_private_items
[clippy] optd-core/src/storage/mod.rs#L64: optd-core/src/storage/mod.rs#L64
warning: docs for function returning `Result` missing `# Errors` section --> optd-core/src/storage/mod.rs:64:5 | 64 | pub async fn commit(mut self) -> anyhow::Result<()> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc
[clippy] optd-core/src/storage/mod.rs#L65: optd-core/src/storage/mod.rs#L65
warning: deref which would be done by auto-deref --> optd-core/src/storage/mod.rs:65:29 | 65 | Sequence::set_value(&mut *self.txn, self.current_value).await?; | ^^^^^^^^^^^^^^ help: try: `&mut self.txn` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref
[clippy] optd-core/src/storage/mod.rs#L71: optd-core/src/storage/mod.rs#L71
warning: docs for function returning `Result` missing `# Errors` section --> optd-core/src/storage/mod.rs:71:5 | 71 | pub async fn new_group_id(&mut self) -> anyhow::Result<GroupId> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc
[clippy] optd-core/src/storage/mod.rs#L78: optd-core/src/storage/mod.rs#L78
warning: docs for function returning `Result` missing `# Errors` section --> optd-core/src/storage/mod.rs:78:5 | 78 | pub async fn new_scalar_group_id(&mut self) -> anyhow::Result<ScalarGroupId> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc
[clippy] optd-core/src/storage/mod.rs#L85: optd-core/src/storage/mod.rs#L85
warning: docs for function returning `Result` missing `# Errors` section --> optd-core/src/storage/mod.rs:85:5 | 85 | pub async fn new_logical_expression_id(&mut self) -> anyhow::Result<LogicalExpressionId> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc
[clippy] optd-core/src/storage/mod.rs#L92: optd-core/src/storage/mod.rs#L92
warning: docs for function returning `Result` missing `# Errors` section --> optd-core/src/storage/mod.rs:92:5 | 92 | pub async fn new_physical_expression_id(&mut self) -> anyhow::Result<PhysicalExpressionId> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc
[clippy] optd-core/src/storage/mod.rs#L109: optd-core/src/storage/mod.rs#L109
warning: deref which would be done by auto-deref --> optd-core/src/storage/mod.rs:109:9 | 109 | &mut *self.txn | ^^^^^^^^^^^^^^ help: try: `&mut self.txn` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref