Skip to content

WIP Built some initial e2e datafusion infrastructure #106

WIP Built some initial e2e datafusion infrastructure

WIP Built some initial e2e datafusion infrastructure #106

Triggered via pull request January 31, 2025 01:00
Status Failure
Total duration 1m 35s
Artifacts

check.yml

on: pull_request
stable / fmt
15s
stable / fmt
ubuntu / stable / features
1m 26s
ubuntu / stable / features
Matrix: clippy
Matrix: msrv
Fit to window
Zoom out
Zoom in

Annotations

1 error and 88 warnings
ubuntu / 1.78.0
Process completed with exit code 101.
[clippy] infra/src/lib.rs#L9: infra/src/lib.rs#L9
warning: unused import: `std::collections::HashMap` --> infra/src/lib.rs:9:5 | 9 | use std::collections::HashMap; | ^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(unused_imports)]` on by default
[clippy] infra/src/lib.rs#L10: infra/src/lib.rs#L10
warning: unused import: `Mutex` --> infra/src/lib.rs:10:22 | 10 | use std::sync::{Arc, Mutex}; | ^^^^^
[clippy] infra/src/lib.rs#L19: infra/src/lib.rs#L19
warning: unused imports: `Explain`, `PlanType`, `TableSource`, and `ToStringifiedPlan` --> infra/src/lib.rs:19:5 | 19 | Explain, LogicalPlan as DatafusionLogicalPlan, PlanType, TableSource, ToStringifiedPlan, | ^^^^^^^ ^^^^^^^^ ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^
[clippy] infra/src/lib.rs#L23: infra/src/lib.rs#L23
warning: unused import: `log` --> infra/src/lib.rs:23:27 | 23 | use datafusion::prelude::{log, Expr, SessionConfig, SessionContext}; | ^^^
[clippy] infra/src/lib.rs#L26: infra/src/lib.rs#L26
warning: unused import: `types::operator::scalar::column_ref::ColumnRef` --> infra/src/lib.rs:26:5 | 26 | use types::operator::scalar::column_ref::ColumnRef; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[clippy] infra/src/lib.rs#L179: infra/src/lib.rs#L179
warning: redundant field names in struct initialization --> infra/src/lib.rs:179:22 | 179 | ScalarPlan { node: node } | ^^^^^^^^^^ help: replace it with: `node` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names = note: `#[warn(clippy::redundant_field_names)]` on by default
[clippy] infra/src/lib.rs#L195: infra/src/lib.rs#L195
warning: redundant field names in struct initialization --> infra/src/lib.rs:195:23 | 195 | LogicalPlan { node: node } | ^^^^^^^^^^ help: replace it with: `node` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[clippy] infra/src/lib.rs#L16: infra/src/lib.rs#L16
warning: use of deprecated type alias `datafusion::execution::runtime_env::RuntimeConfig`: please use `RuntimeEnvBuilder` instead --> infra/src/lib.rs:16:41 | 16 | use datafusion::execution::runtime_env::RuntimeConfig; | ^^^^^^^^^^^^^ | = note: `#[warn(deprecated)]` on by default
[clippy] infra/src/lib.rs#L221: infra/src/lib.rs#L221
warning: use of deprecated type alias `datafusion::execution::runtime_env::RuntimeConfig`: please use `RuntimeEnvBuilder` instead --> infra/src/lib.rs:221:23 | 221 | rn_config: Option<RuntimeConfig>, | ^^^^^^^^^^^^^
[clippy] infra/src/lib.rs#L236: infra/src/lib.rs#L236
warning: use of deprecated type alias `datafusion::execution::runtime_env::RuntimeConfig`: please use `RuntimeEnvBuilder` instead --> infra/src/lib.rs:236:9 | 236 | RuntimeConfig::new() | ^^^^^^^^^^^^^
[clippy] infra/src/lib.rs#L153: infra/src/lib.rs#L153
warning: unused variable: `optdLogicalPlan` --> infra/src/lib.rs:153:13 | 153 | let optdLogicalPlan = Self::conv_df_to_optd_relational(logical_plan); | ^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_optdLogicalPlan` | = note: `#[warn(unused_variables)]` on by default
[clippy] infra/src/lib.rs#L154: infra/src/lib.rs#L154
warning: unused variable: `optimizer` --> infra/src/lib.rs:154:17 | 154 | let mut optimizer = self.optimizer.clone(); | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_optimizer`
[clippy] infra/src/lib.rs#L154: infra/src/lib.rs#L154
warning: variable does not need to be mutable --> infra/src/lib.rs:154:13 | 154 | let mut optimizer = self.optimizer.clone(); | ----^^^^^^^^^ | | | help: remove this `mut` | = note: `#[warn(unused_mut)]` on by default
[clippy] infra/src/lib.rs#L179: infra/src/lib.rs#L179
warning: unreachable expression --> infra/src/lib.rs:179:9 | 172 | let node = match df_expr { | ____________________- 173 | | Expr::Column(column) => todo!(), 174 | | Expr::Literal(scalar_value) => todo!(), 175 | | Expr::BinaryExpr(binary_expr) => todo!(), 176 | | _ => panic!("OptD does not support this scalar expression"), 177 | | }; | |_________- any code following this `match` expression is unreachable, as all arms diverge 178 | 179 | ScalarPlan { node: node } | ^^^^^^^^^^^^^^^^^^^^^^^^^ unreachable expression | = note: `#[warn(unreachable_code)]` on by default
[clippy] infra/src/lib.rs#L172: infra/src/lib.rs#L172
warning: unused variable: `node` --> infra/src/lib.rs:172:13 | 172 | let node = match df_expr { | ^^^^ help: if this is intentional, prefix it with an underscore: `_node`
[clippy] infra/src/lib.rs#L173: infra/src/lib.rs#L173
warning: unused variable: `column` --> infra/src/lib.rs:173:26 | 173 | Expr::Column(column) => todo!(), | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_column`
[clippy] infra/src/lib.rs#L174: infra/src/lib.rs#L174
warning: unused variable: `scalar_value` --> infra/src/lib.rs:174:27 | 174 | Expr::Literal(scalar_value) => todo!(), | ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_scalar_value`
[clippy] infra/src/lib.rs#L175: infra/src/lib.rs#L175
warning: unused variable: `binary_expr` --> infra/src/lib.rs:175:30 | 175 | Expr::BinaryExpr(binary_expr) => todo!(), | ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_binary_expr`
[clippy] infra/src/lib.rs#L191: infra/src/lib.rs#L191
warning: unused variable: `join` --> infra/src/lib.rs:191:41 | 191 | DatafusionLogicalPlan::Join(join) => todo!(), | ^^^^ help: if this is intentional, prefix it with an underscore: `_join`
[clippy] infra/src/lib.rs#L192: infra/src/lib.rs#L192
warning: unused variable: `table_scan` --> infra/src/lib.rs:192:46 | 192 | DatafusionLogicalPlan::TableScan(table_scan) => todo!(), | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_table_scan`
[clippy] infra/src/lib.rs#L91: infra/src/lib.rs#L91
warning: type `OptdOptimizer` is more private than the item `OptdQueryPlanner::optimizer` --> infra/src/lib.rs:91:5 | 91 | pub optimizer: Arc<OptdOptimizer>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ field `OptdQueryPlanner::optimizer` is reachable at visibility `pub` | note: but type `OptdOptimizer` is only usable at visibility `pub(crate)` --> infra/src/lib.rs:41:1 | 41 | struct OptdOptimizer {} | ^^^^^^^^^^^^^^^^^^^^ = note: `#[warn(private_interfaces)]` on by default
[clippy] infra/src/lib.rs#L165: infra/src/lib.rs#L165
warning: type `OptdOptimizer` is more private than the item `OptdQueryPlanner::new` --> infra/src/lib.rs:165:5 | 165 | pub fn new(optimizer: OptdOptimizer) -> Self { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ associated function `OptdQueryPlanner::new` is reachable at visibility `pub` | note: but type `OptdOptimizer` is only usable at visibility `pub(crate)` --> infra/src/lib.rs:41:1 | 41 | struct OptdOptimizer {} | ^^^^^^^^^^^^^^^^^^^^
[clippy] infra/src/types/memo.rs#L56: infra/src/types/memo.rs#L56
warning: method `add_logical_expr_to_group` is never used --> infra/src/types/memo.rs:58:18 | 56 | impl Memo { | --------- method in this implementation 57 | /// TODO(alexis) Add docs. 58 | pub async fn add_logical_expr_to_group( | ^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default
[clippy] infra/src/types/operator/relational/logical/mod.rs#L26: infra/src/types/operator/relational/logical/mod.rs#L26
warning: variants `Scan`, `Project`, and `Join` are never constructed --> infra/src/types/operator/relational/logical/mod.rs:27:5 | 26 | pub enum LogicalOperator<Relation, Scalar> { | --------------- variants in this enum 27 | Scan(Scan<Scalar>), | ^^^^ 28 | Filter(Filter<Relation, Scalar>), 29 | Project(Project<Relation, Scalar>), | ^^^^^^^ 30 | Join(Join<Relation, Scalar>), | ^^^^ | = note: `LogicalOperator` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis
[clippy] infra/src/types/operator/relational/logical/project.rs#L6: infra/src/types/operator/relational/logical/project.rs#L6
warning: fields `child` and `fields` are never read --> infra/src/types/operator/relational/logical/project.rs:7:9 | 6 | pub struct Project<Relation, Scalar> { | ------- fields in this struct 7 | pub child: Relation, | ^^^^^ 8 | pub fields: Vec<Scalar>, | ^^^^^^ | = note: `Project` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis
[clippy] infra/src/types/operator/relational/physical/mod.rs#L26: infra/src/types/operator/relational/physical/mod.rs#L26
warning: variants `Project`, `NestedLoopJoin`, and `SortMergeJoin` are never constructed --> infra/src/types/operator/relational/physical/mod.rs:29:5 | 26 | pub enum PhysicalOperator<Relation, Scalar> { | ---------------- variants in this enum ... 29 | Project(Project<Relation, Scalar>), | ^^^^^^^ 30 | HashJoin(HashJoin<Relation, Scalar>), 31 | NestedLoopJoin(NestedLoopJoin<Relation, Scalar>), | ^^^^^^^^^^^^^^ 32 | SortMergeJoin(MergeJoin<Relation, Scalar>), | ^^^^^^^^^^^^^ | = note: `PhysicalOperator` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis
[clippy] infra/src/types/operator/relational/physical/filter/filter.rs#L7: infra/src/types/operator/relational/physical/filter/filter.rs#L7
warning: fields `child` and `predicate` are never read --> infra/src/types/operator/relational/physical/filter/filter.rs:8:9 | 7 | pub struct Filter<Relation, Scalar> { | ------ fields in this struct 8 | pub child: Relation, | ^^^^^ 9 | pub predicate: Scalar, | ^^^^^^^^^ | = note: `Filter` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis
[clippy] infra/src/types/operator/relational/physical/join/hash_join.rs#L7: infra/src/types/operator/relational/physical/join/hash_join.rs#L7
warning: fields `join_type`, `probe_side`, `build_side`, and `condition` are never read --> infra/src/types/operator/relational/physical/join/hash_join.rs:8:9 | 7 | pub struct HashJoin<Relation, Scalar> { | -------- fields in this struct 8 | pub join_type: String, | ^^^^^^^^^ 9 | /// Left relation that probes hash table. 10 | pub probe_side: Relation, | ^^^^^^^^^^ 11 | /// Right relation used to build hash table. 12 | pub build_side: Relation, | ^^^^^^^^^^ 13 | pub condition: Scalar, | ^^^^^^^^^ | = note: `HashJoin` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis
[clippy] infra/src/types/operator/relational/physical/join/merge_join.rs#L6: infra/src/types/operator/relational/physical/join/merge_join.rs#L6
warning: fields `join_type`, `left_sorted`, `right_sorted`, and `condition` are never read --> infra/src/types/operator/relational/physical/join/merge_join.rs:7:9 | 6 | pub struct MergeJoin<Relation, Scalar> { | --------- fields in this struct 7 | pub join_type: String, | ^^^^^^^^^ 8 | /// Left sorted relation. 9 | pub left_sorted: Relation, | ^^^^^^^^^^^ 10 | /// Right sorted relation. 11 | pub right_sorted: Relation, | ^^^^^^^^^^^^ 12 | pub condition: Scalar, | ^^^^^^^^^ | = note: `MergeJoin` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis
[clippy] infra/src/types/operator/relational/physical/join/nested_loop_join.rs#L6: infra/src/types/operator/relational/physical/join/nested_loop_join.rs#L6
warning: fields `join_type`, `outer`, `inner`, and `condition` are never read --> infra/src/types/operator/relational/physical/join/nested_loop_join.rs:7:9 | 6 | pub struct NestedLoopJoin<Relation, Scalar> { | -------------- fields in this struct 7 | pub join_type: String, | ^^^^^^^^^ 8 | /// Outer relation. 9 | pub outer: Relation, | ^^^^^ 10 | /// Inner relation scanned for each outer row. 11 | pub inner: Relation, | ^^^^^ 12 | pub condition: Scalar, | ^^^^^^^^^ | = note: `NestedLoopJoin` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis
[clippy] infra/src/types/operator/relational/physical/project/project.rs#L6: infra/src/types/operator/relational/physical/project/project.rs#L6
warning: fields `child` and `fields` are never read --> infra/src/types/operator/relational/physical/project/project.rs:7:9 | 6 | pub struct Project<Relation, Scalar> { | ------- fields in this struct 7 | pub child: Relation, | ^^^^^ 8 | pub fields: Vec<Scalar>, | ^^^^^^ | = note: `Project` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis
[clippy] infra/src/types/operator/relational/physical/scan/table_scan.rs#L6: infra/src/types/operator/relational/physical/scan/table_scan.rs#L6
warning: fields `table_name` and `predicate` are never read --> infra/src/types/operator/relational/physical/scan/table_scan.rs:7:9 | 6 | pub struct TableScan<Scalar> { | --------- fields in this struct 7 | pub table_name: String, // TODO(alexis): Mocked for now. | ^^^^^^^^^^ 8 | pub predicate: Option<Scalar>, | ^^^^^^^^^ | = note: `TableScan` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis
[clippy] infra/src/types/operator/scalar/mod.rs#L22: infra/src/types/operator/scalar/mod.rs#L22
warning: variants `Add`, `ColumnRef`, and `Constant` are never constructed --> infra/src/types/operator/scalar/mod.rs:23:5 | 22 | pub enum ScalarOperator<Scalar> { | -------------- variants in this enum 23 | Add(Add<Scalar>), | ^^^ 24 | ColumnRef(ColumnRef), | ^^^^^^^^^ 25 | Constant(Constant), | ^^^^^^^^ | = note: `ScalarOperator` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis
[clippy] infra/src/types/operator/scalar/add.rs#L3: infra/src/types/operator/scalar/add.rs#L3
warning: fields `left` and `right` are never read --> infra/src/types/operator/scalar/add.rs:4:9 | 3 | pub struct Add<Scalar> { | --- fields in this struct 4 | pub left: Scalar, | ^^^^ 5 | pub right: Scalar, | ^^^^^ | = note: `Add` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis
[clippy] infra/src/types/operator/scalar/constants.rs#L3: infra/src/types/operator/scalar/constants.rs#L3
warning: variants `String`, `Integer`, `Float`, and `Boolean` are never constructed --> infra/src/types/operator/scalar/constants.rs:5:5 | 3 | pub enum Constant { | -------- variants in this enum 4 | /// String constant (e.g. "hello"). 5 | String(String), | ^^^^^^ 6 | /// Integer constant (e.g. 42). 7 | Integer(i64), | ^^^^^^^ 8 | /// Floating point constant (e.g. 3.14). 9 | Float(f64), | ^^^^^ 10 | /// Boolean constant (e.g. true, false). 11 | Boolean(bool), | ^^^^^^^ | = note: `Constant` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis
[clippy] infra/src/types/plan/logical_plan.rs#L17: infra/src/types/plan/logical_plan.rs#L17
warning: field `node` is never read --> infra/src/types/plan/logical_plan.rs:18:9 | 17 | pub struct LogicalPlan { | ----------- field in this struct 18 | pub node: Arc<LogicalOperator<LogicalPlan, ScalarPlan>>, | ^^^^ | = note: `LogicalPlan` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis
[clippy] infra/src/types/plan/partial_logical_plan.rs#L26: infra/src/types/plan/partial_logical_plan.rs#L26
warning: field `node` is never read --> infra/src/types/plan/partial_logical_plan.rs:27:9 | 26 | pub struct PartialLogicalPlan { | ------------------ field in this struct 27 | pub node: Arc<LogicalOperator<Relation, Scalar>>, | ^^^^ | = note: `PartialLogicalPlan` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis
[clippy] infra/src/types/plan/partial_logical_plan.rs#L36: infra/src/types/plan/partial_logical_plan.rs#L36
warning: variants `Operator` and `GroupId` are never constructed --> infra/src/types/plan/partial_logical_plan.rs:37:5 | 36 | pub enum Relation { | -------- variants in this enum 37 | Operator(Arc<LogicalOperator<Relation, Scalar>>), | ^^^^^^^^ 38 | GroupId(GroupId), | ^^^^^^^ | = note: `Relation` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis
[clippy] infra/src/types/plan/partial_logical_plan.rs#L47: infra/src/types/plan/partial_logical_plan.rs#L47
warning: variants `Operator` and `GroupId` are never constructed --> infra/src/types/plan/partial_logical_plan.rs:48:5 | 47 | pub enum Scalar { | ------ variants in this enum 48 | Operator(Arc<ScalarOperator<Scalar>>), | ^^^^^^^^ 49 | GroupId(GroupId), | ^^^^^^^ | = note: `Scalar` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis
[clippy] infra/src/types/plan/physical_plan.rs#L17: infra/src/types/plan/physical_plan.rs#L17
warning: struct `PhysicalPlan` is never constructed --> infra/src/types/plan/physical_plan.rs:17:12 | 17 | pub struct PhysicalPlan { | ^^^^^^^^^^^^ | = note: `PhysicalPlan` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis
[clippy] infra/src/types/plan/scalar_plan.rs#L7: infra/src/types/plan/scalar_plan.rs#L7
warning: field `node` is never read --> infra/src/types/plan/scalar_plan.rs:8:9 | 7 | pub struct ScalarPlan { | ---------- field in this struct 8 | pub node: Arc<ScalarOperator<ScalarPlan>>, | ^^^^ | = note: `ScalarPlan` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis
[clippy] infra/src/lib.rs#L153: infra/src/lib.rs#L153
warning: variable `optdLogicalPlan` should have a snake case name --> infra/src/lib.rs:153:13 | 153 | let optdLogicalPlan = Self::conv_df_to_optd_relational(logical_plan); | ^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `optd_logical_plan` | = note: `#[warn(non_snake_case)]` on by default
[clippy] infra/src/main.rs#L4: infra/src/main.rs#L4
warning: use of deprecated type alias `datafusion::execution::runtime_env::RuntimeConfig`: please use `RuntimeEnvBuilder` instead --> infra/src/main.rs:4:41 | 4 | use datafusion::execution::runtime_env::RuntimeConfig; | ^^^^^^^^^^^^^ | = note: `#[warn(deprecated)]` on by default
[clippy] infra/src/main.rs#L15: infra/src/main.rs#L15
warning: use of deprecated type alias `datafusion::execution::runtime_env::RuntimeConfig`: please use `RuntimeEnvBuilder` instead --> infra/src/main.rs:15:21 | 15 | let rt_config = RuntimeConfig::new(); | ^^^^^^^^^^^^^
[clippy] infra/src/lib.rs#L9: infra/src/lib.rs#L9
warning: unused import: `std::collections::HashMap` --> infra/src/lib.rs:9:5 | 9 | use std::collections::HashMap; | ^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(unused_imports)]` on by default
[clippy] infra/src/lib.rs#L10: infra/src/lib.rs#L10
warning: unused import: `Mutex` --> infra/src/lib.rs:10:22 | 10 | use std::sync::{Arc, Mutex}; | ^^^^^
[clippy] infra/src/lib.rs#L19: infra/src/lib.rs#L19
warning: unused imports: `Explain`, `PlanType`, `TableSource`, and `ToStringifiedPlan` --> infra/src/lib.rs:19:5 | 19 | Explain, LogicalPlan as DatafusionLogicalPlan, PlanType, TableSource, ToStringifiedPlan, | ^^^^^^^ ^^^^^^^^ ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^
[clippy] infra/src/lib.rs#L23: infra/src/lib.rs#L23
warning: unused import: `log` --> infra/src/lib.rs:23:27 | 23 | use datafusion::prelude::{log, Expr, SessionConfig, SessionContext}; | ^^^
[clippy] infra/src/lib.rs#L26: infra/src/lib.rs#L26
warning: unused import: `types::operator::scalar::column_ref::ColumnRef` --> infra/src/lib.rs:26:5 | 26 | use types::operator::scalar::column_ref::ColumnRef; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[clippy] infra/src/lib.rs#L179: infra/src/lib.rs#L179
warning: redundant field names in struct initialization --> infra/src/lib.rs:179:22 | 179 | ScalarPlan { node: node } | ^^^^^^^^^^ help: replace it with: `node` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names = note: `#[warn(clippy::redundant_field_names)]` on by default
[clippy] infra/src/lib.rs#L195: infra/src/lib.rs#L195
warning: redundant field names in struct initialization --> infra/src/lib.rs:195:23 | 195 | LogicalPlan { node: node } | ^^^^^^^^^^ help: replace it with: `node` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[clippy] infra/src/lib.rs#L16: infra/src/lib.rs#L16
warning: use of deprecated type alias `datafusion::execution::runtime_env::RuntimeConfig`: please use `RuntimeEnvBuilder` instead --> infra/src/lib.rs:16:41 | 16 | use datafusion::execution::runtime_env::RuntimeConfig; | ^^^^^^^^^^^^^ | = note: `#[warn(deprecated)]` on by default
[clippy] infra/src/lib.rs#L221: infra/src/lib.rs#L221
warning: use of deprecated type alias `datafusion::execution::runtime_env::RuntimeConfig`: please use `RuntimeEnvBuilder` instead --> infra/src/lib.rs:221:23 | 221 | rn_config: Option<RuntimeConfig>, | ^^^^^^^^^^^^^
[clippy] infra/src/lib.rs#L236: infra/src/lib.rs#L236
warning: use of deprecated type alias `datafusion::execution::runtime_env::RuntimeConfig`: please use `RuntimeEnvBuilder` instead --> infra/src/lib.rs:236:9 | 236 | RuntimeConfig::new() | ^^^^^^^^^^^^^
[clippy] infra/src/lib.rs#L153: infra/src/lib.rs#L153
warning: unused variable: `optdLogicalPlan` --> infra/src/lib.rs:153:13 | 153 | let optdLogicalPlan = Self::conv_df_to_optd_relational(logical_plan); | ^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_optdLogicalPlan` | = note: `#[warn(unused_variables)]` on by default
[clippy] infra/src/lib.rs#L154: infra/src/lib.rs#L154
warning: unused variable: `optimizer` --> infra/src/lib.rs:154:17 | 154 | let mut optimizer = self.optimizer.clone(); | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_optimizer`
[clippy] infra/src/lib.rs#L154: infra/src/lib.rs#L154
warning: variable does not need to be mutable --> infra/src/lib.rs:154:13 | 154 | let mut optimizer = self.optimizer.clone(); | ----^^^^^^^^^ | | | help: remove this `mut` | = note: `#[warn(unused_mut)]` on by default
[clippy] infra/src/lib.rs#L179: infra/src/lib.rs#L179
warning: unreachable expression --> infra/src/lib.rs:179:9 | 172 | let node = match df_expr { | ____________________- 173 | | Expr::Column(column) => todo!(), 174 | | Expr::Literal(scalar_value) => todo!(), 175 | | Expr::BinaryExpr(binary_expr) => todo!(), 176 | | _ => panic!("OptD does not support this scalar expression"), 177 | | }; | |_________- any code following this `match` expression is unreachable, as all arms diverge 178 | 179 | ScalarPlan { node: node } | ^^^^^^^^^^^^^^^^^^^^^^^^^ unreachable expression | = note: `#[warn(unreachable_code)]` on by default
[clippy] infra/src/lib.rs#L172: infra/src/lib.rs#L172
warning: unused variable: `node` --> infra/src/lib.rs:172:13 | 172 | let node = match df_expr { | ^^^^ help: if this is intentional, prefix it with an underscore: `_node`
[clippy] infra/src/lib.rs#L173: infra/src/lib.rs#L173
warning: unused variable: `column` --> infra/src/lib.rs:173:26 | 173 | Expr::Column(column) => todo!(), | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_column`
[clippy] infra/src/lib.rs#L174: infra/src/lib.rs#L174
warning: unused variable: `scalar_value` --> infra/src/lib.rs:174:27 | 174 | Expr::Literal(scalar_value) => todo!(), | ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_scalar_value`
[clippy] infra/src/lib.rs#L175: infra/src/lib.rs#L175
warning: unused variable: `binary_expr` --> infra/src/lib.rs:175:30 | 175 | Expr::BinaryExpr(binary_expr) => todo!(), | ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_binary_expr`
[clippy] infra/src/lib.rs#L191: infra/src/lib.rs#L191
warning: unused variable: `join` --> infra/src/lib.rs:191:41 | 191 | DatafusionLogicalPlan::Join(join) => todo!(), | ^^^^ help: if this is intentional, prefix it with an underscore: `_join`
[clippy] infra/src/lib.rs#L192: infra/src/lib.rs#L192
warning: unused variable: `table_scan` --> infra/src/lib.rs:192:46 | 192 | DatafusionLogicalPlan::TableScan(table_scan) => todo!(), | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_table_scan`
[clippy] infra/src/lib.rs#L91: infra/src/lib.rs#L91
warning: type `OptdOptimizer` is more private than the item `OptdQueryPlanner::optimizer` --> infra/src/lib.rs:91:5 | 91 | pub optimizer: Arc<OptdOptimizer>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ field `OptdQueryPlanner::optimizer` is reachable at visibility `pub` | note: but type `OptdOptimizer` is only usable at visibility `pub(crate)` --> infra/src/lib.rs:41:1 | 41 | struct OptdOptimizer {} | ^^^^^^^^^^^^^^^^^^^^ = note: `#[warn(private_interfaces)]` on by default
[clippy] infra/src/lib.rs#L165: infra/src/lib.rs#L165
warning: type `OptdOptimizer` is more private than the item `OptdQueryPlanner::new` --> infra/src/lib.rs:165:5 | 165 | pub fn new(optimizer: OptdOptimizer) -> Self { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ associated function `OptdQueryPlanner::new` is reachable at visibility `pub` | note: but type `OptdOptimizer` is only usable at visibility `pub(crate)` --> infra/src/lib.rs:41:1 | 41 | struct OptdOptimizer {} | ^^^^^^^^^^^^^^^^^^^^
[clippy] infra/src/types/memo.rs#L56: infra/src/types/memo.rs#L56
warning: method `add_logical_expr_to_group` is never used --> infra/src/types/memo.rs:58:18 | 56 | impl Memo { | --------- method in this implementation 57 | /// TODO(alexis) Add docs. 58 | pub async fn add_logical_expr_to_group( | ^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default
[clippy] infra/src/types/operator/relational/logical/mod.rs#L26: infra/src/types/operator/relational/logical/mod.rs#L26
warning: variants `Scan`, `Project`, and `Join` are never constructed --> infra/src/types/operator/relational/logical/mod.rs:27:5 | 26 | pub enum LogicalOperator<Relation, Scalar> { | --------------- variants in this enum 27 | Scan(Scan<Scalar>), | ^^^^ 28 | Filter(Filter<Relation, Scalar>), 29 | Project(Project<Relation, Scalar>), | ^^^^^^^ 30 | Join(Join<Relation, Scalar>), | ^^^^ | = note: `LogicalOperator` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis
[clippy] infra/src/types/operator/relational/logical/project.rs#L6: infra/src/types/operator/relational/logical/project.rs#L6
warning: fields `child` and `fields` are never read --> infra/src/types/operator/relational/logical/project.rs:7:9 | 6 | pub struct Project<Relation, Scalar> { | ------- fields in this struct 7 | pub child: Relation, | ^^^^^ 8 | pub fields: Vec<Scalar>, | ^^^^^^ | = note: `Project` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis
[clippy] infra/src/types/operator/relational/physical/mod.rs#L26: infra/src/types/operator/relational/physical/mod.rs#L26
warning: variants `Project`, `NestedLoopJoin`, and `SortMergeJoin` are never constructed --> infra/src/types/operator/relational/physical/mod.rs:29:5 | 26 | pub enum PhysicalOperator<Relation, Scalar> { | ---------------- variants in this enum ... 29 | Project(Project<Relation, Scalar>), | ^^^^^^^ 30 | HashJoin(HashJoin<Relation, Scalar>), 31 | NestedLoopJoin(NestedLoopJoin<Relation, Scalar>), | ^^^^^^^^^^^^^^ 32 | SortMergeJoin(MergeJoin<Relation, Scalar>), | ^^^^^^^^^^^^^ | = note: `PhysicalOperator` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis
[clippy] infra/src/types/operator/relational/physical/filter/filter.rs#L7: infra/src/types/operator/relational/physical/filter/filter.rs#L7
warning: fields `child` and `predicate` are never read --> infra/src/types/operator/relational/physical/filter/filter.rs:8:9 | 7 | pub struct Filter<Relation, Scalar> { | ------ fields in this struct 8 | pub child: Relation, | ^^^^^ 9 | pub predicate: Scalar, | ^^^^^^^^^ | = note: `Filter` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis
[clippy] infra/src/types/operator/relational/physical/join/hash_join.rs#L7: infra/src/types/operator/relational/physical/join/hash_join.rs#L7
warning: fields `join_type`, `probe_side`, `build_side`, and `condition` are never read --> infra/src/types/operator/relational/physical/join/hash_join.rs:8:9 | 7 | pub struct HashJoin<Relation, Scalar> { | -------- fields in this struct 8 | pub join_type: String, | ^^^^^^^^^ 9 | /// Left relation that probes hash table. 10 | pub probe_side: Relation, | ^^^^^^^^^^ 11 | /// Right relation used to build hash table. 12 | pub build_side: Relation, | ^^^^^^^^^^ 13 | pub condition: Scalar, | ^^^^^^^^^ | = note: `HashJoin` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis
[clippy] infra/src/types/operator/relational/physical/join/merge_join.rs#L6: infra/src/types/operator/relational/physical/join/merge_join.rs#L6
warning: fields `join_type`, `left_sorted`, `right_sorted`, and `condition` are never read --> infra/src/types/operator/relational/physical/join/merge_join.rs:7:9 | 6 | pub struct MergeJoin<Relation, Scalar> { | --------- fields in this struct 7 | pub join_type: String, | ^^^^^^^^^ 8 | /// Left sorted relation. 9 | pub left_sorted: Relation, | ^^^^^^^^^^^ 10 | /// Right sorted relation. 11 | pub right_sorted: Relation, | ^^^^^^^^^^^^ 12 | pub condition: Scalar, | ^^^^^^^^^ | = note: `MergeJoin` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis
[clippy] infra/src/types/operator/relational/physical/join/nested_loop_join.rs#L6: infra/src/types/operator/relational/physical/join/nested_loop_join.rs#L6
warning: fields `join_type`, `outer`, `inner`, and `condition` are never read --> infra/src/types/operator/relational/physical/join/nested_loop_join.rs:7:9 | 6 | pub struct NestedLoopJoin<Relation, Scalar> { | -------------- fields in this struct 7 | pub join_type: String, | ^^^^^^^^^ 8 | /// Outer relation. 9 | pub outer: Relation, | ^^^^^ 10 | /// Inner relation scanned for each outer row. 11 | pub inner: Relation, | ^^^^^ 12 | pub condition: Scalar, | ^^^^^^^^^ | = note: `NestedLoopJoin` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis
[clippy] infra/src/types/operator/relational/physical/project/project.rs#L6: infra/src/types/operator/relational/physical/project/project.rs#L6
warning: fields `child` and `fields` are never read --> infra/src/types/operator/relational/physical/project/project.rs:7:9 | 6 | pub struct Project<Relation, Scalar> { | ------- fields in this struct 7 | pub child: Relation, | ^^^^^ 8 | pub fields: Vec<Scalar>, | ^^^^^^ | = note: `Project` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis
[clippy] infra/src/types/operator/relational/physical/scan/table_scan.rs#L6: infra/src/types/operator/relational/physical/scan/table_scan.rs#L6
warning: fields `table_name` and `predicate` are never read --> infra/src/types/operator/relational/physical/scan/table_scan.rs:7:9 | 6 | pub struct TableScan<Scalar> { | --------- fields in this struct 7 | pub table_name: String, // TODO(alexis): Mocked for now. | ^^^^^^^^^^ 8 | pub predicate: Option<Scalar>, | ^^^^^^^^^ | = note: `TableScan` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis
[clippy] infra/src/types/operator/scalar/mod.rs#L22: infra/src/types/operator/scalar/mod.rs#L22
warning: variants `Add`, `ColumnRef`, and `Constant` are never constructed --> infra/src/types/operator/scalar/mod.rs:23:5 | 22 | pub enum ScalarOperator<Scalar> { | -------------- variants in this enum 23 | Add(Add<Scalar>), | ^^^ 24 | ColumnRef(ColumnRef), | ^^^^^^^^^ 25 | Constant(Constant), | ^^^^^^^^ | = note: `ScalarOperator` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis
[clippy] infra/src/types/operator/scalar/add.rs#L3: infra/src/types/operator/scalar/add.rs#L3
warning: fields `left` and `right` are never read --> infra/src/types/operator/scalar/add.rs:4:9 | 3 | pub struct Add<Scalar> { | --- fields in this struct 4 | pub left: Scalar, | ^^^^ 5 | pub right: Scalar, | ^^^^^ | = note: `Add` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis
[clippy] infra/src/types/operator/scalar/constants.rs#L3: infra/src/types/operator/scalar/constants.rs#L3
warning: variants `String`, `Integer`, `Float`, and `Boolean` are never constructed --> infra/src/types/operator/scalar/constants.rs:5:5 | 3 | pub enum Constant { | -------- variants in this enum 4 | /// String constant (e.g. "hello"). 5 | String(String), | ^^^^^^ 6 | /// Integer constant (e.g. 42). 7 | Integer(i64), | ^^^^^^^ 8 | /// Floating point constant (e.g. 3.14). 9 | Float(f64), | ^^^^^ 10 | /// Boolean constant (e.g. true, false). 11 | Boolean(bool), | ^^^^^^^ | = note: `Constant` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis
[clippy] infra/src/types/plan/logical_plan.rs#L17: infra/src/types/plan/logical_plan.rs#L17
warning: field `node` is never read --> infra/src/types/plan/logical_plan.rs:18:9 | 17 | pub struct LogicalPlan { | ----------- field in this struct 18 | pub node: Arc<LogicalOperator<LogicalPlan, ScalarPlan>>, | ^^^^ | = note: `LogicalPlan` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis
[clippy] infra/src/types/plan/partial_logical_plan.rs#L26: infra/src/types/plan/partial_logical_plan.rs#L26
warning: field `node` is never read --> infra/src/types/plan/partial_logical_plan.rs:27:9 | 26 | pub struct PartialLogicalPlan { | ------------------ field in this struct 27 | pub node: Arc<LogicalOperator<Relation, Scalar>>, | ^^^^ | = note: `PartialLogicalPlan` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis
[clippy] infra/src/types/plan/partial_logical_plan.rs#L36: infra/src/types/plan/partial_logical_plan.rs#L36
warning: variants `Operator` and `GroupId` are never constructed --> infra/src/types/plan/partial_logical_plan.rs:37:5 | 36 | pub enum Relation { | -------- variants in this enum 37 | Operator(Arc<LogicalOperator<Relation, Scalar>>), | ^^^^^^^^ 38 | GroupId(GroupId), | ^^^^^^^ | = note: `Relation` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis
[clippy] infra/src/types/plan/partial_logical_plan.rs#L47: infra/src/types/plan/partial_logical_plan.rs#L47
warning: variants `Operator` and `GroupId` are never constructed --> infra/src/types/plan/partial_logical_plan.rs:48:5 | 47 | pub enum Scalar { | ------ variants in this enum 48 | Operator(Arc<ScalarOperator<Scalar>>), | ^^^^^^^^ 49 | GroupId(GroupId), | ^^^^^^^ | = note: `Scalar` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis
[clippy] infra/src/types/plan/physical_plan.rs#L17: infra/src/types/plan/physical_plan.rs#L17
warning: struct `PhysicalPlan` is never constructed --> infra/src/types/plan/physical_plan.rs:17:12 | 17 | pub struct PhysicalPlan { | ^^^^^^^^^^^^ | = note: `PhysicalPlan` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis
[clippy] infra/src/types/plan/scalar_plan.rs#L7: infra/src/types/plan/scalar_plan.rs#L7
warning: field `node` is never read --> infra/src/types/plan/scalar_plan.rs:8:9 | 7 | pub struct ScalarPlan { | ---------- field in this struct 8 | pub node: Arc<ScalarOperator<ScalarPlan>>, | ^^^^ | = note: `ScalarPlan` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis
[clippy] infra/src/lib.rs#L153: infra/src/lib.rs#L153
warning: variable `optdLogicalPlan` should have a snake case name --> infra/src/lib.rs:153:13 | 153 | let optdLogicalPlan = Self::conv_df_to_optd_relational(logical_plan); | ^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `optd_logical_plan` | = note: `#[warn(non_snake_case)]` on by default
[clippy] infra/src/main.rs#L4: infra/src/main.rs#L4
warning: use of deprecated type alias `datafusion::execution::runtime_env::RuntimeConfig`: please use `RuntimeEnvBuilder` instead --> infra/src/main.rs:4:41 | 4 | use datafusion::execution::runtime_env::RuntimeConfig; | ^^^^^^^^^^^^^ | = note: `#[warn(deprecated)]` on by default
[clippy] infra/src/main.rs#L15: infra/src/main.rs#L15
warning: use of deprecated type alias `datafusion::execution::runtime_env::RuntimeConfig`: please use `RuntimeEnvBuilder` instead --> infra/src/main.rs:15:21 | 15 | let rt_config = RuntimeConfig::new(); | ^^^^^^^^^^^^^