Skip to content

Conversation

apedicdev
Copy link
Contributor

Added varnish on production mode, in case you wanted merge or have a separate branch

Ssl proxy
Magento production mode
@apedicdev apedicdev force-pushed the apedik/varnish-production-mode branch from 8971790 to 7beaf91 Compare September 13, 2023 15:58
@cmtickle
Copy link
Owner

Hi @apedicdev,

There is functionality in the scripts to piggy-back the magento deploy:mode:set and copy files in to enable production mode. here : https://github.com/cmtickle/docker-stack/blob/master/project/includes/_functions_m2.sh#L249

I feel it would be better if this functionality was added by extending there. The primary use of this docker-stack is as a development environment, these changes would potentially make things more difficult whilst developing.

Please let me know what you think?

@apedicdev
Copy link
Contributor Author

@cmtickle it definitely makes sense, that's why I had created a separated branch, in case we would like to test production mode with varnish full page cache enabled. I will have a look how to extend the included functionality and possibly merge it to master once it can be enabled/disabled easily

@apedicdev apedicdev force-pushed the apedik/varnish-production-mode branch from a926d84 to 611894d Compare September 15, 2023 10:29
@apedicdev apedicdev force-pushed the apedik/varnish-production-mode branch from d3debdd to a9f1591 Compare September 15, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants