-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Just in time Principal updates #47602
base: master
Are you sure you want to change the base?
Conversation
Check that Event, LuminosityBlock and Run have consistent ProductRegistries.
Reading a new file can cause the ProductRegistry to be modified which may require the Principal to update its internal data structure. Now check if the ProductRegistry changed just before the Principal will be used for data processing.
cms-bot internal usage |
please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47602/44104
|
A new Pull Request was created by @Dr15Jones for master. It involves the following packages:
@Dr15Jones, @makortel, @smuzaffar can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
-1 Failed Tests: UnitTests Unit TestsI found 5 errors in the following unit tests: ---> test testTauEmbeddingWorkflow2016preVFP had ERRORS ---> test testTauEmbeddingWorkflow2017 had ERRORS ---> test testTauEmbeddingWorkflow2016postVFP had ERRORS and more ... Comparison SummarySummary:
|
PR description:
Update the Principals' meta data the first time it is used after a new file has been opened (which is the only time the ProductRegistry is allowed to be updated).
PR validation:
Code compiles, framework unit tests pass.
resolves cms-sw/framework-team#1208