Improve BDT in L1Trigger/L1TMuonEndCap

[Dr15Jones]

PR description:

• fixed memory corruption problems which could lead to double deletes or deletion of random memory locations
• memory handling now done via std::unique_ptr
• improved const correctness

This deletion of memory coming from an uninitialized pointer was found by gcc 14.

PR validation:

Code compiles and local tests pass.

resolves cms-sw/framework-team#1307

[cmsbuild]

cms-bot internal usage

[Dr15Jones]

please test

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47599/44099

• There are other open Pull requests which might conflict with changes you have proposed:
  • File L1Trigger/L1TMuonEndCap/interface/bdt/Tree.h modified in PR(s): [GCC14] Fix compiler warnings #47556
  • File L1Trigger/L1TMuonEndCap/src/bdt/Tree.cc modified in PR(s): [GCC14] Fix compiler warnings #47556

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47599/44099/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47599/44099/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[Dr15Jones]

NOTE: using the defaultly made Node(Node&&) with this implementation of a destructor leads to double delete of leftDaughter and rightDaughter as the default Node(Node&&) will not reset the pointers to nullptr.

[Dr15Jones]

This is the problem spotted by gcc 14. rootNode is uninitialized at this point so the following line deletes some random address.

[Dr15Jones]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47599/44100

• There are other open Pull requests which might conflict with changes you have proposed:
  • File L1Trigger/L1TMuonEndCap/interface/bdt/Tree.h modified in PR(s): [GCC14] Fix compiler warnings #47556
  • File L1Trigger/L1TMuonEndCap/src/bdt/Tree.cc modified in PR(s): [GCC14] Fix compiler warnings #47556

[cmsbuild]

A new Pull Request was created by @Dr15Jones for master.

It involves the following packages:

• L1Trigger/L1TMuonEndCap (l1)

@aloeliger, @epalencia can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @dinyar, @eyigitba, @missirol, @mmusich, @thomreis this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[makortel]

(just to remind, the code improved in this PR is uses substantial amount of memory as reported in #42526)

[cmsbuild]

+1

Size: This PR adds an extra 36KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c88bb7/44981/summary.html
COMMIT: 96be2a4
CMSSW: CMSSW_15_1_X_2025-03-14-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/47599/44981/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 1 lines to the logs
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3927607
• DQMHistoTests: Total failures: 24
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3927563
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 215 log files, 184 edm output root files, 50 DQM output files
• TriggerResults: no differences found