Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Muon dxy 1D Histograms added to all Electron and Muon directories, extended range for PvMult plots for GEN-SIM-RECO AND MINIAOD directories at DQM/Physics #47592

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

dsidirop1
Copy link
Contributor

Description of PR

  • The main changes expected include the addition of 1D d_xy histograms for TopSingleElectronMediumDQM, TopSingleMuonMediumDQM, SingleTopElectronMediumDQM, SingleTopMuonMediumDQM and the corresponding miniAOD directories.
  1. For GEN-SIM-RECO directories the relevant histograms were booked and the following code added:
// d_xy distribution
if (muon->muonBestTrack().isNonnull()) {
double dxy = muon->muonBestTrack()->dxy(Pvertex.position());
fill("muonDxy_", dxy);
}
  1. For MINOAOD directories the dB function was used to access the d_xy quantity from pat::Muon and since the edB function calculating the error for d_xy also exists it was added as well for completion:
// d_xy distribution
if (muon->muonBestTrack().isNonnull()) {
double dxy = muon->dB(pat::Muon::PV2D);
fill("muonDxy_", dxy);

double dxyError = muon->edB(pat::Muon::PV2D);
fill("muonDxyError_",dxyError);
}

PR validation

Changes have been made to the following files:

  1. DQM/Physics/src/TopSingleLeptonDQM.cc
  2. DQM/Physics/src/SingleTopTChannelLeptonDQM.cc
  3. DQM/Physics/src/TopSingleLeptonDQM_miniAOD.cc
  4. DQM/Physics/src/SingleTopTChannelLeptonDQM_miniAOD.cc
  5. DQM/Physics/test/topDQM_harvesting_cfg.py
  6. DQM/Physics/test/topDQM_production_cfg.py
  7. DQM/Physics/test/topDQM_harvesting_miniAOD.py (new file)
  8. DQM/Physics/test/topDQM_production_miniAOD.py

To verify the results of the aforementioned actions the files DQM/Physics/test/topDQM_production_cfg.py and DQM/Physics/test/topDQM_production_miniAOD.py were executed with cmsRun to produce .root files that were then used as input for DQM/Physics/test/topDQM_harvesting_cfg.py and DQM/Physics/test/topDQM_harvesting_miniAOD.py to produce trees with the relevant histograms needed that were browsed using the TBrowser root feature. As evidence of the success of the task two of those d_xy histograms (one from TopSingleMuonMediumDQM and the other from SingleTopMuonMediumDQM_miniAOD) are attached on this PR along with one PvMult histogram with the new range.

dxy_RECO_TopSingleMuonMediumDQM
dxy_MINIAOD_SingleTopMuonMediumDQM
canvas

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 13, 2025

cms-bot internal usage

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47592/44084

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @dsidirop1 for master.

It involves the following packages:

  • DQM/Physics (dqm)

@antoniovagnerini, @cmsbuild, @rseidita can you please review it and eventually sign? Thanks.
@rappoccio this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants