Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15_0_X] Remove FinalPath from the framework #47583

Open
wants to merge 2 commits into
base: CMSSW_15_0_X
Choose a base branch
from

Conversation

makortel
Copy link
Contributor

PR description:

On HLT request (#47546 (comment)) this PR backports #47546 to 15_0_X. The FinalPath was removed from HLT menu in 15_0_X in #47530 that is already merged.

PR validation:

None beyond #47546.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #47546

The feature was a bit of a workaround that constrained the task
scheduling system in weird ways, and is no longer being used in HLT.
@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 12, 2025

A new Pull Request was created by @makortel for CMSSW_15_0_X.

It involves the following packages:

  • FWCore/Framework (core)
  • FWCore/Integration (core)
  • FWCore/ParameterSet (core)
  • HLTrigger/Configuration (hlt)

@Dr15Jones, @Martin-Grunewald, @cmsbuild, @makortel, @mmusich, @smuzaffar can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @mmusich, @wddgit this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 12, 2025

cms-bot internal usage

@makortel
Copy link
Contributor Author

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 92KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e54b63/44944/summary.html
COMMIT: f3f0945
CMSSW: CMSSW_15_0_X_2025-03-12-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/47583/44944/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 1 lines from the logs
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 4018889
  • DQMHistoTests: Total failures: 85
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4018784
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 218 log files, 189 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor

mmusich commented Mar 13, 2025

backport of #47546

@mmusich
Copy link
Contributor

mmusich commented Mar 13, 2025

+hlt

@mmusich
Copy link
Contributor

mmusich commented Mar 13, 2025

@cms-sw/orp-l2 please consider this for the next 15.0.X release.

@makortel
Copy link
Contributor Author

Comparison differences are related to #47071

@makortel
Copy link
Contributor Author

+core

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_15_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_15_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants