Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0.X] add missing defaults to MkFitProducer::fillDescriptions #47578

Open
wants to merge 1 commit into
base: CMSSW_15_0_X
Choose a base branch
from

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Mar 12, 2025

backport of #47575

PR description:

While trying to parse in confDB the resulting menu from the customization proposed at CMSHLT-3421, it was noticed that certain parameters in MkFitProducer were not assigned the right cms type.
This was analyzed as a lack of appropriate defaults in the fillDescriptions of the producer, which as per coding rule 6.14 link is needed for modules used at HLT.

PR validation:

cmssw compiles

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

verbatim backport of #47575 to the 2025 data-taking release.

@mmusich
Copy link
Contributor Author

mmusich commented Mar 12, 2025

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 12, 2025

A new Pull Request was created by @mmusich for CMSSW_15_0_X.

It involves the following packages:

  • RecoTracker/MkFit (reconstruction)

@jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @VinInn, @VourMa, @dgulhan, @felicepantaleo, @gpetruc, @makortel, @missirol, @mmusich, @mtosi, @rovere this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mmusich mmusich changed the title add missing defaults to MkFitProducer::fillDescriptions [15.0.X] add missing defaults to MkFitProducer::fillDescriptions Mar 12, 2025
@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 12, 2025

cms-bot internal usage

@mmusich mmusich changed the title [15.0.X] add missing defaults to MkFitProducer::fillDescriptions [15.0.X] add missing defaults to MkFitProducer::fillDescriptions Mar 12, 2025
@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-238308/44942/summary.html
COMMIT: 69cf95f
CMSSW: CMSSW_15_0_X_2025-03-12-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/47578/44942/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@mmusich
Copy link
Contributor Author

mmusich commented Mar 12, 2025

urgent

  • please consider this for next 15.0. release (needed for HLT menu integration)

@mmusich
Copy link
Contributor Author

mmusich commented Mar 12, 2025

type hlt-integration

@jfernan2
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_15_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_15_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @mandrenguyen, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants