-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[15.0.X] add missing defaults to MkFitProducer::fillDescriptions
#47578
base: CMSSW_15_0_X
Are you sure you want to change the base?
[15.0.X] add missing defaults to MkFitProducer::fillDescriptions
#47578
Conversation
@cmsbuild, please test |
A new Pull Request was created by @mmusich for CMSSW_15_0_X. It involves the following packages:
@jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
cms-bot internal usage |
MkFitProducer::fillDescriptions
+1 Size: This PR adds an extra 20KB to repository Comparison SummarySummary:
|
urgent
|
type hlt-integration |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_15_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_15_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @mandrenguyen, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
backport of #47575
PR description:
While trying to parse in confDB the resulting menu from the customization proposed at CMSHLT-3421, it was noticed that certain parameters in
MkFitProducer
were not assigned the rightcms
type.This was analyzed as a lack of appropriate defaults in the
fillDescriptions
of the producer, which as per coding rule 6.14 link is needed for modules used at HLT.PR validation:
cmssw
compilesIf this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
verbatim backport of #47575 to the 2025 data-taking release.