Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase threshold of max number of strips clusters for cosmics #47577

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jlidrych
Copy link
Contributor

PR description:

We are increasing the threshold for the number of clusters in strips to 1000 in the configurations for Cosmic tracking. The default was 300.
This PR is similar in spirit to #46283.

If this PR is a backport please specify the original PR and why you need to backport that PR.

Not a backport. Backport will be done for 14_2_X.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 12, 2025

cms-bot internal usage

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @jlidrych for master.

It involves the following packages:

  • RecoTracker/SpecialSeedGenerators (reconstruction)

@cmsbuild, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @VinInn, @VourMa, @dgulhan, @felicepantaleo, @gpetruc, @missirol, @mmusich, @mtosi, @rovere this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor

mmusich commented Mar 12, 2025

@jlidrych, @cms-sw/trk-dpg-l2 how about the cut in the HLT menu paths ?

e.g. here:

fragment.hltSimpleCosmicBONSeeds = cms.EDProducer( "SimpleCosmicBONSeeder",
TTRHBuilder = cms.string( "hltESPTTRHBWithTrackAngle" ),
ClusterCheckPSet = cms.PSet(
MaxNumberOfPixelClusters = cms.uint32( 1000 ),
DontCountDetsAboveNClusters = cms.uint32( 20 ),
ClusterCollectionLabel = cms.InputTag( "hltFullSiStripRawToClustersFacility" ),
MaxNumberOfStripClusters = cms.uint32( 300 ),

or

fragment.hltCombinatorialcosmicseedfinderP5 = cms.EDProducer( "CtfSpecialSeedGenerator",
SeedMomentum = cms.double( 5.0 ),
ErrorRescaling = cms.double( 50.0 ),
UseScintillatorsConstraint = cms.bool( False ),
TTRHBuilder = cms.string( "hltESPTTRHBWithTrackAngle" ),
SeedsFromPositiveY = cms.bool( True ),
SeedsFromNegativeY = cms.bool( False ),
CheckHitsAreOnDifferentLayers = cms.bool( False ),
SetMomentum = cms.bool( True ),
requireBOFF = cms.bool( True ),
maxSeeds = cms.int32( 10000 ),
doClusterCheck = cms.bool( True ),
MaxNumberOfStripClusters = cms.uint32( 300 ),

will you open a CMSHLT JIRA ticket to increase the cuts also in the HLT menu?

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Pull request #47577 was updated. @Martin-Grunewald, @cmsbuild, @jfernan2, @mandrenguyen, @mmusich can you please check and sign again.

@@ -10678,7 +10678,7 @@
MaxNumberOfPixelClusters = cms.uint32( 1000 ),
DontCountDetsAboveNClusters = cms.uint32( 20 ),
ClusterCollectionLabel = cms.InputTag( "hltFullSiStripRawToClustersFacility" ),
MaxNumberOfStripClusters = cms.uint32( 300 ),
MaxNumberOfStripClusters = cms.uint32( 1000 ),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a generated file, any change made here will be overwritten.
Instead, file a CMSHLT JIRA ticket requesting this change.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the meantime, code a customisation function c.f. HLTrigger/Configuration/python/customizeHLTforCMSSW.py

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I have just opened CMSHLT JIRA ticket.
I'll undo this change - my apologies.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I see https://its.cern.ch/jira/browse/CMSHLT-3443
Please have a look there on the treatment of 14_2 vs 15_0 and 15_1.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...as far as the HLT Special menu is concerned.

@@ -10873,7 +10873,7 @@
requireBOFF = cms.bool( True ),
maxSeeds = cms.int32( 10000 ),
doClusterCheck = cms.bool( True ),
MaxNumberOfStripClusters = cms.uint32( 300 ),
MaxNumberOfStripClusters = cms.uint32( 1000 ),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above.

@Martin-Grunewald
Copy link
Contributor

-1
for HLT

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47577/44087

  • There are other open Pull requests which might conflict with changes you have proposed:

@cmsbuild
Copy link
Contributor

Pull request #47577 was updated. @Martin-Grunewald, @cmsbuild, @jfernan2, @mandrenguyen, @mmusich can you please check and sign again.

@mmusich
Copy link
Contributor

mmusich commented Mar 13, 2025

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-768f4c/44971/summary.html
COMMIT: d253042
CMSSW: CMSSW_15_1_X_2025-03-13-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/47577/44971/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@mmusich
Copy link
Contributor

mmusich commented Mar 14, 2025

+hlt

  • technically the customization in the customizeHLTforCMSSW.py file is a no-op because we have already integrated in the Special menu the change at CMSHLT-3443, but it doesn't harm to have it here and let it be tested in IBs first (we'll remove it in the next train of TSG/STORM updates)

@jfernan2
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants