-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase threshold of max number of strips clusters for cosmics #47577
base: master
Are you sure you want to change the base?
Conversation
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47577/44062 |
A new Pull Request was created by @jlidrych for master. It involves the following packages:
@cmsbuild, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@jlidrych, @cms-sw/trk-dpg-l2 how about the cut in the HLT menu paths ? e.g. here: cmssw/HLTrigger/Configuration/python/HLT_Special_cff.py Lines 10702 to 10708 in eb45085
or cmssw/HLTrigger/Configuration/python/HLT_Special_cff.py Lines 10891 to 10903 in eb45085
will you open a CMSHLT JIRA ticket to increase the cuts also in the HLT menu? |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47577/44063 |
Pull request #47577 was updated. @Martin-Grunewald, @cmsbuild, @jfernan2, @mandrenguyen, @mmusich can you please check and sign again. |
@@ -10678,7 +10678,7 @@ | |||
MaxNumberOfPixelClusters = cms.uint32( 1000 ), | |||
DontCountDetsAboveNClusters = cms.uint32( 20 ), | |||
ClusterCollectionLabel = cms.InputTag( "hltFullSiStripRawToClustersFacility" ), | |||
MaxNumberOfStripClusters = cms.uint32( 300 ), | |||
MaxNumberOfStripClusters = cms.uint32( 1000 ), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a generated file, any change made here will be overwritten.
Instead, file a CMSHLT JIRA ticket requesting this change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the meantime, code a customisation function c.f. HLTrigger/Configuration/python/customizeHLTforCMSSW.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I have just opened CMSHLT JIRA ticket.
I'll undo this change - my apologies.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I see https://its.cern.ch/jira/browse/CMSHLT-3443
Please have a look there on the treatment of 14_2 vs 15_0 and 15_1.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
...as far as the HLT Special menu is concerned.
@@ -10873,7 +10873,7 @@ | |||
requireBOFF = cms.bool( True ), | |||
maxSeeds = cms.int32( 10000 ), | |||
doClusterCheck = cms.bool( True ), | |||
MaxNumberOfStripClusters = cms.uint32( 300 ), | |||
MaxNumberOfStripClusters = cms.uint32( 1000 ), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above.
-1 |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47577/44064 |
7b7650d
to
d77e23c
Compare
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47577/44086 ERROR: Unable to merge PR. See log https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47577/44086/cms-checkout-topic.log |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47577/44087
|
Pull request #47577 was updated. @Martin-Grunewald, @cmsbuild, @jfernan2, @mandrenguyen, @mmusich can you please check and sign again. |
@cmsbuild, please test |
+1 Size: This PR adds an extra 24KB to repository Comparison SummarySummary:
|
+hlt
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
PR description:
We are increasing the threshold for the number of clusters in strips to
1000
in the configurations for Cosmic tracking. The default was300
.This PR is similar in spirit to #46283.
If this PR is a backport please specify the original PR and why you need to backport that PR.
Not a backport. Backport will be done for 14_2_X.