Increase threshold of max number of strips clusters for cosmics

[jlidrych]

PR description:

We are increasing the threshold for the number of clusters in strips to 1000 in the configurations for Cosmic tracking. The default was 300.
This PR is similar in spirit to #46283.

If this PR is a backport please specify the original PR and why you need to backport that PR.

Not a backport. Backport will be done for 14_2_X.

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47577/44062

[cmsbuild]

A new Pull Request was created by @jlidrych for master.

It involves the following packages:

• RecoTracker/SpecialSeedGenerators (reconstruction)

@cmsbuild, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @VinInn, @VourMa, @dgulhan, @felicepantaleo, @gpetruc, @missirol, @mmusich, @mtosi, @rovere this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[mmusich]

@jlidrych, @cms-sw/trk-dpg-l2 how about the cut in the HLT menu paths ?

e.g. here:

cmssw/HLTrigger/Configuration/python/HLT_Special_cff.py

Lines 10702 to 10708 in eb45085

	fragment.hltSimpleCosmicBONSeeds = cms.EDProducer( "SimpleCosmicBONSeeder",
	TTRHBuilder = cms.string( "hltESPTTRHBWithTrackAngle" ),
	ClusterCheckPSet = cms.PSet(
	MaxNumberOfPixelClusters = cms.uint32( 1000 ),
	DontCountDetsAboveNClusters = cms.uint32( 20 ),
	ClusterCollectionLabel = cms.InputTag( "hltFullSiStripRawToClustersFacility" ),
	MaxNumberOfStripClusters = cms.uint32( 300 ),

or

cmssw/HLTrigger/Configuration/python/HLT_Special_cff.py

Lines 10891 to 10903 in eb45085

	fragment.hltCombinatorialcosmicseedfinderP5 = cms.EDProducer( "CtfSpecialSeedGenerator",
	SeedMomentum = cms.double( 5.0 ),
	ErrorRescaling = cms.double( 50.0 ),
	UseScintillatorsConstraint = cms.bool( False ),
	TTRHBuilder = cms.string( "hltESPTTRHBWithTrackAngle" ),
	SeedsFromPositiveY = cms.bool( True ),
	SeedsFromNegativeY = cms.bool( False ),
	CheckHitsAreOnDifferentLayers = cms.bool( False ),
	SetMomentum = cms.bool( True ),
	requireBOFF = cms.bool( True ),
	maxSeeds = cms.int32( 10000 ),
	doClusterCheck = cms.bool( True ),
	MaxNumberOfStripClusters = cms.uint32( 300 ),

will you open a CMSHLT JIRA ticket to increase the cuts also in the HLT menu?

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47577/44063

[cmsbuild]

Pull request #47577 was updated. @Martin-Grunewald, @cmsbuild, @jfernan2, @mandrenguyen, @mmusich can you please check and sign again.

[Martin-Grunewald]

This is a generated file, any change made here will be overwritten.
Instead, file a CMSHLT JIRA ticket requesting this change.

[Martin-Grunewald]

In the meantime, code a customisation function c.f. HLTrigger/Configuration/python/customizeHLTforCMSSW.py

[jlidrych]

Ok, I have just opened CMSHLT JIRA ticket.
I'll undo this change - my apologies.

[Martin-Grunewald]

OK, I see https://its.cern.ch/jira/browse/CMSHLT-3443
Please have a look there on the treatment of 14_2 vs 15_0 and 15_1.

[Martin-Grunewald]

...as far as the HLT Special menu is concerned.

[Martin-Grunewald]

Same as above.

[Martin-Grunewald]

-1
for HLT

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47577/44064

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47577/44086

ERROR: Unable to merge PR.

See log https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47577/44086/cms-checkout-topic.log

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47577/44087

• There are other open Pull requests which might conflict with changes you have proposed:
  • File HLTrigger/Configuration/python/customizeHLTforCMSSW.py modified in PR(s): CA Extension to strips #47090

[cmsbuild]

Pull request #47577 was updated. @Martin-Grunewald, @cmsbuild, @jfernan2, @mandrenguyen, @mmusich can you please check and sign again.

[mmusich]

@cmsbuild, please test

[cmsbuild]

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-768f4c/44971/summary.html
COMMIT: d253042
CMSSW: CMSSW_15_1_X_2025-03-13-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/47577/44971/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 1 lines to the logs
• Reco comparison results: 582 differences found in the comparisons
• DQMHistoTests: Total files compared: 52
• DQMHistoTests: Total histograms compared: 4155574
• DQMHistoTests: Total failures: 2653
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 4152901
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 51 files compared)
• Checked 223 log files, 194 edm output root files, 52 DQM output files
• TriggerResults: no differences found

[mmusich]

+hlt

• technically the customization in the customizeHLTforCMSSW.py file is a no-op because we have already integrated in the Special menu the change at CMSHLT-3443, but it doesn't harm to have it here and let it be tested in IBs first (we'll remove it in the next train of TSG/STORM updates)

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)