Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to prepare for AXOL1TL v5 (15_1_X) #47564

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

quinnanm
Copy link
Contributor

@quinnanm quinnanm commented Mar 11, 2025

PR description:

related PR (15_0_X): #47552

Small changes to the AXOL1TL emulator are added for compatibility with the new version 5 model. This is dependent on cms-dist PRs for the new model (cms-sw/cmsdist#9741, cms-sw/cmsdist#9744) and assumes integration of v5 into the next menu.
A JIRA ticket for the menu changes and new model thresholds is planned imminently.

The code has 2 main changes:

the eta and phi of muon objects has been modified slightly to better match firmware implementation (ie hwEta->hwEtaAtVtx)
the model types have been updated for v5

PR validation:

This code has been validated with the new model version and all standard code checks have been performed.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 11, 2025

cms-bot internal usage

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @quinnanm for master.

It involves the following packages:

  • L1Trigger/L1TGlobal (l1)

@aloeliger, @cmsbuild, @epalencia can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @mmusich this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Pull request #47564 was updated. @aloeliger, @cmsbuild, @epalencia can you please check and sign again.

@kpedro88
Copy link
Contributor

test parameters:
pull_request = cms-sw/cmsdist#9741

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2f7533/44933/summary.html
COMMIT: 3f56498
CMSSW: CMSSW_15_1_X_2025-03-11-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/47564/44933/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation error when building:

make[1]: Leaving directory '/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/AXOL1TL/5.0.0-bd308c74c155469628aa2b6174f61b37/AXOL1TL-5.0.0/AXOL1TL_v1'
g++ -O3 -fPIC -std=c++17 -L/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/hls4mlEmulatorExtras/1.1.4-7f1f5ec35d8cc94e9bab71c7ff9456f1/lib64 -lemulator_interface -shared GTADModel_emulator_v3.o GTADModel_v3.o -o GTADModel_v3.so
make[1]: Leaving directory '/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/AXOL1TL/5.0.0-bd308c74c155469628aa2b6174f61b37/AXOL1TL-5.0.0/AXOL1TL_v3'
cp: cannot stat 'AXOL1TL_v4/GTADModel_v5.so': No such file or directory
make: *** [Makefile:16: all] Error 1
error: Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.TiFccD (%build)


RPM build errors:
line 37: It's not recommended to have unversioned Obsoletes: Obsoletes: external+AXOL1TL+5.0.0-bd308c74c155469628aa2b6174f61b37
Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.TiFccD (%build)


@missirol
Copy link
Contributor

@cms-sw/l1-l2

Maybe time to re-test and sign off ? The backport needs to get in 15_0_X sooner rather than later.

@mmusich
Copy link
Contributor

mmusich commented Mar 14, 2025

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2f7533/44983/summary.html
COMMIT: 3f56498
CMSSW: CMSSW_15_1_X_2025-03-14-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/47564/44983/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 2 lines from the logs
  • Reco comparison results: 16 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3927607
  • DQMHistoTests: Total failures: 24
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3927563
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 215 log files, 184 edm output root files, 50 DQM output files
  • TriggerResults: found differences in 3 / 48 workflows

@aloeliger
Copy link
Contributor

The trigger changes are all in AXOL1TL seeds, which should be expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants