-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes to prepare for AXOL1TL v5 (15_1_X) #47564
base: master
Are you sure you want to change the base?
Conversation
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47564/44048 |
A new Pull Request was created by @quinnanm for master. It involves the following packages:
@aloeliger, @cmsbuild, @epalencia can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47564/44049 |
Pull request #47564 was updated. @aloeliger, @cmsbuild, @epalencia can you please check and sign again. |
test parameters: |
please test |
-1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2f7533/44933/summary.html External BuildI found compilation error when building: make[1]: Leaving directory '/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/AXOL1TL/5.0.0-bd308c74c155469628aa2b6174f61b37/AXOL1TL-5.0.0/AXOL1TL_v1' g++ -O3 -fPIC -std=c++17 -L/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/hls4mlEmulatorExtras/1.1.4-7f1f5ec35d8cc94e9bab71c7ff9456f1/lib64 -lemulator_interface -shared GTADModel_emulator_v3.o GTADModel_v3.o -o GTADModel_v3.so make[1]: Leaving directory '/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/AXOL1TL/5.0.0-bd308c74c155469628aa2b6174f61b37/AXOL1TL-5.0.0/AXOL1TL_v3' cp: cannot stat 'AXOL1TL_v4/GTADModel_v5.so': No such file or directory make: *** [Makefile:16: all] Error 1 error: Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.TiFccD (%build) RPM build errors: line 37: It's not recommended to have unversioned Obsoletes: Obsoletes: external+AXOL1TL+5.0.0-bd308c74c155469628aa2b6174f61b37 Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.TiFccD (%build) |
@cms-sw/l1-l2 Maybe time to re-test and sign off ? The backport needs to get in 15_0_X sooner rather than later. |
@cmsbuild, please test |
+1 Size: This PR adds an extra 20KB to repository Comparison SummarySummary:
|
The trigger changes are all in AXOL1TL seeds, which should be expected. |
PR description:
related PR (15_0_X): #47552
Small changes to the AXOL1TL emulator are added for compatibility with the new version 5 model. This is dependent on cms-dist PRs for the new model (cms-sw/cmsdist#9741, cms-sw/cmsdist#9744) and assumes integration of v5 into the next menu.
A JIRA ticket for the menu changes and new model thresholds is planned imminently.
The code has 2 main changes:
the eta and phi of muon objects has been modified slightly to better match firmware implementation (ie hwEta->hwEtaAtVtx)
the model types have been updated for v5
PR validation:
This code has been validated with the new model version and all standard code checks have been performed.