L1 P2GT region cut checks and fixing menu config #47204

artlbv · 2025-01-29T20:06:31Z

PR description:

This is a follow up to #46489 addressing #47194

The issue appeared when the number of eta regions (bounds) did not match e.g. the number of pt region thresholds.

An exception has been introduced in the P2GT condition parser when the cut number does not match the number of eta regions as @HaarigerHarald suggested
Fixed menu conditions where the number of pt and eta regions did not match (should not affect trigger results)

PR validation:

In CMSSW_15_0_ASAN_X_2025-01-27-2300 workflow 29634.78 ran fine with the default L1P2GT:step1_2024 and the step1_2024_explicitSeeds menu.

cmsbuild · 2025-01-29T20:06:59Z

cms-bot internal usage

cmsbuild · 2025-01-29T20:09:17Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47204/43475

cmsbuild · 2025-01-29T20:09:42Z

A new Pull Request was created by @artlbv for master.

It involves the following packages:

L1Trigger/Configuration (l1)
L1Trigger/Phase2L1GT (l1, upgrade)

@Moanwar, @aloeliger, @cmsbuild, @epalencia, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @mmusich this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

mmusich · 2025-01-29T20:18:48Z

type bug-fix

mmusich · 2025-01-29T20:21:05Z

test parameters:

relvals_opt = --what upgrade
workflows = 24834.0, 29634.0, 24834.911, 29634.78

mmusich · 2025-01-29T20:22:05Z

please test for CMSSW_15_0_ASAN_X

artlbv · 2025-01-30T08:04:40Z

thanks for launching the tests @mmusich , but the bot failed with "Unable to find CMSSW IB for CMSSW_15_0_ASAN_X."
@smuzaffar @iarspider do you know why this could fail?

iarspider · 2025-01-30T08:19:03Z

please test for CMSSW_15_0_ASAN_X/el8_amd64_gcc12

iarspider · 2025-01-30T08:21:00Z

thanks for launching the tests @mmusich , but the bot failed with "Unable to find CMSSW IB for CMSSW_15_0_ASAN_X." @smuzaffar @iarspider do you know why this could fail?

If IB type is built for multiple archtectures (e.g. ASAN is now built for el8_amd64_gcc12 and el8_amd64_gcc13), you need to explicitly specify the architecture.

mmusich · 2025-01-30T08:23:03Z

If IB type is built for multiple archtectures (e.g. ASAN is now built for el8_amd64_gcc12 and el8_amd64_gcc13), you need to explicitly specify the architecture.

looks like this was not a requirement in the past.

cmsbuild · 2025-01-30T08:58:03Z

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23fe54/44051/summary.html
COMMIT: 7749d0a
CMSSW: CMSSW_15_0_ASAN_X_2025-01-29-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/47204/44051/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

ValueError: Undefined workflows: 4.22, 5.1, 4.53, 7.3, 8, 9.0, 135.4, 136.731, 136.793, 136.874, 139.001, 140.045, 141.042, 145.014, 145.104, 145.202, 145.301, 140.56, 145.408, 145.5, 145.604, 25, 1306.0, 1330, 312.0, 2500.201, 250202.181, 145.713, 101.0, 1000, 1001

smuzaffar · 2025-01-30T09:17:33Z

please test with cms-sw/cms-bot#2425 for CMSSW_15_0_ASAN_X

smuzaffar · 2025-01-30T09:20:03Z

ValueError: Undefined workflows: 4.22, 5.1, 4.53, 7.3, 8, 9.0, 135.4, 136.731, 136.793, 136.874, 139.001, 140.045, 141.042, 145.014, 145.104, 145.202, 145.301, 140.56, 145.408, 145.5, 145.604, 25, 1306.0, 1330, 312.0, 2500.201, 250202.181, 145.713, 101.0, 1000, 1001

hopefully cms-sw/cms-bot#2425 should fix this issue

L1Trigger/Phase2L1GT/plugins/L1GTSingleCollectionCut.h

cmsbuild · 2025-01-30T12:21:45Z

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23fe54/44058/summary.html
COMMIT: 7749d0a
CMSSW: CMSSW_15_0_ASAN_X_2025-01-29-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/47204/44058/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

145.301145.301_RunDisplacedJet2024E/step3_RunDisplacedJet2024E.log

cmsbuild · 2025-01-30T12:26:11Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47204/43487

cmsbuild · 2025-01-30T12:26:32Z

Pull request #47204 was updated. @Moanwar, @aloeliger, @cmsbuild, @epalencia, @srimanob, @subirsarkar can you please check and sign again.

artlbv · 2025-01-30T12:28:53Z

weird, the failed workflow is for Run3 in the L1 Muon CPPF library:

145.301 145.301_RunDisplacedJet2024E/step3_RunDisplacedJet2024E.log

SUMMARY: AddressSanitizer: heap-buffer-overflow (/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02874/el8_amd64_gcc12/cms/cmssw/CMSSW_15_0_ASAN_X_2025-01-29-2300/lib/el8_amd64_gcc12/libL1TriggerL1TMuonCPPF.so+0x1cfd6) in RecHitProcessor::processLook(edm::Event const&, edm::EventSetup const&, edm::EDGetToken const&, edm::EDGetToken const&, edm::EDGetToken const&, edm::ESGetToken<RPCGeometry, MuonGeometryRecord> const&, std::vector<RecHitProcessor::CppfItem, std::allocatorRecHitProcessor::CppfItem >&, std::vector<l1t::CPPFDigi, std::allocatorl1t::CPPFDigi >&, int) const

is this a transient or a real issue?

mmusich · 2025-01-31T10:32:24Z

@artlbv

weird, the failed workflow is for Run3 in the L1 Muon CPPF library:

It did exhibit the same issue also in the last ASAN_X IB (CMSSW_15_0_ASAN_X_2025-01-29-2300) , see logs, so I will assume it's a real preexisting issue and indeed it's already documented at #47170.

mmusich · 2025-01-31T10:32:52Z

@cmsbuild, please test

ASAN_X IB is broken for other reasons, see L1 P2GT region cut checks and fixing menu config #47204 (comment)

cmsbuild · 2025-01-31T12:54:35Z

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23fe54/44105/summary.html
COMMIT: 91e35ad
CMSSW: CMSSW_15_0_X_2025-01-30-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/47204/44105/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 1 lines to the logs
Reco comparison results: 6 differences found in the comparisons
DQMHistoTests: Total files compared: 52
DQMHistoTests: Total histograms compared: 4233390
DQMHistoTests: Total failures: 30
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 4233340
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 51 files compared)
Checked 228 log files, 197 edm output root files, 52 DQM output files
TriggerResults: no differences found

artlbv added 3 commits January 29, 2025 20:42

Add exception if P2GT eta regions not consistent with cuts

83fb71b

Fix pt cuts where less than regions in P2GT

04c5f33

Apply code format

7749d0a

cmsbuild added this to the CMSSW_15_0_X milestone Jan 29, 2025

cmsbuild added l1-pending pending-signatures tests-pending orp-pending upgrade-pending code-checks-pending labels Jan 29, 2025

artlbv mentioned this pull request Jan 29, 2025

[ASAN_X] heap-buffer-overflow in l1t::L1GTSingleCollectionCut::checkObject (checkEtaDependentCuts) #47194

Open

cmsbuild added code-checks-approved and removed code-checks-pending labels Jan 29, 2025

cmsbuild added the bug-fix label Jan 29, 2025

cmsbuild added tests-started tests-pending and removed tests-pending tests-started labels Jan 29, 2025

cmsbuild added tests-started and removed tests-pending labels Jan 30, 2025

cmsbuild added tests-rejected and removed tests-started labels Jan 30, 2025

cmsbuild added requires-external tests-started and removed tests-rejected labels Jan 30, 2025

HaarigerHarald reviewed Jan 30, 2025

View reviewed changes

L1Trigger/Phase2L1GT/plugins/L1GTSingleCollectionCut.h Outdated Show resolved Hide resolved

L1Trigger/Phase2L1GT/plugins/L1GTSingleCollectionCut.h Show resolved Hide resolved

Add check for regionsQualityFlags in P2GT

91e35ad

cmsbuild added tests-rejected tests-pending code-checks-pending and removed tests-started tests-rejected requires-external code-checks-approved labels Jan 30, 2025

cmsbuild added code-checks-approved and removed code-checks-pending labels Jan 30, 2025

cmsbuild added tests-started and removed tests-pending labels Jan 31, 2025

cmsbuild added tests-approved and removed tests-started labels Jan 31, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

L1 P2GT region cut checks and fixing menu config #47204

L1 P2GT region cut checks and fixing menu config #47204

artlbv commented Jan 29, 2025

cmsbuild commented Jan 29, 2025 •

edited

Loading

cmsbuild commented Jan 29, 2025

cmsbuild commented Jan 29, 2025

mmusich commented Jan 29, 2025

mmusich commented Jan 29, 2025

mmusich commented Jan 29, 2025

artlbv commented Jan 30, 2025

iarspider commented Jan 30, 2025

iarspider commented Jan 30, 2025

mmusich commented Jan 30, 2025

cmsbuild commented Jan 30, 2025

smuzaffar commented Jan 30, 2025

smuzaffar commented Jan 30, 2025

cmsbuild commented Jan 30, 2025

cmsbuild commented Jan 30, 2025

cmsbuild commented Jan 30, 2025

artlbv commented Jan 30, 2025

mmusich commented Jan 31, 2025

mmusich commented Jan 31, 2025

cmsbuild commented Jan 31, 2025

L1 P2GT region cut checks and fixing menu config #47204

Are you sure you want to change the base?

L1 P2GT region cut checks and fixing menu config #47204

Conversation

artlbv commented Jan 29, 2025

PR description:

PR validation:

cmsbuild commented Jan 29, 2025 • edited Loading

cmsbuild commented Jan 29, 2025

cmsbuild commented Jan 29, 2025

mmusich commented Jan 29, 2025

mmusich commented Jan 29, 2025

mmusich commented Jan 29, 2025

artlbv commented Jan 30, 2025

iarspider commented Jan 30, 2025

iarspider commented Jan 30, 2025

mmusich commented Jan 30, 2025

cmsbuild commented Jan 30, 2025

RelVals

smuzaffar commented Jan 30, 2025

smuzaffar commented Jan 30, 2025

cmsbuild commented Jan 30, 2025

RelVals

cmsbuild commented Jan 30, 2025

cmsbuild commented Jan 30, 2025

artlbv commented Jan 30, 2025

mmusich commented Jan 31, 2025

mmusich commented Jan 31, 2025

cmsbuild commented Jan 31, 2025

Comparison Summary

cmsbuild commented Jan 29, 2025 •

edited

Loading