Fix generation of cmsDriver command if accelerators contain asterisk symbol

[iarspider]

PR description:

Fix generation of cmsDriver command if accelerators contain asterisk symbol. This should fix RelVals failing with

usage: cmsDriver.py <TYPE> [options].
Example:

cmsDriver.py reco -s RAW2DIGI,RECO --conditions STARTUP_V4::All --eventcontent RECOSIM
cmsDriver.py: error: unrecognized arguments: cmdLog step1_dasquery.log step1_lumiRanges.log step2.root step2_L1REPACK_HLT.py step2_Run3-2023_JetMET2023D_RecoPixelOnlyTripletsGPU_Profiling.log threads.txt wf_stats-step2.json wf_steps.txt workflow.log

due to * expansion by the shell.

PR validation:

runTheMatrix.py works locally

[cmsbuild]

cms-bot internal usage

[iarspider]

test parameters:

• workflow_gpu = 141.044406,141.044407,141.044408,141.044412,141.044414,141.044422,141.044424,141.044483,160.03502

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47153/43382

• There are other open Pull requests which might conflict with changes you have proposed:
  • File Configuration/PyReleaseValidation/python/relval_steps.py modified in PR(s): Run-dependent pixel simulation using additionally compressed SimHit info #46884

[iarspider]

enable gpu

[cmsbuild]

A new Pull Request was created by @iarspider for master.

It involves the following packages:

• Configuration/PyReleaseValidation (pdmv, upgrade)

@AdrianoDee, @Moanwar, @cmsbuild, @DickyChant, @miquork, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fabiocos, @makortel, @missirol, @slomeo this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[iarspider]

please test for CMSSW_15_0_GPU_X

[iarspider]

please abort

[iarspider]

please test for CMSSW_15_0_GPU_X

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47153/43383

• There are other open Pull requests which might conflict with changes you have proposed:
  • File Configuration/PyReleaseValidation/python/relval_steps.py modified in PR(s): Run-dependent pixel simulation using additionally compressed SimHit info #46884

[makortel]

So runTheMatrix.py invokes cmsDriver.py through shell?

[iarspider]

So runTheMatrix.py invokes cmsDriver.py through shell?

@makortel Yes, as far as I can tell: link, which is called (for steps 2+) from here

[makortel]

So runTheMatrix.py invokes cmsDriver.py through shell?

@makortel Yes, as far as I can tell: link, which is called (for steps 2+) from here

Ok :( Thanks for the pointers. Looking from the history I see the shell=True originates from a757dd2 that seems just a minimal replacement of os.system(). So maybe removing the shell=True could be straightforward (or not). Anyway, that's for @cms-sw/pdmv-l2 to think about.

[cmsbuild]

-1

Failed Tests: RelVals-GPU
Size: This PR adds an extra 64KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-39dee3/43887/summary.html
COMMIT: 57d8aeb
CMSSW: CMSSW_15_0_X_2025-01-20-2300/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47153/43887/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-GPU

• 141.044407141.044407_Run3-2023_JetMET2023D_RecoPixelOnlyTripletsGPU_Validation/step3_Run3-2023_JetMET2023D_RecoPixelOnlyTripletsGPU_Validation.log
• 141.044483141.044483_Run3-2023_JetMET2023D_GPUValidation/step2_Run3-2023_JetMET2023D_GPUValidation.log

Comparison Summary

Summary:

• You potentially added 1 lines to the logs
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3819085
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3819065
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 214 log files, 184 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[iarspider]

Two failing RelVals also fail in IBs (I was hoping they will also be fixed), see #47152 .

[iarspider]

@cmsbuild ignore tests-rejected with ib-failure

[iarspider]

@cms-sw/pdmv-l2 @cms-sw/upgrade-l2 gentle ping

[AdrianoDee]

+pdmv

[iarspider]

@cms-sw/upgrade-l2 gentle ping

[Moanwar]

+Upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (test failures were overridden). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1