Skip to content

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Oct 1, 2025

This version introduces C++20 compatibility and removes the dependency on Boost.

See here for the release notes, and here for the full list of changes in the 2.0.0 release.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 1, 2025

A new Pull Request was created by @fwyzard for branch IB/CMSSW_16_0_X/master.

@akritkbehera, @cmsbuild, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 1, 2025

cms-bot internal usage

@fwyzard
Copy link
Contributor Author

fwyzard commented Oct 1, 2025

enable gpu

@fwyzard
Copy link
Contributor Author

fwyzard commented Oct 1, 2025

please test with cms-sw/cmssw#49042

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 1, 2025

-1

Failed Tests: UnitTests RelVals-NVIDIA_T4 nvidia_t4UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dc1302/48406/summary.html
COMMIT: 17b606b
CMSSW: CMSSW_16_0_X_2025-10-01-1100/el8_amd64_gcc13
Additional Tests: GPU,AMD_MI300X,AMD_W7900,NVIDIA_H100,NVIDIA_L40S,NVIDIA_T4
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/10103/48406/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dc1302/48406/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dc1302/48406/git-merge-result

Unit Tests

I found 2 errors in the following unit tests:

---> test alpakaTestOneHistoContainerSerialSync had ERRORS
---> test alpakaTestPrefixScanSerialSync had ERRORS

RelVals-NVIDIA_T4

  • 17034.40217034.402_TTbar_14TeV+2025PU_Patatrack_PixelOnlyAlpaka/step2_TTbar_14TeV+2025PU_Patatrack_PixelOnlyAlpaka.log
  • 17034.40317034.403_TTbar_14TeV+2025PU_Patatrack_PixelOnlyAlpaka_Validation/step2_TTbar_14TeV+2025PU_Patatrack_PixelOnlyAlpaka_Validation.log
  • 17034.41217034.412_TTbar_14TeV+2025PU_Patatrack_ECALOnlyAlpaka/step2_TTbar_14TeV+2025PU_Patatrack_ECALOnlyAlpaka.log
Expand to see more relval errors ...

Comparison Summary

Summary:

  • You potentially added 12 lines to the logs
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3923676
  • DQMHistoTests: Total failures: 29
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3923627
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
  • Checked 218 log files, 188 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

AMD_MI300X Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 242 differences found in the comparisons
  • DQMHistoTests: Total files compared: 11
  • DQMHistoTests: Total histograms compared: 146284
  • DQMHistoTests: Total failures: 27588
  • DQMHistoTests: Total nulls: 6
  • DQMHistoTests: Total successes: 118690
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 10 files compared)
  • Checked 42 log files, 45 edm output root files, 11 DQM output files
  • TriggerResults: no differences found

AMD_W7900 Comparison Summary

Summary:

NVIDIA_H100 Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 228 differences found in the comparisons
  • DQMHistoTests: Total files compared: 11
  • DQMHistoTests: Total histograms compared: 146284
  • DQMHistoTests: Total failures: 24688
  • DQMHistoTests: Total nulls: 5
  • DQMHistoTests: Total successes: 121591
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 10 files compared)
  • Checked 42 log files, 45 edm output root files, 11 DQM output files
  • TriggerResults: no differences found

NVIDIA_L40S Comparison Summary

Summary:

@fwyzard
Copy link
Contributor Author

fwyzard commented Oct 1, 2025

please test with cms-sw/cmssw#49042

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 3, 2025

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dc1302/48417/summary.html
COMMIT: 17b606b
CMSSW: CMSSW_16_0_X_2025-10-01-2300/el8_amd64_gcc13
Additional Tests: GPU,AMD_MI300X,AMD_W7900,NVIDIA_H100,NVIDIA_L40S,NVIDIA_T4
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/10103/48417/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 2 errors in the following unit tests:

---> test alpakaTestOneHistoContainerSerialSync had ERRORS
---> test alpakaTestPrefixScanSerialSync had ERRORS

Comparison Summary

Summary:

  • You potentially added 16 lines to the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3923676
  • DQMHistoTests: Total failures: 30
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3923626
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
  • Checked 218 log files, 188 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

AMD_MI300X Comparison Summary

Summary:

AMD_W7900 Comparison Summary

Summary:

NVIDIA_H100 Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 226 differences found in the comparisons
  • DQMHistoTests: Total files compared: 11
  • DQMHistoTests: Total histograms compared: 146284
  • DQMHistoTests: Total failures: 24985
  • DQMHistoTests: Total nulls: 4
  • DQMHistoTests: Total successes: 121295
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 10 files compared)
  • Checked 42 log files, 45 edm output root files, 11 DQM output files
  • TriggerResults: no differences found

NVIDIA_L40S Comparison Summary

Summary:

NVIDIA_T4 Comparison Summary

Summary:

This version introduces C++20 compatibility and removes the dependency on Boost.

See https://github.com/alpaka-group/alpaka/releases/tag/2.0.0 for the release notes,
and https://github.com/alpaka-group/alpaka/pulls?q=milestone%3A2.0.0 for the full
list of changes in the 2.0.0 release.
@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 3, 2025

Pull request #10103 was updated.

@fwyzard
Copy link
Contributor Author

fwyzard commented Oct 3, 2025

please test with cms-sw/cmssw#49042

@fwyzard
Copy link
Contributor Author

fwyzard commented Oct 3, 2025

hold

The tests look good, but let's run some benchmarks before merging the changes.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 3, 2025

Pull request has been put on hold by @fwyzard
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

@cmsbuild cmsbuild added the hold label Oct 3, 2025
@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2025

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dc1302/48444/summary.html
COMMIT: eaf0170
CMSSW: CMSSW_16_0_X_2025-10-03-1100/el8_amd64_gcc13
Additional Tests: GPU,AMD_MI300X,AMD_W7900,NVIDIA_H100,NVIDIA_L40S,NVIDIA_T4
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/10103/48444/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dc1302/48444/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dc1302/48444/git-merge-result

Comparison Summary

Summary:

  • You potentially added 214 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 69279 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3921288
  • DQMHistoTests: Total failures: 601506
  • DQMHistoTests: Total nulls: 1392
  • DQMHistoTests: Total successes: 3318370
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 20468.867 KiB( 50 files compared)
  • DQMHistoSizes: changed ( 29634.75,... ): 416.511 KiB HLT/JetMET
  • DQMHistoSizes: changed ( 10224.0,... ): 700.241 KiB JetMET/METValidation
  • DQMHistoSizes: changed ( 10224.0 ): 0.544 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 13034.0 ): -0.981 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 135.4,... ): 510.699 KiB JetMET/METValidation
  • DQMHistoSizes: changed ( 16834.0,... ): 425.300 KiB HLT/JetMET
  • DQMHistoSizes: changed ( 17034.0 ): -0.353 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 25.0,... ): 697.903 KiB JetMET/METValidation
  • DQMHistoSizes: changed ( 250202.181 ): 0.127 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 25202.0 ): -0.063 KiB SiStrip/MechanicalView
  • Checked 218 log files, 188 edm output root files, 51 DQM output files
  • TriggerResults: found differences in 14 / 49 workflows

AMD_MI300X Comparison Summary

Summary:

  • You potentially added 118 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 1021 differences found in the comparisons
  • DQMHistoTests: Total files compared: 11
  • DQMHistoTests: Total histograms compared: 146252
  • DQMHistoTests: Total failures: 100074
  • DQMHistoTests: Total nulls: 45
  • DQMHistoTests: Total successes: 46133
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 416.511 KiB( 10 files compared)
  • DQMHistoSizes: changed ( 29834.751 ): 416.511 KiB HLT/JetMET
  • Checked 42 log files, 45 edm output root files, 11 DQM output files
  • TriggerResults: found differences in 10 / 10 workflows

AMD_W7900 Comparison Summary

Summary:

  • You potentially added 118 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 1021 differences found in the comparisons
  • DQMHistoTests: Total files compared: 11
  • DQMHistoTests: Total histograms compared: 146252
  • DQMHistoTests: Total failures: 100042
  • DQMHistoTests: Total nulls: 45
  • DQMHistoTests: Total successes: 46165
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 416.511 KiB( 10 files compared)
  • DQMHistoSizes: changed ( 29834.751 ): 416.511 KiB HLT/JetMET
  • Checked 42 log files, 45 edm output root files, 11 DQM output files
  • TriggerResults: found differences in 10 / 10 workflows

NVIDIA_H100 Comparison Summary

Summary:

  • You potentially added 119 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 1021 differences found in the comparisons
  • DQMHistoTests: Total files compared: 11
  • DQMHistoTests: Total histograms compared: 146252
  • DQMHistoTests: Total failures: 100045
  • DQMHistoTests: Total nulls: 45
  • DQMHistoTests: Total successes: 46162
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 416.511 KiB( 10 files compared)
  • DQMHistoSizes: changed ( 29834.751 ): 416.511 KiB HLT/JetMET
  • Checked 42 log files, 45 edm output root files, 11 DQM output files
  • TriggerResults: found differences in 10 / 10 workflows

NVIDIA_L40S Comparison Summary

Summary:

  • You potentially added 120 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 1021 differences found in the comparisons
  • DQMHistoTests: Total files compared: 11
  • DQMHistoTests: Total histograms compared: 146252
  • DQMHistoTests: Total failures: 100071
  • DQMHistoTests: Total nulls: 45
  • DQMHistoTests: Total successes: 46136
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 416.511 KiB( 10 files compared)
  • DQMHistoSizes: changed ( 29834.751 ): 416.511 KiB HLT/JetMET
  • Checked 42 log files, 45 edm output root files, 11 DQM output files
  • TriggerResults: found differences in 10 / 10 workflows

NVIDIA_T4 Comparison Summary

Summary:

  • You potentially added 121 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 1021 differences found in the comparisons
  • DQMHistoTests: Total files compared: 11
  • DQMHistoTests: Total histograms compared: 146252
  • DQMHistoTests: Total failures: 100043
  • DQMHistoTests: Total nulls: 45
  • DQMHistoTests: Total successes: 46164
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 416.511 KiB( 10 files compared)
  • DQMHistoSizes: changed ( 29834.751 ): 416.511 KiB HLT/JetMET
  • Checked 42 log files, 45 edm output root files, 11 DQM output files
  • TriggerResults: found differences in 10 / 10 workflows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants