Skip to content

Able to use rootNavigator #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Able to use rootNavigator #117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c59effa
able to set use root navigator
devmasteripatas Jun 4, 2023
e76da20
lint fix
devmasteripatas Jun 4, 2023
dd2376b
dev local
devmasteripatas Jun 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions android/local.properties
View file
Open in desktop
Copy link

@memoriasIT memoriasIT Dec 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be fair, I don't think this should be pushed at all

Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
sdk.dir=/Users/hamidwakili/Library/Android/sdk
flutter.sdk=/Users/hamidwakili/flutter
sdk.dir=C:\\Users\\masterdev\\AppData\\Local\\Android\\Sdk
flutter.sdk=C:\\Users\\masterdev\\fvm\\versions\\stable
2 changes: 1 addition & 1 deletion example/pubspec.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ packages:
path: ".."
relative: true
source: path
version: "1.12.30-dev.1"
version: "1.12.30"
async:
dependency: transitive
description:
Expand Down
4 changes: 2 additions & 2 deletions lib/flushbar.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,13 +229,13 @@ class Flushbar<T> extends StatefulWidget {
route.FlushbarRoute<T?>? flushbarRoute;

/// Show the flushbar. Kicks in [FlushbarStatus.IS_APPEARING] state followed by [FlushbarStatus.SHOWING]
Future<T?> show(BuildContext context) async {
Future<T?> show(BuildContext context, {bool useRootNavigator = false}) async {
flushbarRoute = route.showFlushbar<T>(
context: context,
flushbar: this,
) as route.FlushbarRoute<T?>;

return await Navigator.of(context, rootNavigator: false)
return await Navigator.of(context, rootNavigator: useRootNavigator)
.push(flushbarRoute as Route<T>);
}

Expand Down