Use reactphp/async instead of clue/reactphp-block#83
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR migrates the test suite from using the deprecated clue/reactphp-block library to the modern reactphp/async library. The migration simplifies blocking operations in tests by using fibers-based async/await instead of the old blocking wait mechanism.
Changes:
- Replaced
clue/block-reactdependency withreactphp/asyncin composer.json - Updated FunctionalTest.php to use
React\Async\await()instead ofBlock\await() - Updated README.md documentation to reference
reactphp/asyncinstead ofclue/reactphp-block
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| composer.json | Replaced clue/block-react with react/async in dev dependencies |
| tests/FunctionalTest.php | Migrated from Block\await to React\Async\await, removed loop initialization, updated imports |
| README.md | Updated blocking code example to use reactphp/async instead of clue/reactphp-block |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://github.com/reactphp/async
Refs clue/reactphp-block#68 and clue/reactphp-block#67 and reactphp/async#65
Builds on top of #79 and #70